New issue
Advanced search Search tips

Issue 787131 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 782996


Show other hotlists

Hotlists containing this issue:
Launcher-Tech-Debt


Sign in to add a comment

Add UMA to Launcher pagination transition animation.

Project Member Reported by wutao@chromium.org, Nov 20 2017

Issue description

Need to convert Launcher pagination transition animation from SlideAnimation to LayerAnimation.

First thing is to add UMA to current animation so that we can evaluate the improvement/regression by converting to LayerAnimation.

 

Comment 1 by wutao@chromium.org, Nov 20 2017

Blocking: 782996
Cc: kaznacheev@chromium.org
Components: UI>Shell>Launcher
Labels: -OS-iOS
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5a6fcc0a78b6977243ad012290fb64152b5733ef

commit 5a6fcc0a78b6977243ad012290fb64152b5733ef
Author: wutao <wutao@chromium.org>
Date: Thu Nov 23 05:18:36 2017

cros: Add UMA for launcher pagination animation smoothness.

This cl adds UMA to current launcher pagination animation so that we can
evaluate the improvement/regression by converting it to LayerAnimation.

Bug:  787131 ,782996
Test: Has histogram on local device.
Change-Id: Ie3737fe0dfcbd2c7cd15f39015b036f259d27e89
Reviewed-on: https://chromium-review.googlesource.com/780442
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518856}
[modify] https://crrev.com/5a6fcc0a78b6977243ad012290fb64152b5733ef/tools/metrics/histograms/histograms.xml
[modify] https://crrev.com/5a6fcc0a78b6977243ad012290fb64152b5733ef/ui/app_list/pagination_model.cc
[modify] https://crrev.com/5a6fcc0a78b6977243ad012290fb64152b5733ef/ui/app_list/pagination_model.h
[modify] https://crrev.com/5a6fcc0a78b6977243ad012290fb64152b5733ef/ui/app_list/pagination_model_observer.h
[modify] https://crrev.com/5a6fcc0a78b6977243ad012290fb64152b5733ef/ui/app_list/pagination_model_unittest.cc
[modify] https://crrev.com/5a6fcc0a78b6977243ad012290fb64152b5733ef/ui/app_list/presenter/app_list_presenter_impl.cc
[modify] https://crrev.com/5a6fcc0a78b6977243ad012290fb64152b5733ef/ui/app_list/presenter/app_list_presenter_impl.h
[modify] https://crrev.com/5a6fcc0a78b6977243ad012290fb64152b5733ef/ui/app_list/views/apps_grid_view.cc
[modify] https://crrev.com/5a6fcc0a78b6977243ad012290fb64152b5733ef/ui/app_list/views/apps_grid_view.h
[modify] https://crrev.com/5a6fcc0a78b6977243ad012290fb64152b5733ef/ui/app_list/views/apps_grid_view_unittest.cc
[modify] https://crrev.com/5a6fcc0a78b6977243ad012290fb64152b5733ef/ui/app_list/views/contents_view.cc
[modify] https://crrev.com/5a6fcc0a78b6977243ad012290fb64152b5733ef/ui/app_list/views/contents_view.h
[modify] https://crrev.com/5a6fcc0a78b6977243ad012290fb64152b5733ef/ui/app_list/views/page_switcher_horizontal.cc
[modify] https://crrev.com/5a6fcc0a78b6977243ad012290fb64152b5733ef/ui/app_list/views/page_switcher_horizontal.h
[modify] https://crrev.com/5a6fcc0a78b6977243ad012290fb64152b5733ef/ui/app_list/views/page_switcher_vertical.cc
[modify] https://crrev.com/5a6fcc0a78b6977243ad012290fb64152b5733ef/ui/app_list/views/page_switcher_vertical.h

Comment 3 by vadimt@chromium.org, Nov 27 2017

Labels: Touch-Friendly-Launcher Touch-Friendly-Launcher-Triaged

Comment 4 by wutao@chromium.org, Mar 6 2018

Status: Fixed (was: Available)

Sign in to add a comment