New issue
Advanced search Search tips

Issue 787127 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Use Origin instead of GURL for the main_frame_origin field in Autofill.

Project Member Reported by se...@chromium.org, Nov 20 2017

Issue description

The Origin and MainFrameOrigin fields in Autofill should use url::Origin instead or GURL.


 

Comment 1 by se...@chromium.org, Nov 23 2017

Summary: Use Origin instead of GURL for the main_frame_origin field in Autofill. (was: Use Origin instead of GURL for origin and main_frame_origin fields in Autofill.)
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ccc8344674b98aee5f25a2acf7e6a28f91b73cb0

commit ccc8344674b98aee5f25a2acf7e6a28f91b73cb0
Author: sebsg <sebsg@chromium.org>
Date: Thu Nov 23 16:33:48 2017

[Autofill] Use Origin type for main_frame_origin field.

Previously used GURL

Bug:  787127 
Change-Id: I312fe37555bf680cba281c66998cead3f6e542a3
Reviewed-on: https://chromium-review.googlesource.com/786332
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518957}
[modify] https://crrev.com/ccc8344674b98aee5f25a2acf7e6a28f91b73cb0/components/autofill/content/common/BUILD.gn
[modify] https://crrev.com/ccc8344674b98aee5f25a2acf7e6a28f91b73cb0/components/autofill/content/common/autofill_param_traits_macros.h
[modify] https://crrev.com/ccc8344674b98aee5f25a2acf7e6a28f91b73cb0/components/autofill/content/common/autofill_types.mojom
[modify] https://crrev.com/ccc8344674b98aee5f25a2acf7e6a28f91b73cb0/components/autofill/content/common/autofill_types_struct_traits.h
[modify] https://crrev.com/ccc8344674b98aee5f25a2acf7e6a28f91b73cb0/components/autofill/content/renderer/form_autofill_util.cc
[modify] https://crrev.com/ccc8344674b98aee5f25a2acf7e6a28f91b73cb0/components/autofill/core/browser/autofill_manager.cc
[modify] https://crrev.com/ccc8344674b98aee5f25a2acf7e6a28f91b73cb0/components/autofill/core/browser/autofill_metrics_unittest.cc
[modify] https://crrev.com/ccc8344674b98aee5f25a2acf7e6a28f91b73cb0/components/autofill/core/browser/autofill_test_utils.cc
[modify] https://crrev.com/ccc8344674b98aee5f25a2acf7e6a28f91b73cb0/components/autofill/core/browser/credit_card_save_manager.cc
[modify] https://crrev.com/ccc8344674b98aee5f25a2acf7e6a28f91b73cb0/components/autofill/core/browser/credit_card_save_manager.h
[modify] https://crrev.com/ccc8344674b98aee5f25a2acf7e6a28f91b73cb0/components/autofill/core/browser/credit_card_save_manager_unittest.cc
[modify] https://crrev.com/ccc8344674b98aee5f25a2acf7e6a28f91b73cb0/components/autofill/core/browser/form_structure.cc
[modify] https://crrev.com/ccc8344674b98aee5f25a2acf7e6a28f91b73cb0/components/autofill/core/browser/form_structure.h
[modify] https://crrev.com/ccc8344674b98aee5f25a2acf7e6a28f91b73cb0/components/autofill/core/common/form_data.cc
[modify] https://crrev.com/ccc8344674b98aee5f25a2acf7e6a28f91b73cb0/components/autofill/core/common/form_data.h
[modify] https://crrev.com/ccc8344674b98aee5f25a2acf7e6a28f91b73cb0/components/autofill/core/common/form_data_unittest.cc

Comment 3 by se...@chromium.org, Nov 30 2017

Status: Fixed (was: Started)

Sign in to add a comment