New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 787116 link

Starred by 1 user
Status: Fixed
Owner:
█ allada@chromium.org
Last visit > 30 days ago
Closed: Dec 2017
Cc:
l...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Logging very large string is console locks up devtools

Project Member Reported by allada@chromium.org, Nov 20 2017 
If a large string is console.log'ed into devtools, devtools locks up for a while.

Tested on Strings > 250000 length of only a-z characters.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ace5892e7d164af7b4e2e31b89470163bfcfff35

commit ace5892e7d164af7b4e2e31b89470163bfcfff35
Author: Nathan Bruer <allada@chromium.org>
Date: Wed Nov 22 20:40:58 2017

[Devtools] Don't tokenize console message if over 10000 characters

If our console message is > 10000 characters we should no longer try and
group or extract links. This main thread to lockup for long periods of
time because if the messsage has many alpha numeric characters the regex
spends a lot of time trying to find matches of urls. Now we just bial if
> 10000.

R=luoe,pfeldman
BUG= 787116 

Change-Id: I89850a95547a6d08700752605a4840ad77891e37
Reviewed-on: https://chromium-review.googlesource.com/780150
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Blaise Bruer <allada@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518733}
[modify] https://crrev.com/ace5892e7d164af7b4e2e31b89470163bfcfff35/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js

Comment 2 by allada@chromium.org, Dec 1 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment