Issue metadata
Sign in to add a comment
|
AX_ROLE_DESKTOP should not be used by Views |
||||||||||||||||||||||
Issue descriptionThis change gave a View a role of AX_ROLE_DESKTOP in order to achieve certain behavior, but this will have unintended consequences. We need to figure out the right clean way to achieve the same thing. https://chromium-review.googlesource.com/c/chromium/src/+/653486
,
Feb 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2fe04bfc9ff43b8b84cd4b03ffbc3244c3b9cc4c commit 2fe04bfc9ff43b8b84cd4b03ffbc3244c3b9cc4c Author: David Tseng <dtseng@chromium.org> Date: Mon Feb 05 22:35:04 2018 Remove desktop role usage The desktop role gets used as the root of the entire automation tree and should not be used elsewhere. This change adds a comment in the enums file where views authors hopefully look for the list of roles. Note that in ChromeVox, using the desktop role amounts to a no-op, since ChromeVox only checks desktop role when it asks for a AutomationNode.prototype.root. TBR=tsepez@chromium.org Bug: 787101 Change-Id: I9f1b7a7a71f69f43ebc265cf0b61d0b0bdb4249f Reviewed-on: https://chromium-review.googlesource.com/896557 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#534514} [modify] https://crrev.com/2fe04bfc9ff43b8b84cd4b03ffbc3244c3b9cc4c/ui/accessibility/ax_enums.mojom [modify] https://crrev.com/2fe04bfc9ff43b8b84cd4b03ffbc3244c3b9cc4c/ui/app_list/views/app_list_view.cc
,
Feb 5 2018
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by vadimt@chromium.org
, Nov 27 2017