New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 787097 link

Starred by 6 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 23
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug


Sign in to add a comment

viz: Run finch trial on desktop Chrome with VizDisplayCompositor

Project Member Reported by kylec...@chromium.org, Nov 20 2017

Issue description

We want to have desktop Chrome with --enable-features=VizDisplayCompositor ready for a finch trial in M66. This flag moves the display compositor into the GPU process.

VizDisplayCompositor runs on Windows, Linux and Mac so all desktop platforms can potentially be included in a finch trial.
 
Blocking: -770833
Blockedon: 770833
Blocking: 730193
Blockedon: 787099
Blockedon: 772524
Blockedon: 672311 775030
Blockedon: 778749
Project Member

Comment 8 by bugdroid1@chromium.org, Jan 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eeadcce2d7a16cc8772b1e846a126d5d743668ef

commit eeadcce2d7a16cc8772b1e846a126d5d743668ef
Author: kylechar <kylechar@chromium.org>
Date: Wed Jan 17 19:16:52 2018

viz: Switch --enable-viz to base::Feature.

Add a base::Feature for out-of-process display compositor and remove the
existing --enable-viz flag. A base::Feature is needed for finch trials.
Run with --enable-features=VizDisplayCompositor for OOP-D.

Bug:  787097 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: Ie3dc4fbef7f0bc687dda24fd7ba5e4bb59061030
Reviewed-on: https://chromium-review.googlesource.com/865636
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529843}
[modify] https://crrev.com/eeadcce2d7a16cc8772b1e846a126d5d743668ef/components/viz/common/features.cc
[modify] https://crrev.com/eeadcce2d7a16cc8772b1e846a126d5d743668ef/components/viz/common/features.h
[modify] https://crrev.com/eeadcce2d7a16cc8772b1e846a126d5d743668ef/components/viz/common/switches.cc
[modify] https://crrev.com/eeadcce2d7a16cc8772b1e846a126d5d743668ef/components/viz/common/switches.h
[modify] https://crrev.com/eeadcce2d7a16cc8772b1e846a126d5d743668ef/content/browser/browser_main_loop.cc
[modify] https://crrev.com/eeadcce2d7a16cc8772b1e846a126d5d743668ef/content/browser/compositor/test/test_image_transport_factory.cc
[modify] https://crrev.com/eeadcce2d7a16cc8772b1e846a126d5d743668ef/content/browser/compositor/test/test_image_transport_factory.h
[modify] https://crrev.com/eeadcce2d7a16cc8772b1e846a126d5d743668ef/content/browser/gpu/gpu_process_host.cc
[modify] https://crrev.com/eeadcce2d7a16cc8772b1e846a126d5d743668ef/content/browser/renderer_host/browser_compositor_view_mac.mm
[modify] https://crrev.com/eeadcce2d7a16cc8772b1e846a126d5d743668ef/content/browser/renderer_host/delegated_frame_host.cc
[modify] https://crrev.com/eeadcce2d7a16cc8772b1e846a126d5d743668ef/content/browser/renderer_host/offscreen_canvas_surface_impl.cc
[modify] https://crrev.com/eeadcce2d7a16cc8772b1e846a126d5d743668ef/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/eeadcce2d7a16cc8772b1e846a126d5d743668ef/content/browser/renderer_host/render_widget_host_impl.cc
[modify] https://crrev.com/eeadcce2d7a16cc8772b1e846a126d5d743668ef/content/browser/renderer_host/render_widget_host_input_event_router.cc
[modify] https://crrev.com/eeadcce2d7a16cc8772b1e846a126d5d743668ef/content/browser/renderer_host/render_widget_host_view_aura.cc
[modify] https://crrev.com/eeadcce2d7a16cc8772b1e846a126d5d743668ef/content/browser/renderer_host/render_widget_host_view_child_frame.cc
[modify] https://crrev.com/eeadcce2d7a16cc8772b1e846a126d5d743668ef/content/gpu/gpu_child_thread.cc
[modify] https://crrev.com/eeadcce2d7a16cc8772b1e846a126d5d743668ef/testing/buildbot/chromium.chromiumos.json
[modify] https://crrev.com/eeadcce2d7a16cc8772b1e846a126d5d743668ef/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/eeadcce2d7a16cc8772b1e846a126d5d743668ef/testing/buildbot/chromium.linux.json
[modify] https://crrev.com/eeadcce2d7a16cc8772b1e846a126d5d743668ef/testing/buildbot/chromium.sandbox.json
[modify] https://crrev.com/eeadcce2d7a16cc8772b1e846a126d5d743668ef/testing/buildbot/chromium.win.json
[modify] https://crrev.com/eeadcce2d7a16cc8772b1e846a126d5d743668ef/testing/buildbot/test_suites.pyl

Blockedon: 803548
Blockedon: 695579
Blockedon: 809171
Blockedon: 754872
Blockedon: -672311
Blockedon: 772576
Description: Show this description
Summary: viz: Run finch trial on desktop Chrome with VizDisplayCompositor (was: viz: Run finch trial on desktop Chrome with --enable-viz)
Blockedon: 810037
Blockedon: 781247
Blockedon: 777881

Comment 21 by m...@chromium.org, Feb 14 2018

Two weeks until M-66 branch. It seems that we should probably push back to a later milestone?

For my own work, I'm still working out issues for:

 bug 810389  - CrOS LoginFeedbackTest broken when VIZ is enabled.

 bug 806366  (blocked on  bug 809867 ) - Browser Window Capture (Aura/CrOS) + Desktop Capture (Cros)

 bug 812059  - CopyOutputRequest "screenshots" for Surfaces in VIZ (well, ATM, this is only busted if --site-per-process is turned on)

Blockedon: 812385
Labels: -M-66 M-67
I agree M66 milestone probably isn't realistic to start a finch trial. We have an essentially working browser on Linux and Windows at this point but there are enough small tasks that need to be wrapped up that early M67 is more likely.
Blockedon: 814475
Blockedon: 814877
Blockedon: 730660
Blockedon: -772524
Blockedon: 811979
Project Member

Comment 29 by bugdroid1@chromium.org, Mar 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3b95aabfa06b558e253adbc2681186ec37753729

commit 3b95aabfa06b558e253adbc2681186ec37753729
Author: kylechar <kylechar@chromium.org>
Date: Wed Mar 07 18:42:13 2018

Add VizDisplayCompositor to chrome://gpu.

Bug:  787097 
Change-Id: I1db9b3edcd0fd7a5686b3a7c2f0993c551b3e9f6
Reviewed-on: https://chromium-review.googlesource.com/953070
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541514}
[modify] https://crrev.com/3b95aabfa06b558e253adbc2681186ec37753729/content/browser/gpu/compositor_util.cc
[modify] https://crrev.com/3b95aabfa06b558e253adbc2681186ec37753729/content/browser/resources/gpu/info_view.js

Blockedon: -772576
Blockedon: 825861
Blockedon: -775030
Blockedon: 844406
Labels: -M-67 M-68
I've flipped on a finch trial to run OOP-D at 50% on Windows canary. It's running for 24ish hours.
Blockedon: 845593
Blockedon: 846333
Blockedon: 811945
Blockedon: 791660
Blockedon: 850194
Blockedon: 850198
Blockedon: 851616
Blockedon: 855643
Blockedon: 859068
Blockedon: 860342
Blockedon: 860763
Blockedon: -781247
Blockedon: 874130
Blockedon: -845593
Project Member

Comment 49 by bugdroid1@chromium.org, Aug 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/209e15b44e0c2c2d127b5c9a4416b996d663cc5e

commit 209e15b44e0c2c2d127b5c9a4416b996d663cc5e
Author: Fady Samuel <fsamuel@chromium.org>
Date: Thu Aug 16 05:25:53 2018

Enable Viz Display Compositor on perf bots

Bug:  787097 
Change-Id: I4a16270307d5b01f339707cb78151a8c4d08abef
Reviewed-on: https://chromium-review.googlesource.com/1161554
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583548}
[modify] https://crrev.com/209e15b44e0c2c2d127b5c9a4416b996d663cc5e/testing/variations/fieldtrial_testing_config.json

Cc: jonr...@chromium.org
Project Member

Comment 51 by bugdroid1@chromium.org, Aug 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/146ee24f7489d9baaa03ddb8a031735ef0fd698f

commit 146ee24f7489d9baaa03ddb8a031735ef0fd698f
Author: jonross <jonross@chromium.org>
Date: Fri Aug 24 18:25:29 2018

Remove Viz tests from Linux and Windows

We are currently field testing Viz, so tests on the CQ have it enabled by
default. This change removes the explicit viz_browser_tests and
viz_content_unittests from Linux and Windows configs, which are running the
trial.

TEST=viz_browser_tests, viz_content_unittests

Bug:  787097 
Change-Id: I8a26abd1c0de1357560f6fc9e53b4d3b1157c68e
Reviewed-on: https://chromium-review.googlesource.com/1187559
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585910}
[modify] https://crrev.com/146ee24f7489d9baaa03ddb8a031735ef0fd698f/testing/buildbot/chromium.clang.json
[modify] https://crrev.com/146ee24f7489d9baaa03ddb8a031735ef0fd698f/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/146ee24f7489d9baaa03ddb8a031735ef0fd698f/testing/buildbot/chromium.linux.json
[modify] https://crrev.com/146ee24f7489d9baaa03ddb8a031735ef0fd698f/testing/buildbot/chromium.memory.json
[modify] https://crrev.com/146ee24f7489d9baaa03ddb8a031735ef0fd698f/testing/buildbot/chromium.win.json
[modify] https://crrev.com/146ee24f7489d9baaa03ddb8a031735ef0fd698f/testing/buildbot/test_suites.pyl

Project Member

Comment 52 by bugdroid1@chromium.org, Aug 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d75cb2479e177b59f7d74c0956455051a832f315

commit d75cb2479e177b59f7d74c0956455051a832f315
Author: jonross <jonross@chromium.org>
Date: Fri Aug 31 16:12:15 2018

Remove many Viz testing configs

VizDisplayCompositor was already in field trials on Linux and Windows. It has
now entered trials on Android and Mac.

This change removes viz_content_browsertests from both Android and Mac. It also
removes viz_browser_tests and viz_content_unittests from Mac (these don't run on
Android anyways.)

This leaves viz_* specific test variants on ChromeOS, as well as a series of FYI
bots we maintain.

While I was cleaning this up I also removed linux_viz_isolated_scripts, as the
telemetry suites are covered by the field trials. I also removed main of the
exceptions we had, as the viz_* variant no longer runs on those bots.

TEST= viz_browser_tests, viz_content_browsertests, viz_content_unittests,
telemetry_perf_unittests_viz, telemetry_unittests_viz

Bug:  787097 
Change-Id: I2257f1eaeb06139588e1dcf6b9448c2749e2a59f
Reviewed-on: https://chromium-review.googlesource.com/1199682
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588045}
[modify] https://crrev.com/d75cb2479e177b59f7d74c0956455051a832f315/testing/buildbot/chromium.android.fyi.json
[modify] https://crrev.com/d75cb2479e177b59f7d74c0956455051a832f315/testing/buildbot/chromium.android.json
[modify] https://crrev.com/d75cb2479e177b59f7d74c0956455051a832f315/testing/buildbot/chromium.clang.json
[modify] https://crrev.com/d75cb2479e177b59f7d74c0956455051a832f315/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/d75cb2479e177b59f7d74c0956455051a832f315/testing/buildbot/chromium.gpu.fyi.json
[modify] https://crrev.com/d75cb2479e177b59f7d74c0956455051a832f315/testing/buildbot/chromium.gpu.json
[modify] https://crrev.com/d75cb2479e177b59f7d74c0956455051a832f315/testing/buildbot/chromium.linux.json
[modify] https://crrev.com/d75cb2479e177b59f7d74c0956455051a832f315/testing/buildbot/chromium.mac.json
[modify] https://crrev.com/d75cb2479e177b59f7d74c0956455051a832f315/testing/buildbot/chromium.memory.json
[modify] https://crrev.com/d75cb2479e177b59f7d74c0956455051a832f315/testing/buildbot/chromium.win.json
[modify] https://crrev.com/d75cb2479e177b59f7d74c0956455051a832f315/testing/buildbot/test_suite_exceptions.pyl
[modify] https://crrev.com/d75cb2479e177b59f7d74c0956455051a832f315/testing/buildbot/test_suites.pyl
[modify] https://crrev.com/d75cb2479e177b59f7d74c0956455051a832f315/testing/buildbot/waterfalls.pyl

Blockedon: -778749
Status: Fixed (was: Assigned)

Sign in to add a comment