New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 787096 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Remove buildbot codepaths when migration to luci is complete.

Project Member Reported by robert...@chromium.org, Nov 20 2017

Issue description

Requests to the unified logical findit builder `findit_variable` in buildbucket currently require that the 'mastername' property be set to the buildbot master it would have, were it not a swarmbucket-based builder.

This is okay for the short term, as it avoids having multiple code-paths for supporting buildbot and swarming-based trybots. After the migration is done, however, we'll need a different way of letting the recipe know how to configure the builder, as the current method will be opaque and misleading.
 

Comment 1 by st...@chromium.org, Nov 20 2017

FYI: Findit recipes use the target_mastername and target_buildername/target_testername to configure the checkout and build.
Summary: Remove buildbot codepaths when migration to luci is complete. (was: Remove misleading 'mastername' property from tryjobs requests.)
Also, make sure to assert that dimensions are set (not None or empty) before triggering a tryjob.

Sign in to add a comment