New issue
Advanced search Search tips

Issue 787068 link

Starred by 1 user
Status: WontFix
Owner: ----
Closed: Sep 13
Cc:
chrisha@chromium.org
fdoray@chromium.org
pkasting@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Use buildflag for resource_coordinator

Project Member Reported by michae...@chromium.org, Nov 20 2017 
In crrev.com/c/778486, we're adding tab usage UKMs on Windows/Mac/Linux/CrOS. These are the same platforms resource_coordinator builds on, which will eventually use chrome/browser/tabs for tab discarding.

Newer features should use buildflags instead of platform testing. The CL above uses ENABLE_RESOURCE_COORDINATOR, i.e.:

  #if BUILDFLAG(ENABLE_RESOURCE_COORDINATOR)

We should apply that buildflag to the actual chrome/browser/resource_coordinator directory as well.

Comment 1 by robliao@chromium.org, Sep 13

Status: Archived (was: Available)
Archiving old bugs that haven't been actively assigned in over 180 days.

If you feel this issue should still be addressed, feel free to reopen it or to file a new issue. Thanks!

Comment 2 by robliao@chromium.org, Sep 13 

Archiving old bugs that haven't been actively assigned in over 180 days.

If you feel this issue should still be addressed, feel free to reopen it or to file a new issue. Thanks!

Comment 3 by robliao@chromium.org, Sep 13 

Archiving old bugs that haven't been actively assigned in over 180 days.

If you feel this issue should still be addressed, feel free to reopen it or to file a new issue. Thanks!

Comment 4 by pkasting@chromium.org, Sep 13 

FWIW, I don't see ENABLE_RESOURCE_COORDINATOR in the CL in comment 0 or in the source tree anywhere today, so I'm not sure how one would take action on this bug.

Comment 5 by chrisha@chromium.org, Sep 14

Status: WontFix (was: Archived)
Yeah, I think this is completely stale and unactionable at this point. Closing as WontFix.
►

Sign in to add a comment