New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 787061 link

Starred by 1 user
Status: Assigned
Owner:
mrefaat@chromium.org
Cc:
mrefaat@chromium.org
█ ajwong@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Remove unnecessary AssertNoURLRequests calls in chrome_browser_state_io.mm

Project Member Reported by mrefaat@chromium.org, Nov 20 2017 
TODO in ios/chrome/browser/browser_state/chrome_browser_state_io_data.mm:
  // TODO(ajwong): These AssertNoURLRequests() calls are unnecessary since they
  // are already done in the URLRequestContext destructor.

I can address it but i'm not sure why it wasn't remove from the beginning (at the time of putting the TODO) so i'm afraid that i'm missing something.

Comment 1 by ajwong@chromium.org, Nov 20 2017

Cc: ajwong@chromium.org
Owner: mrefaat@chromium.org
Wow...That is a really really old comment. I'm not at all certain if it's valid anymore.

IIRc, at the time, I didn't remove it because the CL I was doing was nearly 100 files or something and I didn't want to add any change that wasn't a pure lifetime refactor.... but I really don't remember...

Assigning back...

Let me know if you want me try to dig deeper.

Comment 2 by sergeybe...@chromium.org, Dec 12 2017

Components: -Infra>Client>iOS Tests
Labels: OS-iOS
Status: Assigned (was: Untriaged)
►

Sign in to add a comment