New issue
Advanced search Search tips

Issue 787046 link

Starred by 1 user
Status: Assigned
Owner:
qin...@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

DownloadContentTest.DownloadAttributeSameSiteCookie fails on mojo_linux

Project Member Reported by qin...@chromium.org, Nov 20 2017 
The test is failing because the page will be redirected to another origin, and then the server will the redirect the request to the same origin of the original request.

In order to fix, the server redirection should set the first_party_url_for_cookies to the original origin.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/86c8199e89e3991732f8375fad1f1b667cc7edf4

commit 86c8199e89e3991732f8375fad1f1b667cc7edf4
Author: Min Qin <qinmin@chromium.org>
Date: Tue Nov 21 20:30:54 2017

Network service: update first-party URL for main frame request

This logic is present in ResourceDispatcherHostImpl::ContinuePendingBeginRequest().
However, it is missing in URLLoader when constructing the URLRequest.
The bug causes the wrong cookie to be presented if server redirection happens.
DownloadContentTest.DownloadAttributeSameSiteCookie should provide test coverage for this CL.

BUG=787046

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I708ecba1c386d101ae21e968351732a15fb6f31f
Reviewed-on: https://chromium-review.googlesource.com/779065
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518367}
[modify] https://crrev.com/86c8199e89e3991732f8375fad1f1b667cc7edf4/content/network/url_loader.cc
[modify] https://crrev.com/86c8199e89e3991732f8375fad1f1b667cc7edf4/content/public/common/resource_request.h
[modify] https://crrev.com/86c8199e89e3991732f8375fad1f1b667cc7edf4/testing/buildbot/filters/mojo.fyi.network_content_browsertests.filter

Comment 2 by benhenry@chromium.org, Aug 1

Status: Assigned (was: Untriaged)
►

Sign in to add a comment