chromeos-base/audiotest has unused private fields in source code. |
||||
Issue descriptionThe next version of clang, which we are hoping to upgrade to in a few weeks, generates -wunused-private-field warnings. audiotest has one of these unused private fields, so it is causing builds with the new compiler to fail. The source code should be fixed, and the unused field(s) should be removed. See https://logs.chromium.org/v/?s=chromeos%2Fbb%2Fchromiumos.tryserver%2Frelease%2F17445%2F%2B%2Frecipes%2Fsteps%2FBuildPackages__afdo_use_%2F0%2Fstdout for an example build failure.
,
Nov 20 2017
,
Nov 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/8779969f80d1931a6a25252c9f0dc883ef1659e0 commit 8779969f80d1931a6a25252c9f0dc883ef1659e0 Author: Caroline Tice <cmtice@google.com> Date: Thu Nov 30 09:13:14 2017 [gcc] disable -Wunused-private-field until packages get fixed. Temporarily disable new clang warnings (for llvm-next) until the CLs to fix the source code can be committed. This is to prevent the toolchain waterfall builders, which use llvm-next, from failing. BUG= chromium:787037 TEST=Successfully emerged the two problem packages, with llvm-next and this CL. Also emerged with 'normal' llvm and this CL. Change-Id: I9567c90ce84701889aea25ad5bb5b543d418a12f Reviewed-on: https://chromium-review.googlesource.com/797683 Commit-Ready: Caroline Tice <cmtice@chromium.org> Tested-by: Caroline Tice <cmtice@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/8779969f80d1931a6a25252c9f0dc883ef1659e0/sys-devel/gcc/files/sysroot_wrapper.hardened.body [rename] https://crrev.com/8779969f80d1931a6a25252c9f0dc883ef1659e0/sys-devel/gcc/gcc-4.9.2-r172.ebuild
,
Dec 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/audiotest/+/1de2ceb557fc970ddabca85959af919ced1befaa commit 1de2ceb557fc970ddabca85959af919ced1befaa Author: Caroline Tice <cmtice@google.com> Date: Fri Dec 01 04:30:13 2017 Fix '-wunused-private-field' warnings generated by new version of clang. BUG= chromium:787037 TEST=Successfully built in trybots for caroline, terrra, and whirlwind. https://uberchromegw.corp.google.com/i/chromiumos.tryserver/builders/llvm_next_toolchain/builds/916 https://uberchromegw.corp.google.com/i/chromiumos.tryserver/builders/llvm_next_toolchain/builds/917 https://uberchromegw.corp.google.com/i/chromiumos.tryserver/builders/llvm_next_toolchain/builds/918 Change-Id: Id2044a4fbbfdfced0f24acff0d366722e9b2ba1b Reviewed-on: https://chromium-review.googlesource.com/779063 Commit-Ready: Caroline Tice <cmtice@chromium.org> Tested-by: Caroline Tice <cmtice@chromium.org> Reviewed-by: Wu-Cheng Li <wuchengli@chromium.org> [modify] https://crrev.com/1de2ceb557fc970ddabca85959af919ced1befaa/src/tone_generators.cc [modify] https://crrev.com/1de2ceb557fc970ddabca85959af919ced1befaa/include/tone_generators.h
,
Dec 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/gestures/+/20c9cb56793f9561a0d599acffa0345ab63853fd commit 20c9cb56793f9561a0d599acffa0345ab63853fd Author: Caroline Tice <cmtice@google.com> Date: Sat Dec 02 04:32:33 2017 Fix '-wunused-private-field' warnings generated by new version of clang. BUG= chromium:787037 TEST=Successfully built in trybots for caroline, terra and whirlwind. https://uberchromegw.corp.google.com/i/chromiumos.tryserver/builders/llvm_next_toolchain/builds/916 https://uberchromegw.corp.google.com/i/chromiumos.tryserver/builders/llvm_next_toolchain/builds/917 https://uberchromegw.corp.google.com/i/chromiumos.tryserver/builders/llvm_next_toolchain/builds/918 Also, successfully emerged on falco. Change-Id: I7adf778c478e7430c3b12b26ed2c8d1d39898d0b Reviewed-on: https://chromium-review.googlesource.com/779064 Commit-Ready: Caroline Tice <cmtice@chromium.org> Tested-by: Caroline Tice <cmtice@chromium.org> Reviewed-by: Sean O'Brien <seobrien@chromium.org> [modify] https://crrev.com/20c9cb56793f9561a0d599acffa0345ab63853fd/include/finger_metrics.h [modify] https://crrev.com/20c9cb56793f9561a0d599acffa0345ab63853fd/src/finger_metrics.cc
,
Dec 5 2017
,
Dec 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/4d086608eb0109ae97f6bc76c0ba722ad74a5cab commit 4d086608eb0109ae97f6bc76c0ba722ad74a5cab Author: Caroline Tice <cmtice@google.com> Date: Wed Dec 06 02:00:46 2017 Revert "[gcc] disable -Wunused-private-field until packages get fixed." This reverts commit 8779969f80d1931a6a25252c9f0dc883ef1659e0. Reason for revert: The CLs for fixing the source code in the problem packages have been committed. Original change's description: > [gcc] disable -Wunused-private-field until packages get fixed. > > Temporarily disable new clang warnings (for llvm-next) until the > CLs to fix the source code can be committed. This is to prevent > the toolchain waterfall builders, which use llvm-next, from > failing. > > BUG= chromium:787037 > TEST=Successfully emerged the two problem packages, with llvm-next > and this CL. Also emerged with 'normal' llvm and this CL. > > Change-Id: I9567c90ce84701889aea25ad5bb5b543d418a12f > Reviewed-on: https://chromium-review.googlesource.com/797683 > Commit-Ready: Caroline Tice <cmtice@chromium.org> > Tested-by: Caroline Tice <cmtice@chromium.org> > Reviewed-by: Mike Frysinger <vapier@chromium.org> BUG= chromium:787037 TEST=None Change-Id: I5e786ad144fcadcfe6d264b2c14426c3f5efbc87 Reviewed-on: https://chromium-review.googlesource.com/809544 Commit-Ready: Caroline Tice <cmtice@chromium.org> Tested-by: Caroline Tice <cmtice@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/4d086608eb0109ae97f6bc76c0ba722ad74a5cab/sys-devel/gcc/files/sysroot_wrapper.hardened.body [rename] https://crrev.com/4d086608eb0109ae97f6bc76c0ba722ad74a5cab/sys-devel/gcc/gcc-4.9.2-r173.ebuild
,
May 15 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by cmt...@chromium.org
, Nov 20 2017