Remove slow code path from ImageBitmap->ScaleImage() |
||||
Issue descriptionImageBitmap->ScaleImage() uses a slow code path when: - source image is unpremul, and - premul code path is not allowed, and - the filter quality is high. In this case, we cannot use SkImage::scalePixels(), since Skia clamps color channels to alpha. When the clamping issue in high quality scaling algorithm resolved, remove the slow code path.
,
Nov 20 2017
,
Dec 7 2017
,
Dec 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a52f6b77d5a4ac517e850d08005262d7d74c9d7b commit a52f6b77d5a4ac517e850d08005262d7d74c9d7b Author: Reza.Zakerinasab <zakerinasab@chromium.org> Date: Fri Dec 22 18:07:00 2017 Unify ImageBitmap resize code path for premul and unpremul After Skia rolls this recent CL to fix the alpha clamping issue in high filter quality (https://skia-review.googlesource.com/c/skia/+/87000), we can refactor ImageBitmap code path to unify high quality premul and unpremul. Bug: 787034 , 796797 Change-Id: I2efc0c86b15b2f182e4af99afc538918d11f2f0d Reviewed-on: https://chromium-review.googlesource.com/840829 Reviewed-by: Olivia Lai <xlai@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Cr-Commit-Position: refs/heads/master@{#526021} [modify] https://crrev.com/a52f6b77d5a4ac517e850d08005262d7d74c9d7b/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/a52f6b77d5a4ac517e850d08005262d7d74c9d7b/third_party/WebKit/LayoutTests/fast/webgl/resources/tex-image-and-sub-image-image-bitmap-utils-resize.js [modify] https://crrev.com/a52f6b77d5a4ac517e850d08005262d7d74c9d7b/third_party/WebKit/Source/core/imagebitmap/ImageBitmap.cpp
,
Dec 22 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by zakerinasab@chromium.org
, Nov 20 2017