New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 787026 link

Starred by 1 user
Status: Fixed
Owner:
█ thanhdle@chromium.org
Last visit > 30 days ago
Closed: Nov 2017
Cc:
tbansal@chromium.org
bengr@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Chrome crashes on chrome://interventions-internals when ECT changes.

Project Member Reported by thanhdle@chromium.org, Nov 20 2017 
What steps will reproduce the problem?
(1) Go to chrome://interventions-internals
(2) Disable internet.
(3) Open a new chrome://interventions-internals tab.
(4) Close the old tab, and enable internet.

Expected, ECT updated, no crash

This is because it InterventionsInternalsPageHandler does not removed itself from the ECT observers list.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9dc49fe83c44c419f9a5b307fc6f932841c7835a

commit 9dc49fe83c44c419f9a5b307fc6f932841c7835a
Author: Thanh Le <thanhdle@chromium.org>
Date: Tue Nov 21 01:30:28 2017

Fix crashes chrome://interventions-internals on ECT change.

InterventionsInternalPageHandler remove itself from the ECT observer
list instead of InterventionsIntenralsUI removing the page  handler from
the observer list.

Bug:  787026 
Change-Id: I4c0766fa0573e3a28072cf70788160e8310312f2
Reviewed-on: https://chromium-review.googlesource.com/779961
Commit-Queue: Thanh Le <thanhdle@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518030}
[modify] https://crrev.com/9dc49fe83c44c419f9a5b307fc6f932841c7835a/chrome/browser/ui/webui/interventions_internals/interventions_internals_page_handler.cc
[modify] https://crrev.com/9dc49fe83c44c419f9a5b307fc6f932841c7835a/chrome/browser/ui/webui/interventions_internals/interventions_internals_page_handler.h
[modify] https://crrev.com/9dc49fe83c44c419f9a5b307fc6f932841c7835a/chrome/browser/ui/webui/interventions_internals/interventions_internals_page_handler_unittest.cc
[modify] https://crrev.com/9dc49fe83c44c419f9a5b307fc6f932841c7835a/chrome/browser/ui/webui/interventions_internals/interventions_internals_ui.cc

Comment 2 by thanhdle@chromium.org, Nov 21 2017

Status: Fixed (was: Started)

Comment 3 by efoo@chromium.org, Dec 5 2017

Components: Blink>Previews

Comment 4 by efoo@chromium.org, Dec 5 2017

Components: -UI>Browser>Previews
►

Sign in to add a comment