TrayAccessibilityTest.CheckMenuVisibilityOnDetailMenu/1 is flaky |
|||||
Issue descriptionTrayAccessibilityTestInstance/TrayAccessibilityTest.CheckMenuVisibilityOnDetailMenu/1 is flaky: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=browser_tests%20(with%20patch)&tests=TrayAccessibilityTestInstance%2FTrayAccessibilityTest.CheckMenuVisibilityOnDetailMenu%2F1 The most recent failure: https://build.chromium.org/p/tryserver.chromium.chromiumos/builders/linux-chromeos-rel/builds/6874 The failure is: ../../chrome/browser/chromeos/system/tray_accessibility_browsertest.cc:1666: Failure Value of: IsHelpAvailableOnDetailMenu() Actual: false Expected: true There's no clear regression range for this failure but the following patch recently changed this test and might have caused it: https://chromium.googlesource.com/chromium/src/+/928f23c3c314be28cec7f3d9a5658218ffefd334 It looks like jamescook is OOO this week. xiyuan, could you take a look?
,
Nov 30 2017
Still flaky, e.g. https://build.chromium.org/p/tryserver.chromium.chromiumos/builders/linux-chromeos-rel/builds/13838. Going to disable the test for now.
,
Nov 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a8d2219422410e359bc599780e0aa03f6e0ab1a4 commit a8d2219422410e359bc599780e0aa03f6e0ab1a4 Author: Timothy Loh <timloh@chromium.org> Date: Thu Nov 30 06:02:26 2017 Disable flaky test CheckMenuVisibilityOnDetailMenu The test TrayAccessibilityTest.CheckMenuVisibilityOnDetailMenu is flaky, so this CL disables it for now. Bug: 787024 Change-Id: I4e14fedd42e11cc9068cb60d321df3dc8723692d TBR: xiyuan@chromium.org Reviewed-on: https://chromium-review.googlesource.com/799572 Reviewed-by: Timothy Loh <timloh@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#520455} [modify] https://crrev.com/a8d2219422410e359bc599780e0aa03f6e0ab1a4/chrome/browser/chromeos/system/tray_accessibility_browsertest.cc
,
Nov 30 2017
This is probably my fault.
,
Jan 26 2018
,
Jan 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b601dd5c663a5b8eccc9d78f56f01f9eb49ded04 commit b601dd5c663a5b8eccc9d78f56f01f9eb49ded04 Author: James Cook <jamescook@chromium.org> Date: Mon Jan 29 21:07:19 2018 cros: Enable TrayAccessibilityTest.CheckMenuVisibilityOnDetailMenu The underlying accessibility code has been refactored recently and I cannot reproduce flake locally. Also, the flakiness dashboard shows that the other tests in the suite are not flaky anymore. I suspect the issue is fixed. Also add a RunLoop spin in one place that changes a pref that ash may need to observe. I don't think that affects this test, but I noticed it while investigating. Bug: 787024 Test: browser_tests Change-Id: I65175c4e87c09c2cc172174c9b0595e4372ad652 Reviewed-on: https://chromium-review.googlesource.com/889645 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#532588} [modify] https://crrev.com/b601dd5c663a5b8eccc9d78f56f01f9eb49ded04/chrome/browser/chromeos/system/tray_accessibility_browsertest.cc
,
Jan 30 2018
This test has run 60+ times in the last 20 hours on a variety of bots and I don't see any flake. Calling this fixed. https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=TrayAccessibilityTest
,
Feb 26 2018
,
Mar 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/18fe8f8aa1d79367b57e0639ad930345460ad7fc commit 18fe8f8aa1d79367b57e0639ad930345460ad7fc Author: James Cook <jamescook@chromium.org> Date: Fri Mar 09 01:27:26 2018 cros: Disable flaky TrayAccessibilityTest.CheckMenuVisibilityOnDetailMenu Flakily fails with: ../../chrome/browser/chromeos/system/tray_accessibility_browsertest.cc:1681: Failure Value of: IsHelpAvailableOnDetailMenu() Actual: false Expected: true NOTRY=true TBR=xiyuan@chromium.org Bug: 819987 , 787024 Change-Id: I133007c1411f714f2b7646c0c0d949c577c63037 Reviewed-on: https://chromium-review.googlesource.com/956276 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#541980} [modify] https://crrev.com/18fe8f8aa1d79367b57e0639ad930345460ad7fc/chrome/browser/chromeos/system/tray_accessibility_browsertest.cc |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by xiy...@chromium.org
, Nov 20 2017