This is used in multiple tests (4 files) to create the same matcher. Code would look more readable if this was fixed.
Consider doing the same for kToolsMenuOtherDevicesId
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b21880d1020cc244c6a42d64de06c0fb08de7f62 commit b21880d1020cc244c6a42d64de06c0fb08de7f62 Author: Mike Baxley <baxley@chromium.org> Date: Tue Nov 21 20:12:01 2017 Create matchers for Bookmarks and Recent Tabs menu items. These Tools menu items are used in several tests. Remove the dependency of tests on tools_menu_constants.h. Bug: 787015 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ie5d6b180f86d2628737c96feed96245c095d374a Reviewed-on: https://chromium-review.googlesource.com/780051 Commit-Queue: Mike Baxley <baxley@chromium.org> Reviewed-by: Menglu Huang <huangml@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#518356} [modify] https://crrev.com/b21880d1020cc244c6a42d64de06c0fb08de7f62/ios/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/b21880d1020cc244c6a42d64de06c0fb08de7f62/ios/chrome/browser/ui/bookmarks/BUILD.gn [modify] https://crrev.com/b21880d1020cc244c6a42d64de06c0fb08de7f62/ios/chrome/browser/ui/bookmarks/bookmarks_egtest.mm [modify] https://crrev.com/b21880d1020cc244c6a42d64de06c0fb08de7f62/ios/chrome/browser/ui/bookmarks/bookmarks_new_generation_egtest.mm [modify] https://crrev.com/b21880d1020cc244c6a42d64de06c0fb08de7f62/ios/chrome/browser/ui/keyboard_commands_egtest.mm [modify] https://crrev.com/b21880d1020cc244c6a42d64de06c0fb08de7f62/ios/chrome/browser/ui/ntp/recent_tabs/BUILD.gn [modify] https://crrev.com/b21880d1020cc244c6a42d64de06c0fb08de7f62/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_table_egtest.mm [modify] https://crrev.com/b21880d1020cc244c6a42d64de06c0fb08de7f62/ios/chrome/browser/ui/signin_interaction/BUILD.gn [modify] https://crrev.com/b21880d1020cc244c6a42d64de06c0fb08de7f62/ios/chrome/browser/ui/signin_interaction/signin_interaction_controller_egtest.mm [modify] https://crrev.com/b21880d1020cc244c6a42d64de06c0fb08de7f62/ios/chrome/test/earl_grey/chrome_matchers.h [modify] https://crrev.com/b21880d1020cc244c6a42d64de06c0fb08de7f62/ios/chrome/test/earl_grey/chrome_matchers.mm
Comment 1 by baxley@chromium.org
, Nov 20 2017