Refactor constants in InterventionsInternalsPageHandler |
|||
Issue descriptionThere are a lot of constants in InterventionsInternalsPageHandler. https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/interventions_internals/interventions_internals_page_handler.cc?type=cs&sq=package:chromium&l=14 One way to organize them to have a struct which holds variables related to one preview or flag. Then, have a vector of these structs. That would make it easier to add new previews in future.
,
Dec 5 2017
,
Jan 23 2018
Refreshed during triage.
,
Jan 24 2018
The component of flags are not all hard-coded constants. For example, flags descriptions are retrieved from about://flags. https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/interventions_internals/interventions_internals_page_handler.cc?type=cs&sq=package:chromium&l=241 Additionally, some flag feature names are also not hard-coded constants. https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/interventions_internals/interventions_internals_page_handler.cc?type=cs&sq=package:chromium&l=37 Unless more features/flags are added, or additional details/information about the flags are added, this is refactor is not necessary. |
|||
►
Sign in to add a comment |
|||
Comment 1 by efoo@chromium.org
, Dec 5 2017