Generate Android build properties in unibuilds |
||||
Issue description
,
Nov 20 2017
,
Nov 20 2017
,
Dec 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/fe73ce8e08b8c5b3de0062ec5108734325b9b942 commit fe73ce8e08b8c5b3de0062ec5108734325b9b942 Author: Benjamin Gordon <bmgordon@chromium.org> Date: Thu Dec 21 02:32:05 2017 libcros_config: Install header files The installed libcros_config.pc sets the include directory in --cflags, but the header files aren't actually installed there. This prevents packages outside platform2 from seeing the headers. BUG= chromium:787004 TEST=Built arc-setup against libcros_config headers Change-Id: Icdf2ea9a3c392062f983d1721bf02f35a491c861 [modify] https://crrev.com/fe73ce8e08b8c5b3de0062ec5108734325b9b942/chromeos-base/chromeos-config-tools/chromeos-config-tools-9999.ebuild
,
Jan 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/86c6199fe1a5b55760824a047f77826259ecdf99 commit 86c6199fe1a5b55760824a047f77826259ecdf99 Author: Benjamin Gordon <bmgordon@chromium.org> Date: Thu Jan 04 03:53:12 2018 chromeos-config: Handle invalid SKUs When an invalid SKU is read from the SMBIOS table, libcros_config aborts instead of loading the model config. On systems where SKU isn't used (e.g. kahlee), this prevents libcros_config from reading the model config at all. Fix this by replacing invalid SKUs with -1 to restore the behavior that happened when using mosys. BUG= chromium:787004 TEST=Ran cros_config on kahlee Change-Id: I3bf38bfa0968f30ace71560f8c5121fbb821dc60 Reviewed-on: https://chromium-review.googlesource.com/849262 Commit-Ready: Benjamin Gordon <bmgordon@chromium.org> Tested-by: Benjamin Gordon <bmgordon@chromium.org> Reviewed-by: Simon Glass <sjg@chromium.org> [modify] https://crrev.com/86c6199fe1a5b55760824a047f77826259ecdf99/chromeos-config/libcros_config/identity.cc
,
Jan 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/e75e1ffa9abb9e5084a353a18ce165904249176d commit e75e1ffa9abb9e5084a353a18ce165904249176d Author: Benjamin Gordon <bmgordon@chromium.org> Date: Sat Jan 13 06:37:48 2018 chromeos-config: Add support for Android properties Add a new 'build-properties' node under 'arc' which provides Android build properties. Also add support for automatically following the arc-properties-type property from the model to the family. BUG= chromium:787004 TEST=FEATURES=test sudo -E emerge --nodeps chromeos-config-host Change-Id: I5749570c1bb6260ef6a904e7079afe4cbbce6d59 Reviewed-on: https://chromium-review.googlesource.com/862442 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Benjamin Gordon <bmgordon@chromium.org> Reviewed-by: Simon Glass <sjg@chromium.org> Reviewed-by: C Shapiro <shapiroc@google.com> [modify] https://crrev.com/e75e1ffa9abb9e5084a353a18ce165904249176d/chromeos-config/README.md [modify] https://crrev.com/e75e1ffa9abb9e5084a353a18ce165904249176d/chromeos-config/cros_config_host/validate_config_unittest.py [modify] https://crrev.com/e75e1ffa9abb9e5084a353a18ce165904249176d/chromeos-config/cros_config_host/validate_config.py [modify] https://crrev.com/e75e1ffa9abb9e5084a353a18ce165904249176d/chromeos-config/cros_config_host/libcros_config_host.py [modify] https://crrev.com/e75e1ffa9abb9e5084a353a18ce165904249176d/chromeos-config/libcros_config/cros_config.cc
,
Jan 18 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/overlays/overlay-grunt-private/+/f7437b00d8c222e91aa74d3a9bc9e0ab0d88a79a commit f7437b00d8c222e91aa74d3a9bc9e0ab0d88a79a Author: Benjamin Gordon <bmgordon@chromium.org> Date: Thu Jan 18 07:37:25 2018
,
Jan 19 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/overlays/overlay-reef-private/+/19395500c48b02446ea8ee4171234135c1aa33bc commit 19395500c48b02446ea8ee4171234135c1aa33bc Author: Benjamin Gordon <bmgordon@chromium.org> Date: Fri Jan 19 01:40:25 2018
,
Jan 19 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/overlays/overlay-kahlee-private/+/08ac3cd50f806bc09f668f8bb34eafdbefc48bfd commit 08ac3cd50f806bc09f668f8bb34eafdbefc48bfd Author: Benjamin Gordon <bmgordon@chromium.org> Date: Fri Jan 19 01:40:37 2018
,
Jan 19 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/overlays/overlay-coral-private/+/40bc47118f5546e0011b8d657b37766bf19796d7 commit 40bc47118f5546e0011b8d657b37766bf19796d7 Author: Benjamin Gordon <bmgordon@chromium.org> Date: Fri Jan 19 01:40:43 2018
,
Jan 19 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/overlays/overlay-rainier-private/+/65dd8ed30471388adf226bc6f06b8fe653057c79 commit 65dd8ed30471388adf226bc6f06b8fe653057c79 Author: Benjamin Gordon <bmgordon@chromium.org> Date: Fri Jan 19 01:40:42 2018
,
Jan 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/822d4d1dde93f052e625d1f97118ba4ecebd4e2e commit 822d4d1dde93f052e625d1f97118ba4ecebd4e2e Author: Benjamin Gordon <bmgordon@chromium.org> Date: Fri Jan 19 01:40:15 2018 arc-setup: Add dependencies on chromeos-config https://crrev.com/c/864491 adds code that requires chromeos-config and chromeos-config-tools for unibuilds. This adds matching dependencies to the ebuild. chromeos-config-tools contains libcros_config, so it is always needed. chromeos-config contains the runtime configuration, so it is only needed when unibuild is enabled. When unibuild isn't enabled, libcros_config will handle the missing config. BUG= chromium:787004 TEST=build_packages --board=coral Change-Id: I5f32f2227b19e7a5d0a3be1f3b1a9c2f23a1f984 Reviewed-on: https://chromium-review.googlesource.com/868311 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Benjamin Gordon <bmgordon@chromium.org> Reviewed-by: Yusuke Sato <yusukes@chromium.org> [modify] https://crrev.com/822d4d1dde93f052e625d1f97118ba4ecebd4e2e/chromeos-base/arc-setup/arc-setup-9999.ebuild
,
Jan 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/50981e5587c75393ecafa80aecdc0f5c051bc15b commit 50981e5587c75393ecafa80aecdc0f5c051bc15b Author: Benjamin Gordon <bmgordon@chromium.org> Date: Fri Jan 19 01:40:16 2018 arc-setup: Set up runtime Android build properties For unibuild-enabled boards, the Android build fingerprint and other build properties need to be expanded at runtime based on the model instead of being fixed by board. The installed props files will be changed to include {property} substitutions in appropriate places. arc-setup needs to expand these substitutions into /run/arc/properties so that they can be bind-mounted back into the container during startup. BUG= chromium:787004 TEST=Installed on astronaut and kahlee CQ-DEPEND=CL:868311 Change-Id: Id499b5ab7b3af3add636d7c27df4fbd2b44fef3d Reviewed-on: https://chromium-review.googlesource.com/864491 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Benjamin Gordon <bmgordon@chromium.org> Reviewed-by: Yusuke Sato <yusukes@chromium.org> [modify] https://crrev.com/50981e5587c75393ecafa80aecdc0f5c051bc15b/arc/setup/arc_setup_util.h [modify] https://crrev.com/50981e5587c75393ecafa80aecdc0f5c051bc15b/arc/setup/arc_setup_util_unittest.cc [modify] https://crrev.com/50981e5587c75393ecafa80aecdc0f5c051bc15b/arc/setup/arc_setup.cc [modify] https://crrev.com/50981e5587c75393ecafa80aecdc0f5c051bc15b/arc/setup/arc_setup.h [modify] https://crrev.com/50981e5587c75393ecafa80aecdc0f5c051bc15b/arc/setup/arc_setup_util.cc [modify] https://crrev.com/50981e5587c75393ecafa80aecdc0f5c051bc15b/arc/setup/arc-setup.gyp
,
Jan 23 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/overlays/overlay-fizz-private/+/c6269466d34f0d598da107ad7de8b3d51b320006 commit c6269466d34f0d598da107ad7de8b3d51b320006 Author: Benjamin Gordon <bmgordon@chromium.org> Date: Tue Jan 23 19:24:17 2018
,
Feb 6 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/autotest-cheets/+/294c4ad8fbee835328c0869f474324c8a4e20ea3 commit 294c4ad8fbee835328c0869f474324c8a4e20ea3 Author: Benjamin Gordon <bmgordon@chromium.org> Date: Tue Feb 06 03:08:05 2018
,
Feb 6 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/autotest-cheets/+/994f3bd3b2eeeb87265afcd1428ad3605c2fded0 commit 994f3bd3b2eeeb87265afcd1428ad3605c2fded0 Author: Benjamin Gordon <bmgordon@chromium.org> Date: Tue Feb 06 03:08:08 2018
,
Feb 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/b090b4cc29f1d508e879ee7bd682397c7666ef7a commit b090b4cc29f1d508e879ee7bd682397c7666ef7a Author: Benjamin Gordon <bmgordon@chromium.org> Date: Tue Feb 06 03:08:07 2018 platform_FilePerms: Add new Android property mounts https://crrev.com/i/556418 adds new bind mounts for property files. This makes sure the new mount points are handled by autotest. BUG= chromium:787004 TEST=test_that -b grunt dut platform_FilePerms CQ-DEPEND=CL:*558291 Change-Id: I1dbe32d0eb9879c3952d00d03891c65ba8faec23 Reviewed-on: https://chromium-review.googlesource.com/895846 Commit-Ready: Benjamin Gordon <bmgordon@chromium.org> Tested-by: Benjamin Gordon <bmgordon@chromium.org> Reviewed-by: Yusuke Sato <yusukes@chromium.org> [modify] https://crrev.com/b090b4cc29f1d508e879ee7bd682397c7666ef7a/client/site_tests/platform_FilePerms/platform_FilePerms.py
,
Feb 6 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/cheets-scripts/+/3f41082e4d24854d04c5fb4dd8477913df9da8d1 commit 3f41082e4d24854d04c5fb4dd8477913df9da8d1 Author: Benjamin Gordon <bmgordon@chromium.org> Date: Tue Feb 06 03:08:06 2018
,
Feb 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/c43935042b7119e60cab740c2b70b06e6e65d402 commit c43935042b7119e60cab740c2b70b06e6e65d402 Author: Luis Hector Chavez <lhchavez@google.com> Date: Wed Feb 07 05:32:55 2018 arc-setup: Fix permissions of property files This change ensures that the property files have the correct permissions, ownership, and SELinux labels as they do in upstream Android. BUG= chromium:787004 TEST=Android boots again in caroline-arcnext TEST=cheets_ContainerSmokeTest Change-Id: I4dddccd84d8d646021f93d26a721b84866839973 Reviewed-on: https://chromium-review.googlesource.com/905088 Commit-Ready: Yusuke Sato <yusukes@chromium.org> Tested-by: Luis Hector Chavez <lhchavez@chromium.org> Reviewed-by: Yusuke Sato <yusukes@chromium.org> Reviewed-by: Benjamin Gordon <bmgordon@chromium.org> [modify] https://crrev.com/c43935042b7119e60cab740c2b70b06e6e65d402/arc/setup/arc_setup.cc
,
Feb 9 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/overlays/project-cheets-private/+/9a0c3b0adc48c140525d1dd6dc08d03f7725d955 commit 9a0c3b0adc48c140525d1dd6dc08d03f7725d955 Author: Benjamin Gordon <bmgordon@chromium.org> Date: Fri Feb 09 15:55:32 2018
,
Feb 9 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by bmgordon@chromium.org
, Nov 20 2017