The map data structure is not really a good fit since we can replace the data holds in the key to an attribute in the value field. https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/interventions_internals/interventions_internals.mojom?q=interventions_internals.mojom+map+-f:Debug&sq=package:chromium&dr=C&l=32 Add a value in corresponding struct, and replace the map with array<T>.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a60988132fe6e6ef530e283aed978232cccd85d9 commit a60988132fe6e6ef530e283aed978232cccd85d9 Author: Thanh Le <thanhdle@chromium.org> Date: Tue Dec 12 19:28:35 2017 Changed from map to array in mojom for Previews modes and flags values. The map data structure is not really a good fit since we can replace the data holds in the key to an attribute in the value field. Bug: 786996 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ib3f62522f2b3ea8a890bc1ba21d56509d5f13e8f Reviewed-on: https://chromium-review.googlesource.com/817517 Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Ryan Sturm <ryansturm@chromium.org> Reviewed-by: Tarun Bansal <tbansal@chromium.org> Commit-Queue: Thanh Le <thanhdle@chromium.org> Cr-Commit-Position: refs/heads/master@{#523506} [modify] https://crrev.com/a60988132fe6e6ef530e283aed978232cccd85d9/chrome/browser/resources/interventions_internals/index.js [modify] https://crrev.com/a60988132fe6e6ef530e283aed978232cccd85d9/chrome/browser/ui/webui/interventions_internals/interventions_internals.mojom [modify] https://crrev.com/a60988132fe6e6ef530e283aed978232cccd85d9/chrome/browser/ui/webui/interventions_internals/interventions_internals_page_handler.cc [modify] https://crrev.com/a60988132fe6e6ef530e283aed978232cccd85d9/chrome/browser/ui/webui/interventions_internals/interventions_internals_page_handler_unittest.cc [modify] https://crrev.com/a60988132fe6e6ef530e283aed978232cccd85d9/chrome/test/data/webui/interventions_internals_browsertest.js
Comment 1 by efoo@chromium.org
, Dec 5 2017