New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 786990 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Sep 26
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

Null-dereference in blink::LocalFrameView::ScheduleVisualUpdateForPaintInvalidationIfNeeded

Project Member Reported by ClusterFuzz, Nov 20 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5992571053801472

Fuzzer: inferno_twister_c
Job Type: windows_syzyasan_chrome
Platform Id: windows

Crash Type: Null-dereference
Crash Address: 0x00000077
Crash State:
  blink::LocalFrameView::ScheduleVisualUpdateForPaintInvalidationIfNeeded
  blink::LayoutObject::SetShouldDoFullPaintInvalidationWithoutGeometryChange
  blink::LayoutObject::SetShouldDoFullPaintInvalidation
  
Memory Tool: SYZYASAN

Regressed: https://clusterfuzz.com/revisions?job=windows_syzyasan_chrome&range=483256:483281

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5992571053801472

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Nov 20 2017

Components: Blink>Internals Blink>Layout
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Cc: kkaluri@chromium.org
Components: Blink>Paint>Invalidation
Labels: M-63 Test-Predator-Wrong
Owner: chrishtr@chromium.org
Status: Assigned (was: Untriaged)
Predator and CL could not provide any possible suspects.

Using the code search for the file, “layoutobject.cpp” assigning to concern owner.

Suspecting Commit# https://chromium.googlesource.com/chromium/src/+/2cff87c380b22ade36aa4d85a6f983387559178c

chrishtr@-- Could you please look into this issue, kindly reassign if it has nothing to do with your changes.


Thank You...
Components: -Blink>Layout -Blink>Paint>Invalidation -Blink>Internals Blink>DOM
Owner: ----
Status: Untriaged (was: Assigned)
The underlying bug here is that the use of document.adoptNode and DOMImplementation::createDocument leads to a case that a lot of Blink code
doesn't expect - (a) the document returned by the latter document has no 
LocalFrameView, and even when several of those callsites are patched up,
there is a crash in a DCHECK in ContainerNode about parentNode being expected
to be null.

Sending to the DOM component for analysis about what to do.
Cc: msrchandra@chromium.org pnangunoori@chromium.org
Owner: joelhockey@chromium.org
Status: Assigned (was: Untriaged)
Predator and CL could not provide any possible suspects.
Using the code search for the file, “localframeview.cpp” assigning to concern owner from GIT blame.

Suspecting Commit#
https://chromium.googlesource.com/chromium/src/+/6a5f851291ddd77204a5c18dd72d5fc7c1d30291

@joelhockey -- Could you please look into this issue, kindly reassign if it has nothing to do with your changes.

Thank You.

Status: Untriaged (was: Assigned)
As far as I can tell, this is nothing to do with my renaming CL or other changes I have made.  Setting status to Untriaged.
Cc: joelhockey@chromium.org
Owner: ----
Labels: CF-NeedsTriage
Unable to provide possible suspect using Predator, CL and Code Search.
Could someone please look into the issue.
Thank You.

Comment 8 by kochi@chromium.org, Dec 11 2017

Labels: -Pri-1 Pri-2
Status: Available (was: Untriaged)
This is a nullptr deref and would not be a security issue,
and is not a regression, deprioritizing.
This reprod on Linux @542740 built with AsanRel but does not repro anymore, so I am closing it.
Status: WontFix (was: Available)

Sign in to add a comment