New issue
Advanced search Search tips

Issue 786980 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 30
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

PresentationReceiver and PresentationConnectionList interfaces should not be exposed in WebView

Project Member Reported by timvolod...@chromium.org, Nov 20 2017

Issue description

Currently the following two Presentation API related interfaces are exposed in WebView:

interface PresentationReceiver
interface PresentationConnectionList : EventTarget

However we currently do not support Presentation API in WebView see crbug.com/521319. Therefore these interfaces should not be exposed similarly to other interfaces like Presentation, PresentationRequest etc..


 
Cc: mlamouri@chromium.org
Labels: -Pri-3 Pri-2
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c66635add81f127cc1c97a7188bd9eeaf5a85fcd

commit c66635add81f127cc1c97a7188bd9eeaf5a85fcd
Author: Tim Volodine <timvolodine@google.com>
Date: Wed Nov 22 18:41:41 2017

Make sure Presentation API related interfaces are not exposed in WebView.

Make sure that the IDL interfaces PresentationReceiver and
PresentationConnectionList are guarded by the presentation
runtime switch.

Make sure that they are not exposed in Android WebView.

BUG= 786980 
TBR=torne@chromium.org

Change-Id: If79be7a22f6ec22f7a5973b595c63a54d2f352ed
Reviewed-on: https://chromium-review.googlesource.com/779427
Commit-Queue: Tim Volodine <timvolodine@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518689}
[modify] https://crrev.com/c66635add81f127cc1c97a7188bd9eeaf5a85fcd/android_webview/tools/system_webview_shell/test/data/webexposed/not-webview-exposed.txt
[modify] https://crrev.com/c66635add81f127cc1c97a7188bd9eeaf5a85fcd/third_party/WebKit/Source/modules/presentation/PresentationConnectionList.idl
[modify] https://crrev.com/c66635add81f127cc1c97a7188bd9eeaf5a85fcd/third_party/WebKit/Source/modules/presentation/PresentationReceiver.idl

Status: Fixed (was: Started)

Sign in to add a comment