New issue
Advanced search Search tips

Issue 786976 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Dec 1
Cc:
brat...@opera.com
ehmaldonado@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 789209


Sign in to add a comment

git cl upload -d sometimes doesn't start a CQ dry-run

Project Member Reported by f...@opera.com, Nov 20 2017 
I (and bratell@) have seen this happen occasionally.

Here are a few example CLs:

https://chromium-review.googlesource.com/c/chromium/src/+/779260
https://chromium-review.googlesource.com/c/chromium/src/+/779198/2
https://chromium-review.googlesource.com/c/chromium/src/+/779140

For the second one there's at least an indication that something went badly ("
CQ rejected the patch"), but this does not appear to always be the case.

A common denominator for these CLs seems to be that they all immediately create a PS2 (for an updated commit message.)

Comment 1 by aga...@chromium.org, Nov 29 2017

Blockedon: 789209
Components: -Infra>Codereview>Gerrit Infra>Git
Status: Available (was: Untriaged)
Ah dang, good catch. Yeah, there's a really bad/broken PRESUBMIT thing called "post upload hooks" which lets PRESUBMIT.py files modify the commit description to add CQ_INCLUDE_TRYBOTS lines after the change has been uploaded. Unfortunately, changing the commit message is the same as uploading a new patchset (since it changes the commit hash) so the CQ stops.

This will be fixed by issue 789209
Project Member

Comment 2 by sheriffbot@chromium.org, Nov 30

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 3 by ajp@chromium.org, Dec 1

Cc: ehmaldonado@chromium.org
Status: Fixed (was: Untriaged)
We've recently removed the post upload hooks that modify commit descriptions. So, taking for granted that this was appropriately root caused, I'm going to call this issue fixed. Please reopen if that is not the case.
►

Sign in to add a comment