New issue
Advanced search Search tips

Issue 786966 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Task



Sign in to add a comment

Improving fill on account select Password Manager.

Project Member Reported by dvadym@chromium.org, Nov 20 2017

Issue description

The current implementation of fill on account select on IOS is very limited - it supports only 1 form on the page, doesn't support forms without <form> tag and filling password fields on click. Logic for filling on account select is pretty complex and it's worth a separate class. Having the separate class would also allow to test better this functionality. This bug is work tracking for improving of fill on account select.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f4c312133cc23628484d67ce590320a5aab7ac3c

commit f4c312133cc23628484d67ce590320a5aab7ac3c
Author: Vadym Doroshenko <dvadym@chromium.org>
Date: Tue Nov 21 09:58:56 2017

Improving fill on account select in IOS Password Manager.

The current implementation of fill on account select on IOS is very limited - it supports only
1 form on the page, doesn't support forms without <form> tag, filling of only password fields
and manual fallbacks for clicking on password field. Logic for filling on account select is
pretty complex and it's worth a separate class, it would also allow to test better this
functionality. This CL introduces a new class AccountSelectFillData for handling fill on
account select. Automatically it allows filling multiple forms on account select.

The future plans: base on newly introduced class AccountSelectFillData to implement in the following
CLs filling
 1.Forms without <form> tag
 2.Filling password fields on click (a.k.a. manual fallback for filling).

Bug:  708601 ,  786966 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I4549c8056f91aece3cf643e2540871c60820f4d8
Reviewed-on: https://chromium-review.googlesource.com/733093
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518199}
[modify] https://crrev.com/f4c312133cc23628484d67ce590320a5aab7ac3c/ios/chrome/browser/passwords/BUILD.gn
[add] https://crrev.com/f4c312133cc23628484d67ce590320a5aab7ac3c/ios/chrome/browser/passwords/account_select_fill_data.cc
[add] https://crrev.com/f4c312133cc23628484d67ce590320a5aab7ac3c/ios/chrome/browser/passwords/account_select_fill_data.h
[add] https://crrev.com/f4c312133cc23628484d67ce590320a5aab7ac3c/ios/chrome/browser/passwords/account_select_fill_data_unittest.cc
[modify] https://crrev.com/f4c312133cc23628484d67ce590320a5aab7ac3c/ios/chrome/browser/passwords/password_controller.mm
[modify] https://crrev.com/f4c312133cc23628484d67ce590320a5aab7ac3c/ios/chrome/browser/passwords/password_controller_unittest.mm
[add] https://crrev.com/f4c312133cc23628484d67ce590320a5aab7ac3c/ios/chrome/browser/passwords/test_helpers.cc
[add] https://crrev.com/f4c312133cc23628484d67ce590320a5aab7ac3c/ios/chrome/browser/passwords/test_helpers.h

Status: Fixed (was: Started)

Sign in to add a comment