New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 786964 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

Clean up ExperimentalSwReporterEngine feature

Project Member Reported by joenotcharles@chromium.org, Nov 20 2017

Issue description

The ExperimentalSwReporterEngine experiment is over, and should be made the default behaviour now.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5d34ad9dc7e098dde5d66c919f08bc0f534f7c24

commit 5d34ad9dc7e098dde5d66c919f08bc0f534f7c24
Author: Joe Mason <joenotcharles@chromium.org>
Date: Thu Nov 30 17:52:28 2017

Experimental SwReporter is no longer experimental.

Move the behaviour controlled by ExperimentalSwReporterEngine and
ExperimentalSwReporterEngineOnAllArchitectures outside the feature
checks so it is always on.

The exception is the "tag" parameter which is used in testing so must
still be set through a feature until the test scripts are updated.

Bug: 786964
Change-Id: I06bd7a599b3ab61121daca939d3df60967b3c0e6
Reviewed-on: https://chromium-review.googlesource.com/779302
Commit-Queue: Joe Mason <joenotcharles@chromium.org>
Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520595}
[modify] https://crrev.com/5d34ad9dc7e098dde5d66c919f08bc0f534f7c24/chrome/browser/component_updater/sw_reporter_installer_win.cc
[modify] https://crrev.com/5d34ad9dc7e098dde5d66c919f08bc0f534f7c24/chrome/browser/component_updater/sw_reporter_installer_win.h
[modify] https://crrev.com/5d34ad9dc7e098dde5d66c919f08bc0f534f7c24/chrome/browser/component_updater/sw_reporter_installer_win_unittest.cc
[modify] https://crrev.com/5d34ad9dc7e098dde5d66c919f08bc0f534f7c24/chrome/browser/safe_browsing/chrome_cleaner/srt_field_trial_win.cc
[modify] https://crrev.com/5d34ad9dc7e098dde5d66c919f08bc0f534f7c24/chrome/browser/safe_browsing/chrome_cleaner/srt_field_trial_win.h
[modify] https://crrev.com/5d34ad9dc7e098dde5d66c919f08bc0f534f7c24/components/chrome_cleaner/public/constants/constants.cc
[modify] https://crrev.com/5d34ad9dc7e098dde5d66c919f08bc0f534f7c24/components/chrome_cleaner/public/constants/constants.h
[modify] https://crrev.com/5d34ad9dc7e098dde5d66c919f08bc0f534f7c24/testing/variations/fieldtrial_testing_config.json

Labels: SafeBrowsing-Triaged
Cc: joenotcharles@chromium.org
Owner: veranika@chromium.org
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6117b4a7e3ad5dc172fc7cb4f2a464ea1e6638d5

commit 6117b4a7e3ad5dc172fc7cb4f2a464ea1e6638d5
Author: Veranika Liaukevich <veranika@chromium.org>
Date: Wed Mar 21 22:29:23 2018

Consolidate Chrome Cleanup distribution params under a single feature.

Also retires legacy URL for downloading Canary cleaner version.

Bug: 786964
Change-Id: I0026545eee940501f38c6b65a76e03dc2427481a
Reviewed-on: https://chromium-review.googlesource.com/965943
Reviewed-by: Joe Mason <joenotcharles@chromium.org>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Commit-Queue: Veranika Liaukevich <veranika@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544876}
[modify] https://crrev.com/6117b4a7e3ad5dc172fc7cb4f2a464ea1e6638d5/chrome/browser/component_updater/sw_reporter_installer_win.cc
[modify] https://crrev.com/6117b4a7e3ad5dc172fc7cb4f2a464ea1e6638d5/chrome/browser/component_updater/sw_reporter_installer_win.h
[modify] https://crrev.com/6117b4a7e3ad5dc172fc7cb4f2a464ea1e6638d5/chrome/browser/component_updater/sw_reporter_installer_win_unittest.cc
[modify] https://crrev.com/6117b4a7e3ad5dc172fc7cb4f2a464ea1e6638d5/chrome/browser/safe_browsing/chrome_cleaner/srt_field_trial_win.cc
[modify] https://crrev.com/6117b4a7e3ad5dc172fc7cb4f2a464ea1e6638d5/chrome/browser/safe_browsing/chrome_cleaner/srt_field_trial_win.h
[modify] https://crrev.com/6117b4a7e3ad5dc172fc7cb4f2a464ea1e6638d5/chrome/browser/safe_browsing/chrome_cleaner/srt_field_trial_win_unittest.cc

Sign in to add a comment