Issue metadata
Sign in to add a comment
|
CredentialManagerEGTest fails if run with other tests before |
||||||||||||||||||||||
Issue descriptionTests CredentialManagerEGTest/testNotificationAppearsOnAutoSignIn and CredentialManagerEGTest/testNotificationAppearsWhenTabIsActive fails if run as part of ios_chrome_integration_egtests but succeed if only CredentialManagerEGTest/* are run. I think they assume some state of the global application that is not true when other tests are run before. Could be due to features::kCredentialManager that is set up too late.
,
Nov 20 2017
Note: this has been failing since at least Nov 14 (according to https://build.chromium.org/p/chromium.mac/builders/ios-simulator-full-configs/builds/465 -- oldest build with available informations on the bots) but due to https://bugs.chromium.org/p/chromium/issues/detail?id=786965 the bots were green and sheriff missed the error.
,
Nov 20 2017
,
Nov 21 2017
,
Nov 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a65bd9a1eb35ad0259c271702dcb27b0e845fe08 commit a65bd9a1eb35ad0259c271702dcb27b0e845fe08 Author: Sylvain Defresne <sdefresne@chromium.org> Date: Tue Nov 21 11:18:47 2017 Disable CredentialManagerEGTest/* tests. The tests have been failing for a few days, but did not turn the tree red due to a bug in the bot (they are green even though the test is failing). Disabling the tests now that they turn some of the bots red. Bug: 786960 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I4e337f383749689cd16f816ff97fcc5a6b248829 Reviewed-on: https://chromium-review.googlesource.com/779120 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Mike Baxley <baxley@chromium.org> Cr-Commit-Position: refs/heads/master@{#518212} [modify] https://crrev.com/a65bd9a1eb35ad0259c271702dcb27b0e845fe08/ios/chrome/browser/passwords/BUILD.gn [modify] https://crrev.com/a65bd9a1eb35ad0259c271702dcb27b0e845fe08/ios/chrome/browser/passwords/credential_manager_egtest.mm
,
Nov 29
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by sdefresne@chromium.org
, Nov 20 2017