New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 786937 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
hobby only
Closed: Nov 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

CHECK failure: false. Trying to get the spec of an invalid URL! in gurl.cc

Project Member Reported by ClusterFuzz, Nov 20 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5696741826625536

Fuzzer: libFuzzer_csv_reader_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  false. Trying to get the spec of an invalid URL! in gurl.cc
  GURL::spec
  password_manager::PasswordCSVReader::RecordToPasswordForm
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=515502:515515

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5696741826625536

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Project Member

Comment 1 by ClusterFuzz, Nov 20 2017

Components: UI>Browser>Passwords
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Nov 20 2017

Labels: Test-Predator-Auto-Owner
Owner: vabr@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/4dcd2a618a0b2d8ccbf9b42e24d8a298f71dc502 (Add a fuzzer for CSV reader).

If this is incorrect, please remove the owner and apply the Test-Predator-Wrong-CLs label.

Comment 3 by vabr@chromium.org, Nov 21 2017

Status: Started (was: Assigned)
Patch in review https://crrev.com/c/781919
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0a82ab542d8745bf0554bbc4f8263142849444b2

commit 0a82ab542d8745bf0554bbc4f8263142849444b2
Author: Vaclav Brozek <vabr@chromium.org>
Date: Tue Nov 21 19:27:53 2017

Skip invalid URL in PasswordCSVReader

If a CSV file contains a record with an invalid URL (such as ":") in the 'url'
column, such record should be skipped.

Bug:  786937 
Change-Id: I59a6d85fd6ed099332b09d960784ad22190b94e3
Reviewed-on: https://chromium-review.googlesource.com/781919
Reviewed-by: Christos Froussios <cfroussios@chromium.org>
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518331}
[modify] https://crrev.com/0a82ab542d8745bf0554bbc4f8263142849444b2/components/password_manager/core/browser/import/password_csv_reader.cc
[modify] https://crrev.com/0a82ab542d8745bf0554bbc4f8263142849444b2/components/password_manager/core/browser/import/password_csv_reader_unittest.cc

Comment 5 by vabr@chromium.org, Nov 21 2017

Status: Fixed (was: Started)
Project Member

Comment 6 by ClusterFuzz, Nov 22 2017

ClusterFuzz has detected this issue as fixed in range 518327:518379.

Detailed report: https://clusterfuzz.com/testcase?key=5696741826625536

Fuzzer: libFuzzer_csv_reader_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  false. Trying to get the spec of an invalid URL! in gurl.cc
  GURL::spec
  password_manager::PasswordCSVReader::RecordToPasswordForm
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=515502:515515
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=518327:518379

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5696741826625536

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 7 by ClusterFuzz, Nov 22 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 5696741826625536 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment