Remove left-over references to ios/clean |
|||
Issue description$ gg ios/clean -- ios ios/chrome/browser/browser_state/DEPS: # Allow the instantiation of BrowserStateKeyedServiceFactories in ios/clean/ ios/chrome/browser/browser_state/DEPS: "+ios/clean/chrome/browser/ui/overlays/overlay_service_factory.h" ios/chrome/browser/ui/ntp/new_tab_page_view.mm: // called. Rather than refactor away all of this to support ios/clean, just ios/shared/DEPS: # Code in ios/shared is used by both ios/chrome and ios/clean/chrome, so ios/shared/DEPS: "-ios/clean/chrome", ios/shared/README.md:# Shared directory between ios/chrome and ios/clean/chrome ios/shared/README.md:`ios/clean/chrome`.
,
Nov 21 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/9c6c05cc65527780f51812a0a66237833aea5e1c commit 9c6c05cc65527780f51812a0a66237833aea5e1c Author: Sylvain Defresne <sdefresne@google.com> Date: Tue Nov 21 11:42:33 2017
,
Nov 21 2017
,
Nov 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/daaa9faed34a50b6d218eb0f4c1f4f9b7de59885 commit daaa9faed34a50b6d218eb0f4c1f4f9b7de59885 Author: Mark Cogan <marq@google.com> Date: Tue Nov 21 14:58:31 2017 [iOS] Remove ios/shared and remaining ios/clean references. This CL removes some DEPS entries and comments that reference ios/clean, and moves the remaining file in ios/shared and then removes that directory. Bug: 786928 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I2d63fb92f024297eebf5a53e87dc0a5277e74784 Reviewed-on: https://chromium-review.googlesource.com/781701 Reviewed-by: Mark Cogan <marq@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#518244} [modify] https://crrev.com/daaa9faed34a50b6d218eb0f4c1f4f9b7de59885/ios/chrome/browser/browser_state/DEPS [modify] https://crrev.com/daaa9faed34a50b6d218eb0f4c1f4f9b7de59885/ios/chrome/browser/ui/commands/BUILD.gn [rename] https://crrev.com/daaa9faed34a50b6d218eb0f4c1f4f9b7de59885/ios/chrome/browser/ui/commands/settings_main_page_commands.h [modify] https://crrev.com/daaa9faed34a50b6d218eb0f4c1f4f9b7de59885/ios/chrome/browser/ui/ntp/new_tab_page_view.mm [modify] https://crrev.com/daaa9faed34a50b6d218eb0f4c1f4f9b7de59885/ios/chrome/browser/ui/settings/settings_collection_view_controller.mm [delete] https://crrev.com/b2794d55f1ae92a75759beff1f024abe096cb358/ios/shared/DEPS [delete] https://crrev.com/b2794d55f1ae92a75759beff1f024abe096cb358/ios/shared/OWNERS [delete] https://crrev.com/b2794d55f1ae92a75759beff1f024abe096cb358/ios/shared/README.md [delete] https://crrev.com/b2794d55f1ae92a75759beff1f024abe096cb358/ios/shared/chrome/browser/ui/DEPS [delete] https://crrev.com/b2794d55f1ae92a75759beff1f024abe096cb358/ios/shared/chrome/browser/ui/omnibox/BUILD.gn [delete] https://crrev.com/b2794d55f1ae92a75759beff1f024abe096cb358/ios/shared/chrome/browser/ui/settings/BUILD.gn
,
Nov 21 2017
,
Nov 22 2017
Issue 786935 has been merged into this issue. |
|||
►
Sign in to add a comment |
|||
Comment 1 by sdefresne@chromium.org
, Nov 21 2017