New issue
Advanced search Search tips

Issue 786925 link

Starred by 1 user
Status: Available
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

autotag/lkgr bot of V8's release branch builders should block on test failures

Project Member Reported by hablich@chromium.org, Nov 20 2017 
Reference: https://docs.google.com/document/d/1X8wTLW0LUdJvK8SEPZNBqRhhnvNPCSuIh2iAxQZhasE/edit#

For release branches we currently create an LKGR version (e.g. https://chromium.googlesource.com/v8/v8/+log/5.5-lkgr). Currently this points automatically to the latest version bump on the branch (e.g. https://chromium.googlesource.com/v8/v8/+/d7d939784d67bdfd8a466119375ede9960332901). This LKGR version is referenced in Chrome beta and stable builds.

The proposed change:

Only update the LKGR if:
1.) New commit is a version bump
2.) AND new commit passed all the branch builders (see https://build.chromium.org/p/client.v8.branches/console as reference)

This is essentially stage 3 in the linked document.

Comment 1 by machenb...@chromium.org, Nov 20 2017

Status: Available (was: Untriaged)
The only blocker is to teach lkgr_finder to differentiate between the different branches we test on the same bot. I.e. scenario:
- beta-bot1 has build number X with branch N
- now we promote beta/stable
- beta-bot1 make a new build with build number X+1 with branch N+1
lkgr_finder would naively compare X and X+1, but those are not comparable because they are on different branches.

If we could make lkgr_finder aware of this, we could make a separate config that maps the group of beta bots to e.g. a beta-lkgr ref. The tag bot could then be taught to read from this ref and update it's e.g. 5.5-lkgr (assuming 5.5 is beta) based on beta-lkgr and the version-bump condition.

Maybe we could unify the two by creating a simple dummy builder that tests all builds and fails on builds that violate the version condition?

Comment 2 by machenb...@chromium.org, Nov 20 2017 

Also: Ideally the lkgr configs and the V8 beta/stable to number mapping should live in the same repo. Currently this is infra/infra and infra/build.
Project Member

Comment 3 by sheriffbot@chromium.org, Nov 20

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by machenb...@chromium.org, Nov 21

Labels: -Pri-2 -Hotlist-Recharge-Cold Pri-3
Status: Available (was: Untriaged)
►

Sign in to add a comment