New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 786917 link

Starred by 3 users

Issue metadata

Status: Archived
Owner: ----
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Feature



Sign in to add a comment

Extension upgrade permission grant don't list new permissions.

Project Member Reported by kevincox@google.com, Nov 20 2017

Issue description

Chrome Version       : 62.0.3202.94
OS Version: Debian
URLs (if applicable) : N/A
Other browsers tested: N/A

What steps will reproduce the problem?
1. Let extension update and require new permission.
2. Click warning menu bar.
3. Click "Accept new permissions"

What is the expected result?

That I was presented with the new permissions before they were granted.

What happens instead of that?

The permissions were granted before I was presented with a list of new permissions to review.
 
Cc: krajshree@chromium.org
Components: Platform>Extensions
Labels: Needs-Triage-M62 Needs-Feedback Triaged-ET
kevincox@ - Thanks for filing the issue...!!
Could you please provide a sample extension that require permission to test the issue from TE-end.
This will help us in triaging the issue further.

Thanks...!!

Comment 2 by kevincox@google.com, Nov 21 2017

The particular example was https://chrome.google.com/webstore/detail/autorefresh/coajpehkfphdhlcpnokeamdjlhfhannb but you have to test the change from not requiring a permission to requiring an additional permission. I don't think this is specific to any particular extension.
Project Member

Comment 3 by sheriffbot@chromium.org, Nov 21 2017

Labels: -Needs-Feedback
Thank you for providing more feedback. Adding requester "krajshree@chromium.org" to the cc list and removing "Needs-Feedback" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by woxxom@gmail.com, Nov 21 2017

The documentation has an example of such warning:
https://developer.chrome.com/extensions/permission_warnings

Apparently the bug report is about this warning not properly displayed or not displayed at all.

Comment 5 by kevincox@google.com, Nov 21 2017

Yes, it was like the image on that page (linked) but it didn't list the new warnings. Maybe looking at the history of the linked extension will provide clues.

https://developer.chrome.com/static/images/perms-hw2.png

Comment 6 by woxxom@gmail.com, Nov 21 2017

krajshree@, this bug report is a feature request for the re-enable dialog (see #c5):
the newly added permissions should be displayed separately or have a prefix like "Not yet granted: "
because the users can't and don't need to remember permissions of the previous version of an extension.

Comment 7 by kevincox@google.com, Nov 21 2017

Almost. Except in this case it didn't list any permissions, new or existing.

I expected them to be shown when I click the "grant" button but that just enabled the extension and dismissed the dialog.
Labels: -Type-Bug M-64 Type-Feature
Status: Untriaged (was: Unconfirmed)
As per comment #6 & 7 Issue seems to be Feature request marking it as untriaged for further inputs on this.

Thanks..!!
Cc: rdevlin....@chromium.org
Hmm... not sure I follow.  When an extension requests more permissions, chrome disables it.  It remains disabled until the user accepts the new permissions.  What is it exactly you'd prefer?

Comment 10 by woxxom@gmail.com, Dec 1 2017

rdevlin@, the problem is with the re-enable dialog, not the overall process. In the OP's case it didn't contain any permissions at all, which is a bug, but I don't know how to reproduce it. As for my suggestion, the newly added permissions that disabled the extension should be listed separately in the re-enable dialog so that it's obvious which ones were added. 
It's not clear to me that the OP saw an empty dialog from the description here.  kevincox@, is that what happened?

> As for my suggestion, the newly added permissions that disabled the extension should be listed separately in the re-enable dialog so that it's obvious which ones were added.

As of Chrome 60, we *only* show new permissions, not new and old.
Cc: kevincox@google.com
ping -> kevincox@.
Yes, I saw an empty dialog. It said something like "$extension needs new permissions to operate" and had cancel/continue buttons.

Because I didn't see the permissions listed here I expected that there would be a new page listing them, but instead it just enabled the extension.
Cc: catmulli...@chromium.org
Do you know which extension it was?  That's definitely a bug - we should never show an empty dialog.
Cc: -catmulli...@chromium.org
kevinkox, are you sure it was the extension you linked -- https://chrome.google.com/webstore/detail/autorefresh/coajpehkfphdhlcpnokeamdjlhfhannb ?

The Web Store says the entry was last changed March 1, 2017, but you reported this in November 2017.
Maybe there was an update that added permissions, then the warning was shown, but then another update that removed the new permissions before kevinkox clicked to reenable? This could to be the LinkedIn of the extension's developer: https://www.linkedin.com/in/r-anthony-billings-1137469a/  At least they have the exact same name. They could provide old versions, so that we could recreate the bug.
At this point I wouldn't say I am sure anymore (It's been a while) but I believe I grabbed the right link at the time.

It is weird if there hasn't been an update. Would it be possible that the extension was repackaged or something? This was roughly when I started using chrome again after a long time, so maybe it just didn't update until then? Sorry, but at this point my memory of the time is fading.
Status: Archived (was: Untriaged)
Unfortunately, I'm going to close this out.  Given we don't have a repro and haven't seen it since, and don't have enough insight into what might have caused it, I don't think there's a lot actionable here.

Please do re-open (or file a new bug) if you see it happen again!

Sign in to add a comment