Issue metadata
Sign in to add a comment
|
Regression:Previously selected pic preview is seen instead of captured picture preview in changePicture page |
||||||||||||||||||||||
Issue descriptionChrome Version:64.0.3272.0/10145.0.0 dev-channel Peach-Pit,Celes,Wolf OS:Chrome OS What steps will reproduce the problem? (1)Sign into user >>Open chrome://settings/changePicture page >>Capture photo (2)Now,select any other picture as preview>>again set the Captured photo as preview (3)Go back to chrome://settings page and Observe the profile icon at People section. Actual:Previously selected picture is seen Expected:Captured picture preview should be seen This is a Regression issue as same is working fine in 64.0.3246.0/10055.0.0 dev channel wolf Note:Issue is not seen in Linux,Windows OS @stevenjb: Please confirm the issue. Attaching screencast for your reference..
,
Dec 1 2017
,
Dec 1 2017
,
Dec 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e5a074a4c902e83f0d50cb06e9b6f400702333ba commit e5a074a4c902e83f0d50cb06e9b6f400702333ba Author: David Reveman <reveman@chromium.org> Date: Sat Dec 02 01:37:38 2017 Change Picture: Fix captured image selection. This fixes a regression introduced by crrev.com/d4e5fdd3f018ead78e22e62d6a5a1943e0014598. 'image-activate' needs to fire when selected item is of type OLD. Test: captured image is activated when selected Bug: 786887 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I5ef20f00ef8581721463be33b667456a955e0b6d Reviewed-on: https://chromium-review.googlesource.com/804834 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#521174} [modify] https://crrev.com/e5a074a4c902e83f0d50cb06e9b6f400702333ba/ui/webui/resources/cr_elements/chromeos/cr_picture/cr_picture_list.js
,
Dec 4 2017
,
Dec 4 2017
[Auto-generated comment by a script] We noticed that this issue is targeted for M-64; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-64 label, otherwise remove Merge-TBD label. Thanks.
,
Dec 11 2017
,
Dec 11 2017
Approving merge to M64 Chrome OS.
,
Dec 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/edbfd01f29d5aeece652d8126eabf894611872c2 commit edbfd01f29d5aeece652d8126eabf894611872c2 Author: David Reveman <reveman@chromium.org> Date: Mon Dec 11 23:36:14 2017 Change Picture: Fix captured image selection. This fixes a regression introduced by crrev.com/d4e5fdd3f018ead78e22e62d6a5a1943e0014598. 'image-activate' needs to fire when selected item is of type OLD. TBR=reveman@chromium.org (cherry picked from commit e5a074a4c902e83f0d50cb06e9b6f400702333ba) Test: captured image is activated when selected Bug: 786887 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I5ef20f00ef8581721463be33b667456a955e0b6d Reviewed-on: https://chromium-review.googlesource.com/804834 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: David Reveman <reveman@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#521174} Reviewed-on: https://chromium-review.googlesource.com/820856 Reviewed-by: David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/branch-heads/3282@{#159} Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840} [modify] https://crrev.com/edbfd01f29d5aeece652d8126eabf894611872c2/ui/webui/resources/cr_elements/chromeos/cr_picture/cr_picture_list.js |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by steve...@chromium.org
, Nov 20 2017