Autofill popup location for WebView is incorrect |
||||||||||||||
Issue descriptionAs shown in the attachment, the location of autofill popup for WebView is not correct in the current build from the source code.
,
Nov 20 2017
jaebaek, can you attach the apk you used to test
,
Nov 21 2017
You can use WebView that loads http://output.jsbin.com/murusuj and has wrap_content as its layout_width and layout_height. The attachment is the apk I tested on Android N and M. 1. After opening the app, attach any string (e.g., HelloWorld, Test, and so on) to the input form. 2. Press 'enter' button in your keyboard. (it may move to full screen webview page) 3. Kill the app and open it again. 4. If you press the input form, it will show autofill popup.
,
Nov 21 2017
Thank you for providing more feedback. Adding requester "msrchandra@chromium.org" to the cc list and removing "Needs-Feedback" label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 21 2017
@jaebaek -- Thank You for the update. From Comment# 3, tried installing the provided apk on Samsung SM-J710F (Android 7.0.0) and Pixel XL (Android 8.1.0) and was unable to launch the attached apk. When trying to launch the apk the following error "My application has stopped" is being displayed. Could you please provide us more information or screen cast which would help us in triaging the issue further. Thanks in Advance.
,
Nov 22 2017
Hmm.. Please try the following app again.
,
Nov 22 2017
Thank you for providing more feedback. Adding requester "msrchandra@chromium.org" to the cc list and removing "Needs-Feedback" label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 22 2017
@jaebaek -- Thank You for the new apk. Below are the steps followed. (i) Installed the app and launched it. (ii) Entered the text "Hello World" and clicked on Enter from Keyboard. (iii) Device requested to open it in Chrome or Chrome Canary. (iv) Clicked on Chrome and exited the apk installed. (v) Clicked on the text input in Chrome and observed the autofill suggestion is properly placed. (vi) Relaunched the apk installed and clicked on the text input but no autofill suggestions were seen. Please let me know if i have missed anything. Thanks in Advance.
,
Nov 23 2017
(vi) Relaunched the apk installed and clicked on the text input but no autofill suggestions were seen. Here click the text input one more .. See the attached video.
,
Nov 23 2017
Thank you for providing more feedback. Adding requester "msrchandra@chromium.org" to the cc list and removing "Needs-Feedback" label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 23 2017
,
Nov 27 2017
This is WebView autofill complete issue since the Android platform is pre-O.
,
Dec 11 2017
I just checked this bug happens in Android platform 6.0.1. (tested it in master branch after gclient sync) Please check it again.
,
Dec 11 2017
,
Dec 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2b5e77d0eadf50c634b4084f9a248c78402e7458 commit 2b5e77d0eadf50c634b4084f9a248c78402e7458 Author: Jaebaek Seo <jaebaek@chromium.org> Date: Tue Dec 12 00:31:19 2017 Relocate select popup of Android WebView As shown in crbug.com/786852 /#c9, the current select popup in Android WebView is not correctly located. The main reason is that the left margin for the anchor rectangle of the popup is added by x value of scroll manager. This CL adds y value of scroll manager to the left margin instead. Bug: 786852 Change-Id: I8ebf983de64eea3c89d8fc7d2063962a7f1c7bb1 Reviewed-on: https://chromium-review.googlesource.com/818679 Reviewed-by: Tao Bai <michaelbai@chromium.org> Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org> Commit-Queue: Jaebaek Seo <jaebaek@chromium.org> Cr-Commit-Position: refs/heads/master@{#523268} [modify] https://crrev.com/2b5e77d0eadf50c634b4084f9a248c78402e7458/android_webview/java/src/org/chromium/android_webview/AwScrollOffsetManager.java [modify] https://crrev.com/2b5e77d0eadf50c634b4084f9a248c78402e7458/android_webview/java/src/org/chromium/android_webview/AwViewAndroidDelegate.java
,
Dec 12 2017
,
Dec 13 2017
,
Dec 13 2017
,
Dec 18 2017
Reminder to please merge to M64 branch 3282 soon.
,
Dec 18 2017
,
Jan 2 2018
michaelbai@, please merge to M64 branch 3282.
,
Jan 4 2018
jaebaek@ You merged patch, didn't you? could you update the bug with the link of your merged patch?
,
Jan 5 2018
merge into 3282 in patch https://chromium-review.googlesource.com/c/chromium/src/+/818679
,
Jan 5 2018
I am so sorry about this mistake. I will update it at the next Monday.
,
Jan 5 2018
Please merge the approved cl(s) to M64 release branch 3282 as soon as possible.
,
Jan 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/40f72b1d9136e7dc01d5b33f78a0e100869f1057 commit 40f72b1d9136e7dc01d5b33f78a0e100869f1057 Author: Jaebaek Seo <jaebaek@chromium.org> Date: Mon Jan 08 16:09:23 2018 Relocate select popup of Android WebView As shown in crbug.com/786852 /#c9, the current select popup in Android WebView is not correctly located. The main reason is that the left margin for the anchor rectangle of the popup is added by x value of scroll manager. This CL adds y value of scroll manager to the left margin instead. Bug: 786852 Change-Id: I8ebf983de64eea3c89d8fc7d2063962a7f1c7bb1 Reviewed-on: https://chromium-review.googlesource.com/818679 Reviewed-by: Tao Bai <michaelbai@chromium.org> Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org> Commit-Queue: Jaebaek Seo <jaebaek@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#523268}(cherry picked from commit 2b5e77d0eadf50c634b4084f9a248c78402e7458) Reviewed-on: https://chromium-review.googlesource.com/822010 Cr-Commit-Position: refs/branch-heads/3282@{#444} Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840} [modify] https://crrev.com/40f72b1d9136e7dc01d5b33f78a0e100869f1057/android_webview/java/src/org/chromium/android_webview/AwScrollOffsetManager.java [modify] https://crrev.com/40f72b1d9136e7dc01d5b33f78a0e100869f1057/android_webview/java/src/org/chromium/android_webview/AwViewAndroidDelegate.java
,
Jan 11 2018
Verified on Black Berry Key Note /NMF26F, HTC A9/NRD90M , Galaxy S8/NRD90M having 64.0.3282.85, Issue mentioned with the attached apk in comment #23 is no longer reproducible.Thanks for the fix. |
||||||||||||||
►
Sign in to add a comment |
||||||||||||||
Comment 1 by msrchandra@chromium.org
, Nov 20 2017Labels: Needs-triage-Mobile Triaged-Mobile Needs-Feedback