New issue
Advanced search Search tips

Issue 786850 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Record UMA for raf based animation

Project Member Reported by xidac...@chromium.org, Nov 20 2017

Issue description

Right now we have UMA recording frame rate of CSS animations, we have UMAs for main thread css animation and composited animations. We should plumb a signal to tell whether a particular frame has raf or not. If this frame has raf and there is visual update, we should record as main thread animation.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1619b42e1dadfb3d64b5c80ecb082f82d340a401

commit 1619b42e1dadfb3d64b5c80ecb082f82d340a401
Author: Stephen McGruer <smcgruer@chromium.org>
Date: Tue Feb 20 18:46:55 2018

Measure framerate due to rAF

This CL measures frame rates due to rAF animations.

Right now we have Scheduling.DrawIntervalWithCompositedAnimations2 and
WithMainThreadAnimations2 that measures frame rates due to css animations.
This CL basically tells whether the current frame has raf or not and pass
this bit all the way to the CompositorTimingHistory::DidDraw(). The
DidDraw function indicates that there is some visual updates in this frame,
in this case, we record frame rate into the WithMainThreadAnimations2
if either this frame has raf or there is a main thread css animation.

Bug:  786850 
Change-Id: I337bbc3f4b448c11482ccb4cb9f83fc284a74c43
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/793750
Reviewed-by: Hayato Ito <hayato@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537832}
[modify] https://crrev.com/1619b42e1dadfb3d64b5c80ecb082f82d340a401/cc/animation/animation_host.cc
[modify] https://crrev.com/1619b42e1dadfb3d64b5c80ecb082f82d340a401/cc/animation/animation_host.h
[modify] https://crrev.com/1619b42e1dadfb3d64b5c80ecb082f82d340a401/cc/scheduler/compositor_timing_history.cc
[modify] https://crrev.com/1619b42e1dadfb3d64b5c80ecb082f82d340a401/cc/scheduler/compositor_timing_history.h
[modify] https://crrev.com/1619b42e1dadfb3d64b5c80ecb082f82d340a401/cc/scheduler/compositor_timing_history_unittest.cc
[modify] https://crrev.com/1619b42e1dadfb3d64b5c80ecb082f82d340a401/cc/scheduler/scheduler.cc
[modify] https://crrev.com/1619b42e1dadfb3d64b5c80ecb082f82d340a401/cc/scheduler/scheduler.h
[modify] https://crrev.com/1619b42e1dadfb3d64b5c80ecb082f82d340a401/cc/scheduler/scheduler_unittest.cc
[modify] https://crrev.com/1619b42e1dadfb3d64b5c80ecb082f82d340a401/cc/trees/mutator_host.h
[modify] https://crrev.com/1619b42e1dadfb3d64b5c80ecb082f82d340a401/cc/trees/proxy_impl.cc
[modify] https://crrev.com/1619b42e1dadfb3d64b5c80ecb082f82d340a401/cc/trees/proxy_impl.h
[modify] https://crrev.com/1619b42e1dadfb3d64b5c80ecb082f82d340a401/cc/trees/single_thread_proxy.cc
[modify] https://crrev.com/1619b42e1dadfb3d64b5c80ecb082f82d340a401/cc/trees/single_thread_proxy.h
[modify] https://crrev.com/1619b42e1dadfb3d64b5c80ecb082f82d340a401/third_party/WebKit/Source/core/animation/CompositorAnimationsTest.cpp
[modify] https://crrev.com/1619b42e1dadfb3d64b5c80ecb082f82d340a401/third_party/WebKit/Source/core/animation/DocumentAnimations.cpp
[add] https://crrev.com/1619b42e1dadfb3d64b5c80ecb082f82d340a401/third_party/WebKit/Source/core/animation/test_data/raf-countdown.html
[add] https://crrev.com/1619b42e1dadfb3d64b5c80ecb082f82d340a401/third_party/WebKit/Source/core/animation/test_data/raf-timeout.html
[modify] https://crrev.com/1619b42e1dadfb3d64b5c80ecb082f82d340a401/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/1619b42e1dadfb3d64b5c80ecb082f82d340a401/third_party/WebKit/Source/core/dom/Document.h
[modify] https://crrev.com/1619b42e1dadfb3d64b5c80ecb082f82d340a401/third_party/WebKit/Source/core/dom/ScriptedAnimationController.cpp
[modify] https://crrev.com/1619b42e1dadfb3d64b5c80ecb082f82d340a401/third_party/WebKit/Source/core/dom/ScriptedAnimationController.h
[modify] https://crrev.com/1619b42e1dadfb3d64b5c80ecb082f82d340a401/third_party/WebKit/Source/core/dom/ScriptedAnimationControllerTest.cpp
[modify] https://crrev.com/1619b42e1dadfb3d64b5c80ecb082f82d340a401/third_party/WebKit/Source/platform/animation/CompositorAnimationHost.cpp
[modify] https://crrev.com/1619b42e1dadfb3d64b5c80ecb082f82d340a401/third_party/WebKit/Source/platform/animation/CompositorAnimationHost.h

Status: Fixed (was: Assigned)

Sign in to add a comment