New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 786848 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug
Team-Accessibility



Sign in to add a comment

DumpAccessibilityTreeTest.AccessibilityAria.* are failing consistently on "Mac ASan 64 Tests (1)"

Project Member Reported by tyoshino@chromium.org, Nov 20 2017

Issue description

The following tests are failing consistently on "Mac ASan 64 Tests (1)"

DumpAccessibilityTreeTest.AccessibilityAriaTimer
DumpAccessibilityTreeTest.AccessibilityAriaAtomic
DumpAccessibilityTreeTest.AccessibilityAriaLiveWithContent
DumpAccessibilityTreeTest.AccessibilityAriaAlert

since this build:

https://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Tests%20%281%29/builds/36116

dmazzoni@, please take a look.

 

Comment 1 by mkwst@chromium.org, Nov 20 2017

I suspect it's either https://chromium-review.googlesource.com/c/chromium/src/+/772290 or https://chromium-review.googlesource.com/692704. Will try reverting one, then the other. :)

Comment 3 by mkwst@chromium.org, Nov 20 2017

Revert failed due to changes between Friday and now. Poking at it to see how bad the diff is.

Comment 4 by mkwst@chromium.org, Nov 20 2017

Tried and failed to get this fixed. Deferring to dmazzoni@, who should be waking up soon? :) :)
I'll either fix or disable the tests right now.

Project Member

Comment 7 by bugdroid1@chromium.org, Nov 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3045acb501991e37fb2416ab8816d2ff4e66735f

commit 3045acb501991e37fb2416ab8816d2ff4e66735f
Author: Dominic Mazzoni <dmazzoni@chromium.org>
Date: Mon Nov 20 22:33:17 2017

No AX live region event on removing a node.

This code was leading to a UAF on Mac. Disable one
test for now, will need to revisit once we find a safer
way to fire that event.

Bug:  786848 
Change-Id: Ib862874ea149ee3751cbbff4d955f03987918737
Reviewed-on: https://chromium-review.googlesource.com/779062
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517956}
[modify] https://crrev.com/3045acb501991e37fb2416ab8816d2ff4e66735f/content/browser/accessibility/dump_accessibility_events_browsertest.cc
[modify] https://crrev.com/3045acb501991e37fb2416ab8816d2ff4e66735f/ui/accessibility/ax_event_generator.cc

Project Member

Comment 8 by sheriffbot@chromium.org, Dec 11 2017

Pri-0 bugs are critical regressions or serious emergencies, and this bug has not been updated in three days. Could you please provide an update, or adjust the priority to a more appropriate level if applicable?

If a fix is in active development, please set the status to Started.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Pri-0 Pri-1
Status: Fixed (was: Assigned)

Sign in to add a comment