New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 786836 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Mojofy FrameHostMsg_* messages/

Project Member Reported by slangley@chromium.org, Nov 19 2017

Issue description

Let's start mojofying from FrameHostMsg's.

Start with

- FrameHostMsg_DidChangeName
- FrameHostMsg_DidSetFeaturePolicyHeader
- FrameHostMsg_EnforceInsecureRequestPolicy

and then we can go for the harder ones.
 

Comment 1 by sa...@chromium.org, Nov 22 2017

Cc: austi...@google.com
Status: Started (was: Assigned)
I'm getting with these 2 too:
FrameMsg_ExtractSmartClipData
FrameHostMsg_SmartClipDataExtracted
I'm taking FrameHostMsg_UpdateEncoding and FrameHostMsg_CancelInitialHistoryLoad
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8def47f83bb6413eee451db95b15ceb96c24dba8

commit 8def47f83bb6413eee451db95b15ceb96c24dba8
Author: Luciano Pacheco <lucmult@chromium.org>
Date: Thu Dec 07 06:52:30 2017

Convert 3 Frame IPC calls to mojo

Convert FrameHostMsg_DidChangeName, FrameHostMsg_DidSetFramePolicyHeaders
and FrameHostMsg_EnforceInsecureRequestPolicy from IPC calls to mojo.

Create mojo conversions for enum FeaturePolicyFeature and struct
ParsedFeaturePolicyDeclaration.

Update third_party/WebKit/common/feature_policy/OWNERS with IPC
SECURITY_OWNERS settings for new mojo files.

Bug: 786836
Change-Id: I18d18956197d3c7c5a713c61dd9856c8a31c06f7
Reviewed-on: https://chromium-review.googlesource.com/784372
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522370}
[modify] https://crrev.com/8def47f83bb6413eee451db95b15ceb96c24dba8/content/browser/frame_host/render_frame_host_feature_policy_unittest.cc
[modify] https://crrev.com/8def47f83bb6413eee451db95b15ceb96c24dba8/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/8def47f83bb6413eee451db95b15ceb96c24dba8/content/browser/frame_host/render_frame_host_impl.h
[modify] https://crrev.com/8def47f83bb6413eee451db95b15ceb96c24dba8/content/common/BUILD.gn
[modify] https://crrev.com/8def47f83bb6413eee451db95b15ceb96c24dba8/content/common/frame.mojom
[modify] https://crrev.com/8def47f83bb6413eee451db95b15ceb96c24dba8/content/common/frame_messages.h
[modify] https://crrev.com/8def47f83bb6413eee451db95b15ceb96c24dba8/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/8def47f83bb6413eee451db95b15ceb96c24dba8/content/test/test_render_frame.cc
[modify] https://crrev.com/8def47f83bb6413eee451db95b15ceb96c24dba8/content/test/test_render_frame_host.cc
[modify] https://crrev.com/8def47f83bb6413eee451db95b15ceb96c24dba8/third_party/WebKit/common/BUILD.gn
[modify] https://crrev.com/8def47f83bb6413eee451db95b15ceb96c24dba8/third_party/WebKit/common/feature_policy/OWNERS
[add] https://crrev.com/8def47f83bb6413eee451db95b15ceb96c24dba8/third_party/WebKit/common/feature_policy/feature_policy.mojom
[add] https://crrev.com/8def47f83bb6413eee451db95b15ceb96c24dba8/third_party/WebKit/common/feature_policy/feature_policy.typemap
[add] https://crrev.com/8def47f83bb6413eee451db95b15ceb96c24dba8/third_party/WebKit/common/feature_policy/feature_policy_struct_traits.cc
[add] https://crrev.com/8def47f83bb6413eee451db95b15ceb96c24dba8/third_party/WebKit/common/feature_policy/feature_policy_struct_traits.h
[modify] https://crrev.com/8def47f83bb6413eee451db95b15ceb96c24dba8/third_party/WebKit/common/typemaps.gni

Project Member

Comment 6 by bugdroid1@chromium.org, Dec 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8528c16f6bfdd4c106ebc95fdd5bf261eb81479d

commit 8528c16f6bfdd4c106ebc95fdd5bf261eb81479d
Author: Luciano Pacheco <lucmult@chromium.org>
Date: Thu Dec 14 07:10:56 2017

Convert FrameMsg_ExtractSmartClipData to Mojo

Convert and merge FrameHostMsg_SmartClipDataExtracted now using Mojo
callback directly.

Bug: 786836
Change-Id: If2925e9e019854558f8c97cf51e6b0d32b521345
Reviewed-on: https://chromium-review.googlesource.com/804804
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524017}
[modify] https://crrev.com/8528c16f6bfdd4c106ebc95fdd5bf261eb81479d/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/8528c16f6bfdd4c106ebc95fdd5bf261eb81479d/content/browser/frame_host/render_frame_host_impl.h
[modify] https://crrev.com/8528c16f6bfdd4c106ebc95fdd5bf261eb81479d/content/browser/web_contents/web_contents_android.cc
[modify] https://crrev.com/8528c16f6bfdd4c106ebc95fdd5bf261eb81479d/content/common/frame.mojom
[modify] https://crrev.com/8528c16f6bfdd4c106ebc95fdd5bf261eb81479d/content/common/frame_messages.h
[modify] https://crrev.com/8528c16f6bfdd4c106ebc95fdd5bf261eb81479d/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/8528c16f6bfdd4c106ebc95fdd5bf261eb81479d/content/renderer/render_frame_impl.h

Project Member

Comment 7 by bugdroid1@chromium.org, Dec 20 2017

Owner: ----
Status: Available (was: Started)
Cc: hajimehoshi@chromium.org
Cc: -hajimehoshi@chromium.org

Sign in to add a comment