New issue
Advanced search Search tips

Issue 786831 link

Starred by 2 users

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Task



Sign in to add a comment

enable jumbo builds for sandbox/linux

Project Member Reported by most...@vewd.com, Nov 19 2017

Issue description

//sandbox/linux has a couple of issues that prevent jumbo builds from working, let's fix these and enable jumbo builds (off by default).
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/452bf63420f4d504dfb8ed8025dd4bd049c72f26

commit 452bf63420f4d504dfb8ed8025dd4bd049c72f26
Author: Mostyn Bramley-Moore <mostynb@vewd.com>
Date: Tue Nov 28 21:51:42 2017

[jumbo] use RunningOnValgrind from dynamic_annotations

dynamic_annotations is a small library intended to help tsan code
coexist with valgrind.  This CL makes the linux sandbox code use
the RunningOnValgrind() function instead of (multiply) defining its
own version, and does not use the annotations which are being phased
out.

TODO: remove valgrind checks that are no longer needed (perhaps
all of these?)

Bug: 786831,349861
Change-Id: I39f83d5dc839c54c5bc9297e9a92bd3f84ead726
Reviewed-on: https://chromium-review.googlesource.com/778881
Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com>
Reviewed-by: Julien Tinnes <jln@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519858}
[modify] https://crrev.com/452bf63420f4d504dfb8ed8025dd4bd049c72f26/base/process/launch_posix.cc
[modify] https://crrev.com/452bf63420f4d504dfb8ed8025dd4bd049c72f26/sandbox/linux/BUILD.gn
[modify] https://crrev.com/452bf63420f4d504dfb8ed8025dd4bd049c72f26/sandbox/linux/seccomp-bpf/sandbox_bpf.cc
[modify] https://crrev.com/452bf63420f4d504dfb8ed8025dd4bd049c72f26/sandbox/linux/seccomp-bpf/sandbox_bpf_test_runner.cc
[modify] https://crrev.com/452bf63420f4d504dfb8ed8025dd4bd049c72f26/sandbox/linux/services/credentials.cc
[modify] https://crrev.com/452bf63420f4d504dfb8ed8025dd4bd049c72f26/sandbox/linux/services/namespace_utils.cc
[modify] https://crrev.com/452bf63420f4d504dfb8ed8025dd4bd049c72f26/sandbox/linux/services/thread_helpers_unittests.cc
[modify] https://crrev.com/452bf63420f4d504dfb8ed8025dd4bd049c72f26/sandbox/linux/syscall_broker/broker_host.cc
[modify] https://crrev.com/452bf63420f4d504dfb8ed8025dd4bd049c72f26/sandbox/linux/tests/unit_tests.cc
[modify] https://crrev.com/452bf63420f4d504dfb8ed8025dd4bd049c72f26/sandbox/linux/tests/unit_tests.h

Sign in to add a comment