New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 786735 link

Starred by 1 user
Status: Available
Owner: ----
Cc:
█ aludwin@google.com
vadimsh@chromium.org
mar...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature

Blocked on:
issue 786734
Blocking:
issue 786027
issue 916548



Sign in to add a comment

Create BotSession object

Project Member Reported by mar...@chromium.org, Nov 18 2017 
One of the big problem performance wise is the lack of session token for bot. With the proto API there's a specific session per bot handshake.

Having a session has one benefit, the composite object can contain all the necessary data loaded at the start of each RPC, reducing all the fetches to a single one.

When an event occurs that would cause all sessions to be forcibly canceled, the entities can be forced out. This will remove the need for most @utils.cache_with_expiration().

Making this efficient will be easier if issue 786734 is implemented so the dimensions can'T be continuously changing.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 11 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-py.git/+/e40c4f2702d0d007a1e3b95ffa755462be90c5c9

commit e40c4f2702d0d007a1e3b95ffa755462be90c5c9
Author: Marc-Antoine Ruel <maruel@chromium.org>
Date: Wed Apr 11 01:30:24 2018

[swarming] shuffle handlers_bot.py code around

While breaking git blame is annoying, I want to do refactoring and the previous
layout was getting in the way because the code was not well organized.

Move the code with *no functional change*.

The code is now grouped in 3 main sections, with Bot API RPCs broken into 3
smaller ones:
- Generic handlers (no auth)
- Bot code (bootstrap and swarming_bot.zip) handlers
- Bot API RPCs
  - Bot Session API RPC handlers
  - Bot Security API RPC handlers
  - Bot Task API RPC handlers

Change-Id: I84efc847652245a4ac6865222bdb307bf6c9245f
Bug: 786735
Reviewed-on: https://chromium-review.googlesource.com/1005426
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org>

[modify] https://crrev.com/e40c4f2702d0d007a1e3b95ffa755462be90c5c9/appengine/swarming/handlers_bot.py

Comment 2 by mar...@chromium.org, Dec 19

Blocking: 916548
►

Sign in to add a comment