Mac WebGL 1+2 failures after WebGL roll (conformance_glsl_bugs_init_array_with_loop/conformance_canvas_render_after_resize_test) |
||||
Issue descriptionFirst failing builds: https://ci.chromium.org/buildbot/chromium.gpu.fyi/Mac%20Experimental%20Retina%20Release%20%28NVIDIA%29/2717 https://ci.chromium.org/buildbot/chromium.gpu.fyi/Mac%20Retina%20Debug%20%28NVIDIA%29/7063 https://ci.chromium.org/buildbot/chromium.gpu.fyi/Mac%20Retina%20Release%20%28NVIDIA%29/6169 Failures: webgl2_conformance_tests Unexpected Failures: * gpu_tests.webgl_conformance_integration_test.WebGLConformanceIntegrationTest.WebglConformance_conformance_canvas_render_after_resize_test * gpu_tests.webgl_conformance_integration_test.WebGLConformanceIntegrationTest.WebglConformance_conformance_glsl_bugs_init_array_with_loop webgl_conformance_tests Unexpected Failures: * gpu_tests.webgl_conformance_integration_test.WebGLConformanceIntegrationTest.WebglConformance_conformance_canvas_render_after_resize_test * gpu_tests.webgl_conformance_integration_test.WebGLConformanceIntegrationTest.WebglConformance_conformance_glsl_bugs_init_array_with_loop Suspecting: "Roll WebGL 12192b9..e4919fa" https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/12192b9..e4919fa Going to mark as failing.
,
Nov 21 2017
The render-after-resize-test.html failure is Issue 775202 . The init-array-with-loop.html failure has been filed as Issue 784817. I'm fixing Issue 775202 now and removing that suppression, and updating the other suppression to point to the other bug.
,
Nov 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3b7911b65b0d70164ed9b88ec22a9a455fa649b7 commit 3b7911b65b0d70164ed9b88ec22a9a455fa649b7 Author: Kenneth Russell <kbr@chromium.org> Date: Tue Nov 21 20:04:16 2017 Add workaround for reallocating depth-stencil renderbuffers. When needed, during reallocation of a depth-stencil renderbuffer, create a new object and point all existing framebuffer objects to it. Apply this workaround on NVIDIA GPUs on macOS 10.13 and later. This works around an apparent bug in the graphics driver introduced in this release. This is a slight expansion of the earlier multisample_renderbuffer_resize_emulation workaround. Remove associated failure expectations. Also update the bug ID in the conformance expectations for a workaround applying to the same platform. BUG= 775202 , 786717 , 784817 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I051009b17df1cb5dabe1b00fbdcc35008042eee9 Reviewed-on: https://chromium-review.googlesource.com/780211 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#518348} [modify] https://crrev.com/3b7911b65b0d70164ed9b88ec22a9a455fa649b7/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py [modify] https://crrev.com/3b7911b65b0d70164ed9b88ec22a9a455fa649b7/content/test/gpu/gpu_tests/webgl_conformance_expectations.py [modify] https://crrev.com/3b7911b65b0d70164ed9b88ec22a9a455fa649b7/gpu/command_buffer/service/gles2_cmd_decoder.cc [modify] https://crrev.com/3b7911b65b0d70164ed9b88ec22a9a455fa649b7/gpu/command_buffer/service/renderbuffer_manager.cc [modify] https://crrev.com/3b7911b65b0d70164ed9b88ec22a9a455fa649b7/gpu/command_buffer/service/renderbuffer_manager.h [modify] https://crrev.com/3b7911b65b0d70164ed9b88ec22a9a455fa649b7/gpu/config/gpu_driver_bug_list.json [modify] https://crrev.com/3b7911b65b0d70164ed9b88ec22a9a455fa649b7/gpu/config/gpu_driver_bug_workaround_type.h
,
Nov 21 2017
The failures are tracked in the bugs blocked on this one.
,
Nov 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/23a5326c8ae2d90654faeda8cbd7225b08ed3412 commit 23a5326c8ae2d90654faeda8cbd7225b08ed3412 Author: Kenneth Russell <kbr@chromium.org> Date: Tue Nov 28 19:03:46 2017 Add workaround for reallocating depth-stencil renderbuffers. When needed, during reallocation of a depth-stencil renderbuffer, create a new object and point all existing framebuffer objects to it. Apply this workaround on NVIDIA GPUs on macOS 10.13 and later. This works around an apparent bug in the graphics driver introduced in this release. This is a slight expansion of the earlier multisample_renderbuffer_resize_emulation workaround. Remove associated failure expectations. Also update the bug ID in the conformance expectations for a workaround applying to the same platform. BUG= 775202 , 786717 , 784817 TBR=kbr@chromium.org (cherry picked from commit 3b7911b65b0d70164ed9b88ec22a9a455fa649b7) Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I051009b17df1cb5dabe1b00fbdcc35008042eee9 Reviewed-on: https://chromium-review.googlesource.com/780211 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#518348} Reviewed-on: https://chromium-review.googlesource.com/794024 Reviewed-by: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/branch-heads/3239@{#584} Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578} [modify] https://crrev.com/23a5326c8ae2d90654faeda8cbd7225b08ed3412/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py [modify] https://crrev.com/23a5326c8ae2d90654faeda8cbd7225b08ed3412/content/test/gpu/gpu_tests/webgl_conformance_expectations.py [modify] https://crrev.com/23a5326c8ae2d90654faeda8cbd7225b08ed3412/gpu/command_buffer/service/gles2_cmd_decoder.cc [modify] https://crrev.com/23a5326c8ae2d90654faeda8cbd7225b08ed3412/gpu/command_buffer/service/renderbuffer_manager.cc [modify] https://crrev.com/23a5326c8ae2d90654faeda8cbd7225b08ed3412/gpu/command_buffer/service/renderbuffer_manager.h [modify] https://crrev.com/23a5326c8ae2d90654faeda8cbd7225b08ed3412/gpu/config/gpu_driver_bug_list.json [modify] https://crrev.com/23a5326c8ae2d90654faeda8cbd7225b08ed3412/gpu/config/gpu_driver_bug_workaround_type.h |
||||
►
Sign in to add a comment |
||||
Comment 1 by bugdroid1@chromium.org
, Nov 18 2017