New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 786715 link

Starred by 1 user
Status: Fixed
Owner:
patricia...@chromium.org
Closed: Nov 2017
Cc:
█ vamshi.k...@techmahindra.com
█ shrike@chromium.org
mac-bugs-priority@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Button hover animations in the user menu is missing

Project Member Reported by meh...@chromium.org, Nov 18 2017 
Chrome Version: Chrome Canary 64.0.3272.0
OS: macOS 10.12.6
Device: iMac 2012 Non-Retina

What steps will reproduce the problem?
(1) Click on the user menu icon
(2) Hover over the elements


What is the expected result?
To see an hover animation.

What happens instead?
The hover animation is missing.

A screencast is attached.

There was a fix for the laggy animation in  issue 784684 . Not sure if this could be related?
missing_hover.mov
601 KB Download

Comment 1 by vamshi.k...@techmahindra.com, Nov 20 2017

Cc: -patricia...@chromium.org vamshi.k...@techmahindra.com
Labels: -Needs-Bisect hasbisect-per-revision Triaged-ET ReleaseBlock-Stable M-64 Needs-Triage-M64
Owner: patricia...@chromium.org
Status: Assigned (was: Untriaged)
"Able to reproduce the issue on the reported chrome version 64.0.3272.0 using Mac 10.12.6.
Note: The issue is not seen on Windows 10 and Ubuntu 14.04.

Bisect info:
----------------------
Good Build: 64.0.3270.0 Revision(516942)
Bad Build:   64.0.3271.0  Revision(517250)

You are probably looking for a change made after 516995 (known good), but no later than 516996 (first known bad).
CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/92aa97948dbf94c5316014b00d7652f2e644e4e8..2dd7f6c07aa8da74798ccdee953cc33e8d484b2c

Reviewed on: https://chromium-review.googlesource.com/773319

Suspecting same from changelog.

@patricialor: Please confirm the issue and help in re-assigning if it is not related to your change.

Note: Adding label Release block stable as it seems to be a recent regression.

Thanks!
"
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f168a3d0f47f69345d88b462b1b73e429ee7dd6e

commit f168a3d0f47f69345d88b462b1b73e429ee7dd6e
Author: Patricia Lor <patricialor@chromium.org>
Date: Tue Nov 21 11:26:58 2017

Desktop Page Info/MacViews: HoverButtons override full keyboard access setting.

HoverButtons should show a background highlight when focused or when the mouse
is hovering over it. On Mac, the mouse hover is broken because the HoverButton
isn't focusable when the Full Keyboard Access setting is turned off (to
textboxes and lists only). Since HoverButtons are designed for use in a stack
(like a list / menu), ignore this setting and always allow HoverButtons to be
focusable on Mac.

Bug:  786715 
Change-Id: I7692b052886974389d45bb176c71f34d94eb269c
Reviewed-on: https://chromium-review.googlesource.com/781301
Commit-Queue: Trent Apted <tapted@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518213}
[modify] https://crrev.com/f168a3d0f47f69345d88b462b1b73e429ee7dd6e/chrome/browser/ui/views/hover_button.cc

Comment 3 by patricia...@chromium.org, Nov 21 2017

Status: Fixed (was: Assigned)
Thanks for filing this! I couldn't repro until tapted@ pointed out that this only occurs when full keyboard access is off. It's fixed now :)

Comment 4 by susanjuniab@chromium.org, Nov 22 2017

Labels: TE-Verified-64.0.3275.0 TE-Verified-M64
Tested this issue on Mac 10.12.6 using chrome latest Canary-64.0.3275.0 following the steps mentioned in the original comment.

On hovering on the menu items in the user menu items, can see the hover animation.
Attached is the screen shot for reference.

As the fix is working as intended, adding TE Verified labels.

Thanks..!
786715.png
143 KB View Download
►

Sign in to add a comment