New issue
Advanced search Search tips

Issue 786700 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Security



Sign in to add a comment

CrOS: Vulnerability reported in net-misc/wget

Project Member Reported by vomit.go...@appspot.gserviceaccount.com, Nov 18 2017

Issue description

Automated analysis has detected that the following third party packages have had vulnerabilities publicly reported. 

NOTE: There may be several bugs listed below - in almost all cases, all bugs can be quickly addressed by upgrading to the latest version of the package.

Package Name: net-misc/wget
Package Version: [cpe:/a:gnu:wget:1.17.1 cpe:/a:gnu:wget:1.19.1]

Advisory: CVE-2017-13089
  Details: https://vomit.googleplex.com/advisory?id=CVE/CVE-2017-13089
  CVSS severity score: 9.3/10.0
  Confidence: high
  Description:

The http.c:skip_short_body() function is called in some circumstances, such as when processing redirects. When the response is sent chunked in wget before 1.19.2, the chunk parser uses strtol() to read each chunk's length, but doesn't check that the chunk length is a non-negative number. The code then tries to skip the chunk in pieces of 512 bytes by using the MIN() macro, but ends up passing the negative chunk length to connect.c:fd_read(). As fd_read() takes an int argument, the high 32 bits of the chunk length are discarded, leaving fd_read() with a completely attacker controlled length argument.
Advisory: CVE-2017-13090
  Details: https://vomit.googleplex.com/advisory?id=CVE/CVE-2017-13090
  CVSS severity score: 9.3/10.0
  Confidence: high
  Description:

The retr.c:fd_read_body() function is called when processing OK responses. When the response is sent chunked in wget before 1.19.2, the chunk parser uses strtol() to read each chunk's length, but doesn't check that the chunk length is a non-negative number. The code then tries to read the chunk in pieces of 8192 bytes by using the MIN() macro, but ends up passing the negative chunk length to retr.c:fd_read(). As fd_read() takes an int argument, the high 32 bits of the chunk length are discarded, leaving fd_read() with a completely attacker controlled length argument. The attacker can corrupt malloc metadata after the allocated buffer.


 
Cc: vapier@chromium.org
Components: OS>Packages
Labels: M-64 Security_Severity-High Security_Impact-Stable
Status: Available (was: Untriaged)
Mike, upstream has 1.19.2 still masked as unstable: https://packages.gentoo.org/packages/net-misc/wget

How do we usually handle that situation?

Comment 3 by vapier@chromium.org, Nov 21 2017

Owner: adityakali@google.com
Status: Fixed (was: Available)
we don't care about upstream keyword status.  we take whatever works for us.

this should be fixed via:
  https://chromium-review.googlesource.com/780780
Project Member

Comment 4 by sheriffbot@chromium.org, Nov 22 2017

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Project Member

Comment 5 by sheriffbot@chromium.org, Dec 15 2017

Labels: Merge-Request-64
Project Member

Comment 6 by sheriffbot@chromium.org, Dec 15 2017

Labels: -Merge-Request-64 Hotlist-Merge-Review Merge-Review-64
This bug requires manual review: M64 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-64 Merge-Approved-64
Labels: -Merge-Approved-64
This has already been merged in M64.
Project Member

Comment 9 by sheriffbot@chromium.org, Feb 28 2018

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 10 by sheriffbot@chromium.org, Mar 27 2018

Labels: -M-64 M-65

Sign in to add a comment