Issue metadata
Sign in to add a comment
|
Files> 'MORE ACTIONS' button displayed instead of "OPEN' button for single .docx/ audio file selection |
||||||||||||||||||||||
Issue descriptionChrome OS: 10124.0.0, 64.0.3265.0 dev channel caroline device Steps to repro: 1. Open Files app, Goto to Downloads/Google Drive/USB folder. 2. Click on a single .docx/ .xlsx/ audio file 3. Observe the Files app top panel options Actual behavior: 'OPEN' button is missing. Instead 'MORE ACTIONS' button is displayed. This 'MORE ACTIONS' menu list is matching with context menu> 'Open with...' menu list. Expected behavior: It should be 'OPEN' button instead of 'MORE ACTIONS' Please refer the attachment.
,
Nov 20 2017
mkarkada@ - Can you double check this one? On samus, Version 64.0.3270.0 (Official Build) dev (64-bit), I am unable to reproduce.
,
Nov 20 2017
Hi weifangsun, I can see this issue on samus as well on latest M64 ToT build (10146.0.0, 64.0.3272.0). Please install Google Docs android app from Playstore, such that there will be 2 Open menu options and then this issue got repro'd.
,
Nov 20 2017
Ahh, thanks for the additional info. I see it now as well. fukino@ - Could you take a look?
,
Nov 27 2017
,
Dec 4 2017
yamaguchi@, I guess this is related to issue 761154 . After this change, if there is no default app, we show task picker when the file is double-clicked, and "OPEN WITH..." button will be shown on the toolbar. Could you double check if this is the new intended behavior?
,
Dec 4 2017
This change is revealed now because we didn't see such pattern like "have tasks, but no default task" before Issue 761154 fixed. I think this was by design before, but we could change it now. There has been a logic to switch the label of the button and its function. - When there's a default task, "OPEN". The left half of the combo button immediately launch it. - When there's not default task (but multiple choice), "More actions...". It shows popup menu. Based on Issue 740819 , I think the "Open" button should not be alternated to "More actions..." anymore, because the "share" icon is now labelled as "More actions..." as in the tooltip. So I think we should change it to "OPEN WITH..." when there's no default task but 1 or more tasks available. fukino@, WDYT?
,
Dec 5 2017
> we should change it to "OPEN WITH..." when there's no default task but 1 or more tasks available. SGTM.
,
Dec 5 2017
,
Jan 24 2018
This issue is seen even when a single or multiple zip archive is selected. Observed on M65 dev build (10323.2.0, 65.0.3325.11).
,
Jan 31 2018
,
Feb 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ac6fedc0d56562df48678b457d303857efb9423b commit ac6fedc0d56562df48678b457d303857efb9423b Author: Naoki Fukino <fukino@chromium.org> Date: Thu Feb 01 01:05:00 2018 Files app: Rename label of tasks' dropdown menu to "Open with...". We've used "More actions..." for the label of tasks' dropdown menu, since it can contain multiple types of tasks. Now that the dropdown menu contains only OPEN type tasks, we should rename it to "Open with...". Bug: 786652 Test: Manually tested on kevin. Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I3667f20e1490987ba3a87555f2e3af4f4369e22b Reviewed-on: https://chromium-review.googlesource.com/892727 Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Commit-Queue: Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#533503} [modify] https://crrev.com/ac6fedc0d56562df48678b457d303857efb9423b/ui/file_manager/file_manager/foreground/js/file_tasks.js
,
Feb 5 2018
,
Feb 16 2018
,
Feb 16 2018
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by mkarkada@chromium.org
, Nov 18 20171.6 MB
1.6 MB View Download