New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 786643 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 786945
Owner:
OOO until 2019-01-24
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Feature

Blocked on:
issue 599285
issue 786945



Sign in to add a comment

Add code path to copy to GpuMemoryBuffer when premultipliedAlpha is set to true

Project Member Reported by kbr@chromium.org, Nov 18 2017

Issue description

In  Issue 599285  WebGL's premultipliedAlpha context creation attribute was fixed on macOS by avoiding the use of GpuMemoryBuffers when it's set to false. (At least on macOS, Core Animation can't treat alpha as non-premultiplied.) The fallback, however, triggers the GL compositor, and we'd prefer to stay on the Core Animation path.

We should add a code path which, if WebGL's DrawingBuffer prefers to use GpuMemoryBuffers and premultipliedAlpha is set to false, renders into a regular texture and uses CopyTextureCHROMIUM to blit into the GpuMemoryBuffer, multiplying the alpha channel into the color channels on the way, and then give the GMB to the compositor.

ccameron@ indicated he could pick this up. (Thanks.)

 

Comment 1 by kbr@chromium.org, Nov 21 2017

Blockedon: 786945

Comment 2 by kbr@chromium.org, Nov 22 2017

Cc: ccameron@chromium.org
Owner: kbr@chromium.org
Taking from Chris as this change is needed in order to fix another bug on the Intel HD 5000.

Comment 3 by kbr@chromium.org, Jan 5 2018

Mergedinto: 786945
Status: Duplicate (was: Assigned)
At this point all of the work was done in  Issue 786945 . Duplicating into that bug.

Sign in to add a comment