New issue
Advanced search Search tips

Issue 786637 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 614164



Sign in to add a comment

merge commits fail to apply with 'Unknown cherry-pick exit code 128'

Project Member Reported by akes...@chromium.org, Nov 18 2017

Issue description

17:24:38: INFO: Transaction for akeshet:773826:ab9343fd is akeshet:773826:ab9343fd.                                                             [77/1881]
17:24:38: DEBUG: Attempting transaction for akeshet:773826:ab9343fd: changes: akeshet:773826:ab9343fd

STEP_LINK: akeshet:773826:ab9343fd; https://chromium-review.googlesource.com/#/c/773826/
17:24:38: INFO: Attempting to cherry-pick change akeshet:773826:ab9343fd:"Merge branch 'branchline2' into mergeline2"
17:24:38: DEBUG: ending retries with error: <class 'chromite.lib.cros_build_lib.RunCommandError'>(return code: 128; command: git rev-list -n1 patch_branc
h --
fatal: bad revision 'patch_branch'

cmd=['git', 'rev-list', '-n1', 'patch_branch', '--'], cwd=/usr/local/google/home/akeshet/tryjob/repository/infra/dummies/merge-sandbox)
error: commit ab9343fd23a5faaa5f95fd77396c3cc77af42015 is a merge but no -m option was given.
fatal: cherry-pick failed
17:24:38: DEBUG: ending retries with error: <class 'chromite.lib.cros_build_lib.RunCommandError'>(return code: 128; command: git cherry-pick --strategy r
esolve --ff ab9343fd23a5faaa5f95fd77396c3cc77af42015
cmd=['git', 'cherry-pick', '--strategy', 'resolve', '--ff', u'ab9343fd23a5faaa5f95fd77396c3cc77af42015'], cwd=/usr/local/google/home/akeshet/tryjob/repos
itory/infra/dummies/merge-sandbox)
17:24:38: ERROR: Unknown cherry-pick exit code 128; return code: 128; command: git cherry-pick --strategy resolve --ff ab9343fd23a5faaa5f95fd77396c3cc77a
f42015
cmd=['git', 'cherry-pick', '--strategy', 'resolve', '--ff', u'ab9343fd23a5faaa5f95fd77396c3cc77af42015'], cwd=/usr/local/google/home/akeshet/tryjob/repos
itory/infra/dummies/merge-sandbox
17:24:38: INFO: Rewinding transaction: failed changes: akeshet:773826:ab9343fd:"Merge branch 'branchline2' into mergeline2" .
Traceback (most recent call last):
  File "/usr/local/google/home/akeshet/tryjob/repository/chromite/cbuildbot/patch_series.py", line 941, in _Transaction
    yield
  File "/usr/local/google/home/akeshet/tryjob/repository/chromite/cbuildbot/patch_series.py", line 886, in Apply
    self._ApplyChanges(inducing_change, transaction_changes)
  File "/usr/local/google/home/akeshet/tryjob/repository/chromite/cbuildbot/patch_series.py", line 110, in f
    return functor(self, parent, *args, **kwargs)
  File "/usr/local/google/home/akeshet/tryjob/repository/chromite/cbuildbot/patch_series.py", line 976, in _ApplyChanges
    self.ApplyChange(change)
  File "/usr/local/google/home/akeshet/tryjob/repository/chromite/cbuildbot/stages/sync_stages.py", line 174, in ApplyChange
    return patch_series.PatchSeries.ApplyChange(self, change)
  File "/usr/local/google/home/akeshet/tryjob/repository/chromite/cbuildbot/patch_series.py", line 306, in f
    return functor(self, *args, **kwargs)
  File "/usr/local/google/home/akeshet/tryjob/repository/chromite/cbuildbot/patch_series.py", line 342, in ApplyChange
    return change.ApplyAgainstManifest(self.manifest, trivial=False)
  File "/usr/local/google/home/akeshet/tryjob/repository/chromite/lib/patch.py", line 1157, in ApplyAgainstManifest
    trivial=trivial)
  File "/usr/local/google/home/akeshet/tryjob/repository/chromite/lib/patch.py", line 1120, in Apply
    self.CherryPick(git_repo, trivial=trivial, inflight=inflight)
  File "/usr/local/google/home/akeshet/tryjob/repository/chromite/lib/patch.py", line 1038, in CherryPick
    'command: %s' % (ret, error)))
ApplyPatchException: CL:773826 conflicted with ToT.
 
Blocking: 614164
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/865f54981e3f8ac9cfad3d5dcf080ee4df7285b4

commit 865f54981e3f8ac9cfad3d5dcf080ee4df7285b4
Author: Aviv Keshet <akeshet@chromium.org>
Date: Tue Nov 21 02:13:34 2017

patch: add _GetParents method

BUG= chromium:786637 
TEST=Unit unittests added and pass

Change-Id: Ie5ab3f8b5246718c423bcb8dac9d36a12ec5cf08
Reviewed-on: https://chromium-review.googlesource.com/777951
Commit-Ready: Aviv Keshet <akeshet@chromium.org>
Tested-by: Aviv Keshet <akeshet@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>

[modify] https://crrev.com/865f54981e3f8ac9cfad3d5dcf080ee4df7285b4/lib/patch_unittest.py
[modify] https://crrev.com/865f54981e3f8ac9cfad3d5dcf080ee4df7285b4/lib/patch.py

Project Member

Comment 3 by bugdroid1@chromium.org, Nov 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/933b606c98d9228e6ba18a14e27397c4449fd650

commit 933b606c98d9228e6ba18a14e27397c4449fd650
Author: Aviv Keshet <akeshet@chromium.org>
Date: Tue Nov 21 02:13:35 2017

patch: rename PatchNotMergeable -> PatchNotSubmittable

The naming "Mergeable" is confusing in light of the fact that this
module will soon be dealing with Merge commits (which have nothing to do
with the concept of "Mergeable" meant here, = Submittable on gerrit).

BUG= chromium:786637 
TEST=None

Change-Id: I13d88786f25bd5e4e90afc99a3462e88b98bce0a
Reviewed-on: https://chromium-review.googlesource.com/778104
Commit-Ready: Aviv Keshet <akeshet@chromium.org>
Tested-by: Aviv Keshet <akeshet@chromium.org>
Reviewed-by: David James <davidjames@chromium.org>

[modify] https://crrev.com/933b606c98d9228e6ba18a14e27397c4449fd650/lib/patch.py

Project Member

Comment 4 by bugdroid1@chromium.org, Nov 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/24c4ef21444aa423173d91f5c7ab0d981dd3a820

commit 24c4ef21444aa423173d91f5c7ab0d981dd3a820
Author: Aviv Keshet <akeshet@chromium.org>
Date: Tue Nov 21 02:13:35 2017

patch: add _IsAncestorOf method

BUG= chromium:786637 
TEST=Unit unittests added and pass

Change-Id: I015039d83ead6a2583834a826c801ded6c30e15c
Reviewed-on: https://chromium-review.googlesource.com/779706
Commit-Ready: Aviv Keshet <akeshet@chromium.org>
Tested-by: Aviv Keshet <akeshet@chromium.org>
Reviewed-by: David James <davidjames@chromium.org>

[modify] https://crrev.com/24c4ef21444aa423173d91f5c7ab0d981dd3a820/lib/patch_unittest.py
[modify] https://crrev.com/24c4ef21444aa423173d91f5c7ab0d981dd3a820/lib/patch.py

Project Member

Comment 5 by bugdroid1@chromium.org, Nov 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/5655e23653da8531edeb10f6bf4d514ee9f8c930

commit 5655e23653da8531edeb10f6bf4d514ee9f8c930
Author: Aviv Keshet <akeshet@chromium.org>
Date: Tue Nov 21 09:59:10 2017

patch: factor out cherry-pick operation from Apply

In the future, Apply will decide whether to use cherry-pick (for most
changes) or merge (for merge commits) when applying a change.

BUG= chromium:786637 
TEST=`cros tryjob --local -g '774359 777984' --notests
lumpy-paladin-tryjob --pass-through=--test-bootstrap` -> saw that patch
was applied correctly, and with new logging

Change-Id: I79497ac03979d88f1486e21c3e4f314c2b727656
Reviewed-on: https://chromium-review.googlesource.com/777984
Commit-Ready: Aviv Keshet <akeshet@chromium.org>
Tested-by: Aviv Keshet <akeshet@chromium.org>
Reviewed-by: David James <davidjames@chromium.org>

[modify] https://crrev.com/5655e23653da8531edeb10f6bf4d514ee9f8c930/lib/patch.py

Project Member

Comment 6 by bugdroid1@chromium.org, Nov 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/f2f97a44d7509c6b8113de741c7d32ea93cfb9da

commit f2f97a44d7509c6b8113de741c7d32ea93cfb9da
Author: Aviv Keshet <akeshet@chromium.org>
Date: Tue Nov 28 21:34:27 2017

patch: support Merge for applying a commit

BUG= chromium:786637 
TEST=local tryjob with --test-bootstrap

Change-Id: I8f97e7b2d161dc9cfebf8a39938c0445c3139767
Reviewed-on: https://chromium-review.googlesource.com/786085
Commit-Ready: Aviv Keshet <akeshet@chromium.org>
Tested-by: Aviv Keshet <akeshet@chromium.org>
Reviewed-by: David James <davidjames@chromium.org>

[modify] https://crrev.com/f2f97a44d7509c6b8113de741c7d32ea93cfb9da/lib/patch_unittest.py
[modify] https://crrev.com/f2f97a44d7509c6b8113de741c7d32ea93cfb9da/lib/patch.py

Status: Fixed (was: Started)

Sign in to add a comment