New issue
Advanced search Search tips

Issue 786625 link

Starred by 1 user
Status: Fixed
Owner:
yuweih@chromium.org
Closed: Dec 2017
Cc:
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

[CRD iOS] Fixing open source variant app menu

Project Member Reported by yuweih@chromium.org, Nov 18 2017 
Currently the app menu can only request access code and sign out. We should also show items in SideMenuItemsProvider, e.g. Toggling WebRTC (in debug build) and help center.

This can make it easier for dev to work on CRD iOS without checking out internal iOS deps.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5de6f5ff5dce8805c3bd8986e8c87f8af204a695

commit 5de6f5ff5dce8805c3bd8986e8c87f8af204a695
Author: Yuwei Huang <yuweih@chromium.org>
Date: Tue Nov 28 21:52:13 2017

[CRD iOS] Updating the side menu of the open source variant

This CL updates the open source implementation of the side menu so that
it also shows items from SideMenuItemsProvider. This make it easier for
developer to debug CRD for iOS on Chromium without checking out
ios_internal.

Bug:  786625 
Change-Id: I784032e905cfdd78eeef122f302f464b443d2153
Reviewed-on: https://chromium-review.googlesource.com/780151
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519859}
[modify] https://crrev.com/5de6f5ff5dce8805c3bd8986e8c87f8af204a695/remoting/ios/app/help_and_feedback.mm
[modify] https://crrev.com/5de6f5ff5dce8805c3bd8986e8c87f8af204a695/remoting/ios/app/remoting_menu_view_controller.mm
[modify] https://crrev.com/5de6f5ff5dce8805c3bd8986e8c87f8af204a695/remoting/ios/app/side_menu_items.h
[modify] https://crrev.com/5de6f5ff5dce8805c3bd8986e8c87f8af204a695/remoting/ios/app/side_menu_items.mm

Comment 2 by yuweih@chromium.org, Dec 5 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment