New issue
Advanced search Search tips

Issue 786621 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 0
Type: Bug-Regression
Team-Accessibility

Blocking:
issue 773851



Sign in to add a comment

DumpAccessibilityEventsTest.AccessibilityEventsLiveRegionRemove failing on Windows

Project Member Reported by kbr@chromium.org, Nov 18 2017

Issue description

Failing all over this tryserver:
https://ci.chromium.org/buildbot/tryserver.chromium.win/win10_chromium_x64_rel_ng/?limit=200

Just one example failure:
https://ci.chromium.org/buildbot/tryserver.chromium.win/win10_chromium_x64_rel_ng/29792

This is causing nearly every job to be retried. This is an emergency and must be fixed immediately.

Log excerpt follows.

[ RUN      ] DumpAccessibilityEventsTest.AccessibilityEventsLiveRegionRemove
[3352:4000:1117/162004.983:ERROR:instance.cc(49)] Unable to locate service manifest for metrics
[3352:4000:1117/162004.983:ERROR:service_manager.cc(889)] Failed to resolve service name: metrics
DevTools listening on ws://127.0.0.1:58303/devtools/browser/8e2a8fad-a3ea-46e6-91fa-c0500491f8e1
[4932:4088:1117/162005.169:INFO:dxva_video_decode_accelerator_win.cc(1295)] mf.dll is required for hardware video decoding
[4932:4088:1117/162005.169:INFO:media_foundation_video_encode_accelerator_win.cc(376)] mf.dll is required for encoding
[3352:4000:1117/162005.170:ERROR:instance.cc(49)] Unable to locate service manifest for metrics
[3352:4000:1117/162005.170:ERROR:service_manager.cc(889)] Failed to resolve service name: metrics
[3352:5048:1117/162005.347:INFO:dump_accessibility_browsertest_base.cc(225)] File not found: C:\b\s\w\ir\content\test\data\accessibility\event\live-region-remove-expected-blink.txt
[3352:5048:1117/162005.347:INFO:dump_accessibility_browsertest_base.cc(226)] No expectation file present, ignoring test on this platform. To run this test anyway, create C:\b\s\w\ir\content\test\data\accessibility\event\live-region-remove-expected-blink.txt (it can be empty) and then run content_browsertests with the switch: --generate-accessibility-test-expectations
[3352:5048:1117/162005.362:INFO:dump_accessibility_browsertest_base.cc(240)] Testing: C:/b/s/w/ir/content/test/data/accessibility/event/live-region-remove.html
[3352:5048:1117/162005.362:INFO:dump_accessibility_browsertest_base.cc(242)] Expected output: C:/b/s/w/ir/content/test/data/accessibility/event/live-region-remove-expected-win.txt
../../content/browser/accessibility/dump_accessibility_browsertest_base.cc(371): error: Value of: is_different
  Actual: true
Expected: false
Initial accessibility tree (after load complete):
ROLE_SYSTEM_DOCUMENT parent='ROLE_SYSTEM_WINDOW' window_class='Chrome_RenderWidgetHostHWND' value='http://127.0.0.1:58304/accessibility/event/live-region-remove.html' FOCUSED READONLY FOCUSABLE tag:#document offset:0 auto-generated:false background-color:rgb(255\,255\,255) color:rgb(0\,0\,0) font-family:Times New Roman font-size:12pt font-style:normal font-weight:normal invalid:false language:en-US text-line-through-mode:continuous text-line-through-style:none text-line-through-text: text-line-through-type:none text-line-through-width:auto text-outline:false text-position:baseline text-shadow:none text-underline-mode:continuous text-underline-style:none text-underline-type:none text-underline-width:auto writing-mode:lr ia2_hypertext='<obj0>' location=(0, 0) size=(800, 600) n_relations=0 n_characters=1 n_selections=0
++IA2_ROLE_SECTION parent='ROLE_SYSTEM_DOCUMENT' window_class='Chrome_RenderWidgetHostHWND' display:block tag:div live:polite relevant:additions text atomic:false container-live:polite container-relevant:additions text container-atomic:false container-busy:false id:live offset:0 auto-generated:false background-color:rgb(255\,255\,255) color:rgb(0\,0\,0) font-family:Times New Roman font-size:12pt font-style:normal font-weight:normal invalid:false language:en-US text-line-through-mode:continuous text-line-through-style:none text-line-through-text: text-line-through-type:none text-line-through-width:auto text-outline:false text-position:baseline text-shadow:none text-underline-mode:continuous text-underline-style:none text-underline-type:none text-underline-width:auto writing-mode:lr ia2_hypertext='<obj0>' location=(8, 16) size=(784, 18) index_in_parent=0 n_relations=0 n_characters=1 n_selections=0
++++IA2_ROLE_PARAGRAPH parent='DIV' window_class='Chrome_RenderWidgetHostHWND' display:block tag:p relevant:additions text atomic:false container-live:polite container-relevant:additions text container-atomic:false container-busy:false id:p offset:0 auto-generated:false background-color:rgb(255\,255\,255) color:rgb(0\,0\,0) font-family:Times New Roman font-size:12pt font-style:normal font-weight:normal invalid:false language:en-US text-line-through-mode:continuous text-line-through-style:none text-line-through-text: text-line-through-type:none text-line-through-width:auto text-outline:false text-position:baseline text-shadow:none text-underline-mode:continuous text-underline-style:none text-underline-type:none text-underline-width:auto writing-mode:lr ia2_hypertext='Before' location=(8, 16) size=(784, 18) index_in_parent=0 n_relations=0 n_characters=6 n_selections=0
++++++ROLE_SYSTEM_STATICTEXT name='Before' parent='P' window_class='Chrome_RenderWidgetHostHWND' display:block relevant:additions text atomic:false container-live:polite container-relevant:additions text container-atomic:false container-busy:false offset:0 auto-generated:false background-color:rgb(255\,255\,255) color:rgb(0\,0\,0) font-family:Times New Roman font-size:12pt font-style:normal font-weight:normal invalid:false language:en-US text-line-through-mode:continuous text-line-through-style:none text-line-through-text: text-line-through-type:none text-line-through-width:auto text-outline:false text-position:baseline text-shadow:none text-underline-mode:continuous text-underline-style:none text-underline-type:none text-underline-width:auto writing-mode:lr ia2_hypertext='Before' location=(8, 16) size=(44, 17) index_in_parent=0 n_relations=0 n_characters=6 n_selections=0
Final accessibility tree after events fired:
ROLE_SYSTEM_DOCUMENT parent='ROLE_SYSTEM_WINDOW' window_class='Chrome_RenderWidgetHostHWND' value='http://127.0.0.1:58304/accessibility/event/live-region-remove.html' FOCUSED READONLY FOCUSABLE tag:#document offset:0 auto-generated:false background-color:rgb(255\,255\,255) color:rgb(0\,0\,0) font-family:Times New Roman font-size:12pt font-style:normal font-weight:normal invalid:false language:en-US text-line-through-mode:continuous text-line-through-style:none text-line-through-text: text-lin[3352:5048:1117/162005.408:ERROR:dump_accessibility_browsertest_base.cc(396)] Diff:
* Line Expected
- ---- --------
     1 EVENT_OBJECT_HIDE on role=P
*    2 EVENT_OBJECT_STATECHANGE on role=DIV
*    3 IA2_EVENT_TEXT_REMOVED on role=DIV old_text={'<obj>' start=0 end=1}
*    4 EVENT_OBJECT_REORDER on role=DIV
*    5 EVENT_OBJECT_LIVEREGIONCHANGED on role=DIV
     6 <-- End-of-file -->
Actual
------
EVENT_OBJECT_HIDE on role=P
IA2_EVENT_TEXT_REMOVED on role=DIV old_text={'<obj>' start=0 end=1}
EVENT_OBJECT_REORDER on role=DIV
EVENT_OBJECT_LIVEREGIONCHANGED on role=DIV
<-- End-of-file -->
e-through-type:none text-line-through-width:auto text-outline:false text-position:baseline text-shadow:none text-underline-mode:continuous text-underline-style:none text-underline-type:none text-underline-width:auto writing-mode:lr ia2_hypertext='<obj0>' location=(0, 0) size=(800, 600) n_relations=0 n_characters=1 n_selections=0
++IA2_ROLE_SECTION parent='ROLE_SYSTEM_DOCUMENT' window_class='Chrome_RenderWidgetHostHWND' display:block tag:div live:polite relevant:additions text atomic:false container-live:polite container-relevant:additions text container-atomic:false container-busy:false id:live location=(8, 8) size=(784, 0) index_in_parent=0 n_relations=0 n_characters=0 n_selections=0
[  FAILED  ] DumpAccessibilityEventsTest.AccessibilityEventsLiveRegionRemove, where TypeParam =  and GetParam() =  (460 ms)

 

Comment 2 by kbr@chromium.org, Nov 18 2017

Summary: DumpAccessibilityEventsTest.AccessibilityEventsLiveRegionRemove failing on win10_chromium_x64_rel_ng and win7_chromium_rel_ng (was: DumpAccessibilityEventsTest.AccessibilityEventsLiveRegionRemove failing on win10_chromium_x64_rel_ng )
Summary: DumpAccessibilityEventsTest.AccessibilityEventsLiveRegionRemove failing on Windows (was: DumpAccessibilityEventsTest.AccessibilityEventsLiveRegionRemove failing on win10_chromium_x64_rel_ng and win7_chromium_rel_ng)
Note that this is a consistent failure on multiple bots on chromium.win, as well, and is visible in sheriff-o-matic as such.

First failures on affected builders:
 - https://luci-milo.appspot.com/buildbot/chromium.win/Win10%20Tests%20x64/17912
 - https://luci-milo.appspot.com/buildbot/chromium.win/Win7%20Tests%20%281%29/73515
 - https://luci-milo.appspot.com/buildbot/chromium.win/Win%207%20Tests%20x64%20%281%29/31121
 - https://luci-milo.appspot.com/buildbot/chromium.win/Win7%20Tests%20%28dbg%29%281%29/64697
two a11y CLs landed within the same minute yesterday and jump out as possible culprits:

 - https://chromium.googlesource.com/chromium/src/+/59b5d9892707371b36827670cb5eeb66fa932fc2
 - https://chromium.googlesource.com/chromium/src/+/a8671260ecea052b2abf090750d07035808d9665

I'm going to upload reverts of each and see how the trybots react.
From the trybots, https://chromium.googlesource.com/chromium/src/+/a8671260ecea052b2abf090750d07035808d9665 appears to be the culprit. Reverting it.
Cc: katie@chromium.org
Owner: jbudorick@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 8 by bugdroid1@chromium.org, Nov 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6b28e6efc7326aecefe34788525d97427903ef08

commit 6b28e6efc7326aecefe34788525d97427903ef08
Author: John Budorick <jbudorick@chromium.org>
Date: Sat Nov 18 20:30:50 2017

Revert "Elements with no size are offscreen only if outside the screen."

This reverts commit a8671260ecea052b2abf090750d07035808d9665.

TBR=katydek@google.com,dmazzoni@chromium.org

Bug:  786621 
Change-Id: I5429cafee92658626e826dd998404c3edc25918f
Reviewed-on: https://chromium-review.googlesource.com/778131
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517721}
[modify] https://crrev.com/6b28e6efc7326aecefe34788525d97427903ef08/content/browser/accessibility/dump_accessibility_tree_browsertest.cc
[modify] https://crrev.com/6b28e6efc7326aecefe34788525d97427903ef08/content/test/data/accessibility/html/bounds-clips-expected-blink.txt
[modify] https://crrev.com/6b28e6efc7326aecefe34788525d97427903ef08/content/test/data/accessibility/html/bounds-inherits-expected-blink.txt
[modify] https://crrev.com/6b28e6efc7326aecefe34788525d97427903ef08/content/test/data/accessibility/html/br-expected-android.txt
[delete] https://crrev.com/2637a04e9f9c8f01b3898db9984e4ee54a5c3956/content/test/data/accessibility/html/br-expected-blink.txt
[modify] https://crrev.com/6b28e6efc7326aecefe34788525d97427903ef08/content/test/data/accessibility/html/br-expected-win.txt
[modify] https://crrev.com/6b28e6efc7326aecefe34788525d97427903ef08/content/test/data/accessibility/html/br.html
[modify] https://crrev.com/6b28e6efc7326aecefe34788525d97427903ef08/ui/accessibility/ax_tree.cc
[modify] https://crrev.com/6b28e6efc7326aecefe34788525d97427903ef08/ui/accessibility/ax_tree_unittest.cc

Cc: st...@chromium.org
I didn't see this earlier, but FindIt recognized this yesterday: https://chromium-review.googlesource.com/c/chromium/src/+/772900#message-70a8b2e5d817b314b8de5a8d56a58e8def476eb0

+stgao fyi
Status: Fixed (was: Started)
windows bots rolling green.

Comment 11 by st...@chromium.org, Nov 19 2017

Did Findit's result show up in Sheriff-o-Matic? If not, were there test data for that failed step?

We'd better enable auto-revert for test failures asap. That's a P0 task for Q1.
I'm not sure, unfortunately. It's been a little while since I've sheriffed, so I didn't realize FindIt's result was supposed to show up there & didn't check :(

Comment 13 by st...@chromium.org, Nov 19 2017

No worries, just tried to collect more info on this :)
I asked because you mentioned sheriff-o-matic above.

Comment 14 by kbr@chromium.org, Nov 20 2017

Blocking: 773851
Thank you John for working on a weekend and clearing this up.

Comment 15 by st...@chromium.org, Nov 20 2017

Cc: chanli@chromium.org
+chanli for this case as an incentive to enable auto-revert for reliable test failures

Sign in to add a comment