This bug tracks TODO's in remoting/ios
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6316b52f3c69089f7b755e3d4729271f43337655 commit 6316b52f3c69089f7b755e3d4729271f43337655 Author: Yuwei Huang <yuweih@chromium.org> Date: Tue Nov 21 20:28:42 2017 [CRD iOS] Cleaning up dead code These code are no longer used and can be removed. Bug: 786616 Change-Id: I81782e7935026d36c9d3207da4db11c80057e3bf Reviewed-on: https://chromium-review.googlesource.com/780585 Reviewed-by: Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#518365} [modify] https://crrev.com/6316b52f3c69089f7b755e3d4729271f43337655/remoting/ios/app/remoting_view_controller.mm [modify] https://crrev.com/6316b52f3c69089f7b755e3d4729271f43337655/remoting/ios/domain/host_info.h [modify] https://crrev.com/6316b52f3c69089f7b755e3d4729271f43337655/remoting/ios/domain/host_info.mm [modify] https://crrev.com/6316b52f3c69089f7b755e3d4729271f43337655/remoting/ios/domain/user_info.h [modify] https://crrev.com/6316b52f3c69089f7b755e3d4729271f43337655/remoting/ios/domain/user_info.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/202cd8eac0ec3e37db4fdf5efeef19ab349531c2 commit 202cd8eac0ec3e37db4fdf5efeef19ab349531c2 Author: Yuwei Huang <yuweih@chromium.org> Date: Wed Nov 29 00:16:16 2017 [CRD iOS] Fixing/updating obsolete TODOs This CL fixes/updates obsolete TODOs in remoting/ios, along with some other small cleanups nearby. Bug: 786616 Change-Id: I29b5e41a6dabb2f314a6e4fadc3fa443d1a55328 Reviewed-on: https://chromium-review.googlesource.com/783663 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by: Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#519920} [modify] https://crrev.com/202cd8eac0ec3e37db4fdf5efeef19ab349531c2/remoting/ios/app/app_delegate.h [modify] https://crrev.com/202cd8eac0ec3e37db4fdf5efeef19ab349531c2/remoting/ios/app/app_delegate.mm [modify] https://crrev.com/202cd8eac0ec3e37db4fdf5efeef19ab349531c2/remoting/ios/app/client_connection_view_controller.mm [modify] https://crrev.com/202cd8eac0ec3e37db4fdf5efeef19ab349531c2/remoting/ios/app/host_view_controller.mm [modify] https://crrev.com/202cd8eac0ec3e37db4fdf5efeef19ab349531c2/remoting/ios/app/remoting_theme.h [modify] https://crrev.com/202cd8eac0ec3e37db4fdf5efeef19ab349531c2/remoting/ios/app/remoting_theme.mm [modify] https://crrev.com/202cd8eac0ec3e37db4fdf5efeef19ab349531c2/remoting/ios/app/resources/BUILD.gn [modify] https://crrev.com/202cd8eac0ec3e37db4fdf5efeef19ab349531c2/remoting/ios/app/settings/remoting_settings_view_controller.mm [modify] https://crrev.com/202cd8eac0ec3e37db4fdf5efeef19ab349531c2/remoting/ios/domain/user_info.h [modify] https://crrev.com/202cd8eac0ec3e37db4fdf5efeef19ab349531c2/remoting/ios/facade/remoting_oauth_authentication.mm [modify] https://crrev.com/202cd8eac0ec3e37db4fdf5efeef19ab349531c2/remoting/ios/facade/remoting_service.mm [modify] https://crrev.com/202cd8eac0ec3e37db4fdf5efeef19ab349531c2/remoting/ios/keychain_wrapper.h [modify] https://crrev.com/202cd8eac0ec3e37db4fdf5efeef19ab349531c2/remoting/ios/session/remoting_client.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/98395388ba6d2078603323509deb71a556db2815 commit 98395388ba6d2078603323509deb71a556db2815 Author: Yuwei Huang <yuweih@chromium.org> Date: Mon Dec 04 22:28:18 2017 [CRD iOS] Fixing setting menu style (M65) According to the mock, separators should go between sections, not items. This CL fixes the style according to the mock. Given that this changes the UI of the app, it might be better to check in this after the M64 branch point. Before: https://drive.google.com/a/google.com/file/d/1cosHV0dLNdIraqZCQhE0M0La9b6fDn6B/view?usp=sharing After: https://drive.google.com/a/google.com/file/d/1s_ZtlUMztnkr-QdU1-04ssxw-m2iLXHH/view?usp=sharing Bug: 786616 Change-Id: If4975398b7fd0da0a0884ee4b009c3098f05de42 Reviewed-on: https://chromium-review.googlesource.com/783817 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by: Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#521488} [modify] https://crrev.com/98395388ba6d2078603323509deb71a556db2815/remoting/ios/app/remoting_theme.h [modify] https://crrev.com/98395388ba6d2078603323509deb71a556db2815/remoting/ios/app/remoting_theme.mm [modify] https://crrev.com/98395388ba6d2078603323509deb71a556db2815/remoting/ios/app/settings/remoting_settings_view_controller.mm
Comment 1 by bugdroid1@chromium.org
, Nov 21 2017