New issue
Advanced search Search tips

Issue 786598 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

NetworkService: missing initiator in the URLRequest from URLLoader

Project Member Reported by qin...@chromium.org, Nov 17 2017

Issue description

seems this is never get set.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8176fd9dfe1fc66c03052aeb8fc935fb095729b0

commit 8176fd9dfe1fc66c03052aeb8fc935fb095729b0
Author: Min Qin <qinmin@chromium.org>
Date: Mon Nov 20 18:21:06 2017

Network Service: Set the initiator before starting URLRequest

The initiator is used for checking cookies.
And it is mising from the URLRequest when URLLoader is used.
For example, DownloadContentTest.DownloadAttributeSameOriginRedirect will redirect
a link click to a download with a different origin.
Download should pass the initiator in the URLRequest,
but missing it causes the wrong cookie to be passed.
This CL sets the intiator in the URLRequest so the above test can partially work.

BUG= 786598 

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I4efffd41fc9ca26063d853ce03e7c7ff817a917c
Reviewed-on: https://chromium-review.googlesource.com/777552
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517864}
[modify] https://crrev.com/8176fd9dfe1fc66c03052aeb8fc935fb095729b0/content/network/url_loader.cc

Comment 2 by qin...@chromium.org, Nov 20 2017

Status: Fixed (was: Assigned)

Sign in to add a comment