New issue
Advanced search Search tips

Issue 786596 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

4.6%-11.8% regression in loading.desktop at 516657:516750

Project Member Reported by benhenry@google.com, Nov 17 2017

Issue description

there was a perf sheriff.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Nov 17 2017

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=786596

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=88f801b9538aab7c473675123044994927c20c55f1590b4c80e361262a4e0c1c


Bot(s) for this bug's original alert(s):

chromium-rel-mac-retina
chromium-rel-mac11-pro
linux-release
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Nov 18 2017

Cc: drott@chromium.org e...@chromium.org
Owner: drott@chromium.org
Status: Assigned (was: Untriaged)
📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/14b0aad5f80000

Move OpenTypeVerticalData off of SimpleFontData
By drott@chromium.org · Wed Nov 15 14:22:40 2017
chromium @ 45424ca29a623cba7f167cc1ca1651adcd291540

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c0ce7ee036e8b06de2d64bf1e91c00dedf63e447

commit c0ce7ee036e8b06de2d64bf1e91c00dedf63e447
Author: Dominik Röttsches <drott@chromium.org>
Date: Tue Nov 21 04:47:33 2017

Avoid recomputing fallback values for vertical metrics

In https://chromium-review.googlesource.com/#/c/768822/
OpenTypeVerticalData was moved off of SimpleFontData. In order to
compute OpenTypeVerticalData lazily when needed for vertical layout,
fallback metrics ascent, height and size_per_unit need to be
available. This CL triggered two reports of performance regressions
(bugs below). I suspect these stem from a higher overhead in computing
these fallback metrics for every shaping operation. This CL reduces
computing the fallback metrics to situations in which they are needed
because the run's direction is vertical.

Somewhat speculative fix for the bugs below as it is hard to meaure
locally without noise. However, the amount of fallback metrics
recomputation for non-vertical layout pages was reduced from tens of
thousands to zero.

Bug:  786596 ,  786583 
Change-Id: I5b667b3aab4b6346d519768e62f17187905bf090
Reviewed-on: https://chromium-review.googlesource.com/779426
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518119}
[modify] https://crrev.com/c0ce7ee036e8b06de2d64bf1e91c00dedf63e447/third_party/WebKit/Source/platform/fonts/FontPlatformData.cpp
[modify] https://crrev.com/c0ce7ee036e8b06de2d64bf1e91c00dedf63e447/third_party/WebKit/Source/platform/fonts/opentype/OpenTypeCapsSupportMPL.cpp
[modify] https://crrev.com/c0ce7ee036e8b06de2d64bf1e91c00dedf63e447/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzFace.cpp
[modify] https://crrev.com/c0ce7ee036e8b06de2d64bf1e91c00dedf63e447/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzFace.h
[modify] https://crrev.com/c0ce7ee036e8b06de2d64bf1e91c00dedf63e447/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzFontCache.h
[modify] https://crrev.com/c0ce7ee036e8b06de2d64bf1e91c00dedf63e447/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.cpp

Comment 5 by drott@chromium.org, Nov 21 2017

Cc: -drott@chromium.org kojii@chromium.org
Status: Fixed (was: Assigned)
Graphs have recovered, marking as fixed.

Comment 6 by drott@chromium.org, Nov 21 2017

Cc: drott@chromium.org hjd@google.com
 Issue 787412  has been merged into this issue.

Sign in to add a comment