New issue
Advanced search Search tips

Issue 786590 link

Starred by 2 users
Status: Verified
Owner:
sammiequon@chromium.org
Closed: Nov 2017
Cc:
xiy...@chromium.org
mkarkada@chromium.org
dhadd...@chromium.org
abod...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Stylus welcome dialog pops up during sign-in flow

Project Member Reported by sdantul...@chromium.org, Nov 17 2017 
Google Chrome	64.0.3270.0 (Official Build) dev (64-bit)
Revision	0
Platform	10137.0.0 (Official Build) dev-channel eve

What steps will reproduce the problem?
1. On sign-in screen, click on 'Add person'
2. Enter username and password and click Next
3. ARC++ opt-in screen is displayed

What happens ?
Stylus welcome dialog pops up on ARC++ opt-in screen. Attached screenshot.

What is expected?
Stylus welcome dialog should be displayed only after sign-in flow is complete.
IMG_2207.jpg
1.8 MB View Download

Comment 1 by xiy...@chromium.org, Nov 17 2017 

PaletteTray should wait for session state change to active in addition to OnActiveUserPrefServiceChanged. User PrefService is requested when user session is added to ash [1] and it is independent of session state change. The screenshot is at SessionState::LOGGED_IN_NOT_ACTIVE and could last arbitrarily long. Only SessionState::ACTIVE means that ash is landed on user desktop.

[1] https://cs.chromium.org/chromium/src/ash/session/session_controller.cc?rcl=a30f64b4ae13255535a4947616fce484c54207df&l=495

Comment 2 by sammiequon@chromium.org, Nov 20 2017

Cc: -sammiequon@chromium.org
Owner: sammiequon@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 30 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f1b13367b1f66174ff93a174ffddb9b67b10dd1c

commit f1b13367b1f66174ff93a174ffddb9b67b10dd1c
Author: Sammie Quon <sammiequon@google.com>
Date: Thu Nov 30 16:43:44 2017

palette: Do not show welcome bubble if guest mode or not in active state.

Originally tries to show bubble when the pref service (user) changes.
Added checks in PaletteWelcomeBubble::ShowIfNeeded to check for the
two cases where the bubble is not wanted. PaletteTray tries to show the
bubble again when the session state changes.

Test: ash_unittests PaletteWelcomeBubbleTest.*
Bug:  786418 ,  786590 
Change-Id: I0695a83383ce6c9d79f8d8f6dfda2eab0fb37071
Reviewed-on: https://chromium-review.googlesource.com/780841
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520575}
[modify] https://crrev.com/f1b13367b1f66174ff93a174ffddb9b67b10dd1c/ash/system/palette/palette_tray.cc
[modify] https://crrev.com/f1b13367b1f66174ff93a174ffddb9b67b10dd1c/ash/system/palette/palette_welcome_bubble.cc
[modify] https://crrev.com/f1b13367b1f66174ff93a174ffddb9b67b10dd1c/ash/system/palette/palette_welcome_bubble_unittest.cc

Comment 4 by sammiequon@chromium.org, Nov 30 2017

Status: Fixed (was: Assigned)

Comment 5 by sammiequon@chromium.org, Dec 6 2017 

Issue 792561 has been merged into this issue.

Comment 6 by sdantul...@chromium.org, Feb 14 2018

Status: Verified (was: Fixed)
10323.30.0, 65.0.3325.65
►

Sign in to add a comment