New issue
Advanced search Search tips

Issue 786584 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Rename CTVerifyResult's cert_policy_compliance

Project Member Reported by est...@chromium.org, Nov 17 2017

Issue description

The name |cert_policy_compliance| is a holdover from when there was an EV CT policy. Now that that's gone, we could rename this field to |policy_compliance| to be more clear.
 

Comment 2 by est...@chromium.org, Nov 17 2017

We probably also want to rename SSLInfo's ct_cert_policy_compliance while we're at it.
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/627238f515206f402846d1f65b20fb816743e8c5

commit 627238f515206f402846d1f65b20fb816743e8c5
Author: Emily Stark <estark@google.com>
Date: Wed Nov 29 03:29:54 2017

Rename things to get rid of CT "cert policy" concept

We used to have a CT certificate policy and a CT EV policy (the distinction was
that the latter used a whitelist). Now there's just one CT policy, so this CL
renames the following things:
- SSLInfo::ct_cert_policy_compliance => ct_policy_compliance
- CTVerifyResult::cert_policy_compliance => policy_compliance
- net::ct::CertPolicyCompliance => net::ct::CTPolicyCompliance and its values
  from CERT_POLICY_BLAH to CT_POLICY_BLAH

The renames are in net/ssl/ssl_info.h, net/cert/ct_verify_result.h, and
net/cert/ct_policy_status.h, and the rest of the change is mechanical.

Bug:  786584 
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Id78d1b55e143ee50b3221ea92c3acfa47c9bb76d
Reviewed-on: https://chromium-review.googlesource.com/788172
Commit-Queue: Emily Stark <estark@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Reviewed-by: Misha Efimov <mef@chromium.org>
Reviewed-by: Gary Kacmarcik <garykac@chromium.org>
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519987}
[modify] https://crrev.com/627238f515206f402846d1f65b20fb816743e8c5/chromecast/browser/url_request_context_factory.cc
[modify] https://crrev.com/627238f515206f402846d1f65b20fb816743e8c5/components/cronet/url_request_context_config.cc
[modify] https://crrev.com/627238f515206f402846d1f65b20fb816743e8c5/content/common/common_param_traits_unittest.cc
[modify] https://crrev.com/627238f515206f402846d1f65b20fb816743e8c5/content/common/resource_messages.cc
[modify] https://crrev.com/627238f515206f402846d1f65b20fb816743e8c5/content/common/resource_messages.h
[modify] https://crrev.com/627238f515206f402846d1f65b20fb816743e8c5/content/shell/browser/shell_url_request_context_getter.cc
[modify] https://crrev.com/627238f515206f402846d1f65b20fb816743e8c5/net/cert/ct_policy_enforcer.cc
[modify] https://crrev.com/627238f515206f402846d1f65b20fb816743e8c5/net/cert/ct_policy_enforcer.h
[modify] https://crrev.com/627238f515206f402846d1f65b20fb816743e8c5/net/cert/ct_policy_enforcer_unittest.cc
[modify] https://crrev.com/627238f515206f402846d1f65b20fb816743e8c5/net/cert/ct_policy_status.h
[modify] https://crrev.com/627238f515206f402846d1f65b20fb816743e8c5/net/cert/ct_verify_result.cc
[modify] https://crrev.com/627238f515206f402846d1f65b20fb816743e8c5/net/cert/ct_verify_result.h
[modify] https://crrev.com/627238f515206f402846d1f65b20fb816743e8c5/net/http/transport_security_state.cc
[modify] https://crrev.com/627238f515206f402846d1f65b20fb816743e8c5/net/http/transport_security_state.h
[modify] https://crrev.com/627238f515206f402846d1f65b20fb816743e8c5/net/http/transport_security_state_unittest.cc
[modify] https://crrev.com/627238f515206f402846d1f65b20fb816743e8c5/net/quic/chromium/crypto/proof_verifier_chromium.cc
[modify] https://crrev.com/627238f515206f402846d1f65b20fb816743e8c5/net/quic/chromium/crypto/proof_verifier_chromium_test.cc
[modify] https://crrev.com/627238f515206f402846d1f65b20fb816743e8c5/net/socket/ssl_client_socket_impl.cc
[modify] https://crrev.com/627238f515206f402846d1f65b20fb816743e8c5/net/socket/ssl_client_socket_unittest.cc
[modify] https://crrev.com/627238f515206f402846d1f65b20fb816743e8c5/net/socket/ssl_server_socket_unittest.cc
[modify] https://crrev.com/627238f515206f402846d1f65b20fb816743e8c5/net/spdy/chromium/spdy_session.cc
[modify] https://crrev.com/627238f515206f402846d1f65b20fb816743e8c5/net/spdy/chromium/spdy_session_unittest.cc
[modify] https://crrev.com/627238f515206f402846d1f65b20fb816743e8c5/net/spdy/chromium/spdy_test_util_common.cc
[modify] https://crrev.com/627238f515206f402846d1f65b20fb816743e8c5/net/ssl/ssl_info.cc
[modify] https://crrev.com/627238f515206f402846d1f65b20fb816743e8c5/net/ssl/ssl_info.h
[modify] https://crrev.com/627238f515206f402846d1f65b20fb816743e8c5/net/url_request/url_request_http_job.cc
[modify] https://crrev.com/627238f515206f402846d1f65b20fb816743e8c5/net/url_request/url_request_http_job_unittest.cc
[modify] https://crrev.com/627238f515206f402846d1f65b20fb816743e8c5/net/url_request/url_request_unittest.cc
[modify] https://crrev.com/627238f515206f402846d1f65b20fb816743e8c5/remoting/protocol/ssl_hmac_channel_authenticator.cc

Comment 4 by est...@chromium.org, Nov 29 2017

Labels: M-64
Status: Fixed (was: Assigned)

Sign in to add a comment