New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 786572 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
OOO until 2019-01-24
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Feature

Blocked on:
issue 785392
issue 786138
issue 814087

Blocking:
issue 848814



Sign in to add a comment

Put a Nexus 5X bot on the chromium.gpu waterfall, run its tests on android_n5x_swarming_rel

Project Member Reported by kbr@chromium.org, Nov 17 2017

Issue description

Thanks to ynovikov's work getting this bot green and stable:
https://ci.chromium.org/buildbot/chromium.gpu.fyi/Android%20Release%20%28Nexus%205X%29/

it's time to deploy a similar configuration onto the chromium.gpu waterfall, and run GPU tests against all try jobs going through android_n5x_swarming_rel.

There is enough capacity according to the dashboard just added to:
https://www.chromium.org/developers/how-tos/gpu-wrangling#TOC-Fleet-Status

and there's enough risk in not running pixel tests and other tests all the time on Android (see  Issue 785392 ) that it's time to start verifying that these tests don't break.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/9183dae745ae76e4d808469c4c7ee20ffecbe3ab

commit 9183dae745ae76e4d808469c4c7ee20ffecbe3ab
Author: Kenneth Russell <kbr@chromium.org>
Date: Fri Nov 17 23:17:11 2017

Deploy Android Release (Nexus 5X) on chromium.gpu.

This is effectively the promotion of this bot from the
chromium.gpu.fyi waterfall to the stable waterfall. Once it's shown to
be green, android_n5x_swarming_rel will be changed to mirror this bot
as well.

BUG= 786572 
TBR=dpranke@chromium.org, ynovikov@chromium.org

Change-Id: I996791235e27b50a5a60023c1155ff8b6a080953
Reviewed-on: https://chromium-review.googlesource.com/777942
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>

[modify] https://crrev.com/9183dae745ae76e4d808469c4c7ee20ffecbe3ab/tests/masters_recipes_test.py
[modify] https://crrev.com/9183dae745ae76e4d808469c4c7ee20ffecbe3ab/masters/master.chromium.gpu/builders.pyl
[modify] https://crrev.com/9183dae745ae76e4d808469c4c7ee20ffecbe3ab/scripts/slave/recipe_modules/chromium_tests/chromium_gpu_fyi.py
[modify] https://crrev.com/9183dae745ae76e4d808469c4c7ee20ffecbe3ab/scripts/slave/recipe_modules/chromium_tests/chromium_gpu.py

Project Member

Comment 2 by bugdroid1@chromium.org, Nov 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2800f69a229334b9c5bb143a1aee8f30078ef9a7

commit 2800f69a229334b9c5bb143a1aee8f30078ef9a7
Author: Kenneth Russell <kbr@chromium.org>
Date: Sat Nov 18 01:02:47 2017

Deploy Android Nexus 5X bot on chromium.gpu.

This runs essentially the same tests as the desktop bots.

BUG= 786572 
NOTRY=true

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I36718069f2a786e3f7e274645d3ff6f58404f492
Reviewed-on: https://chromium-review.googlesource.com/777728
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517650}
[modify] https://crrev.com/2800f69a229334b9c5bb143a1aee8f30078ef9a7/content/test/gpu/generate_buildbot_json.py
[modify] https://crrev.com/2800f69a229334b9c5bb143a1aee8f30078ef9a7/testing/buildbot/chromium.gpu.json

Project Member

Comment 3 by bugdroid1@chromium.org, Nov 18 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/master-manager/+/90cea5db46d807d238510fd214ae9e4d84bfe675

commit 90cea5db46d807d238510fd214ae9e4d84bfe675
Author: Kenneth Russell <kbr@google.com>
Date: Sat Nov 18 02:02:19 2017

Project Member

Comment 4 by bugdroid1@chromium.org, Nov 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec77437dc6980786eca5aafd1a5198588dcc93da

commit ec77437dc6980786eca5aafd1a5198588dcc93da
Author: Kenneth Russell <kbr@chromium.org>
Date: Sat Nov 18 03:45:45 2017

Add Nexus 5X chromium.gpu bot to mb_config.pyl.

Forgot this the first time around.

BUG= 786572 
TBR=dpranke@chromium.org
NOTRY=true

Change-Id: I24cd1a3053e80a7e661f92f26d01011a6cf0bddb
Reviewed-on: https://chromium-review.googlesource.com/777853
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517695}
[modify] https://crrev.com/ec77437dc6980786eca5aafd1a5198588dcc93da/tools/mb/mb_config.pyl

Project Member

Comment 5 by bugdroid1@chromium.org, Jan 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6c9b264d734591f2dea4c736ebf46a16d8fb1eee

commit 6c9b264d734591f2dea4c736ebf46a16d8fb1eee
Author: Kenneth Russell <kbr@chromium.org>
Date: Fri Jan 05 06:18:16 2018

Stop running gl_tests and gl_unittests on Nexus 5X GPU bots.

These are already run on the same hardware on the main waterfall, on
"chromium.android", "Marshmallow Phone Tester (rel)", which is part of
the android_n5x_swarming_rel trybot.

BUG= 786572 
TBR=ynovikov@chromium.org, jbudorick@chromium.org
NOTRY=true

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I71a5df2597c2d1fa5598a32f403776391ac26528
Reviewed-on: https://chromium-review.googlesource.com/851084
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527229}
[modify] https://crrev.com/6c9b264d734591f2dea4c736ebf46a16d8fb1eee/content/test/gpu/generate_buildbot_json.py
[modify] https://crrev.com/6c9b264d734591f2dea4c736ebf46a16d8fb1eee/testing/buildbot/chromium.gpu.fyi.json
[modify] https://crrev.com/6c9b264d734591f2dea4c736ebf46a16d8fb1eee/testing/buildbot/chromium.gpu.json

Project Member

Comment 6 by bugdroid1@chromium.org, Feb 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/b04ea1d8368799af5a84e939eb1fc43debaf4c13

commit b04ea1d8368799af5a84e939eb1fc43debaf4c13
Author: Kenneth Russell <kbr@chromium.org>
Date: Fri Feb 16 19:27:18 2018

Run GPU tests by default on android_n5x_swarming_rel.

Like the desktop tryservers win7_chromium_rel_ng, mac_chromium_rel_ng,
and linux_chromium_rel_ng, also run GPU tests on this tryserver.

BUG= 786572 

Change-Id: Iba0536e9fae0826ec5cc0390bf40c73d176c1456
Reviewed-on: https://chromium-review.googlesource.com/831128
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>

[modify] https://crrev.com/b04ea1d8368799af5a84e939eb1fc43debaf4c13/tests/masters_recipes_test.py
[modify] https://crrev.com/b04ea1d8368799af5a84e939eb1fc43debaf4c13/scripts/slave/recipe_modules/chromium_tests/trybots.py

Project Member

Comment 7 by bugdroid1@chromium.org, Feb 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/086f3e40f389f6ca1183d5d361ebf3d8d4f5c697

commit 086f3e40f389f6ca1183d5d361ebf3d8d4f5c697
Author: Benjamin Pastene <bpastene@chromium.org>
Date: Fri Feb 16 19:42:19 2018

Revert "Run GPU tests by default on android_n5x_swarming_rel."

This reverts commit b04ea1d8368799af5a84e939eb1fc43debaf4c13.

Reason for revert: breaks the cq trybot
https://ci.chromium.org/buildbot/tryserver.chromium.android/android_n5x_swarming_rel/363483

Original change's description:
> Run GPU tests by default on android_n5x_swarming_rel.
> 
> Like the desktop tryservers win7_chromium_rel_ng, mac_chromium_rel_ng,
> and linux_chromium_rel_ng, also run GPU tests on this tryserver.
> 
> BUG= 786572 
> 
> Change-Id: Iba0536e9fae0826ec5cc0390bf40c73d176c1456
> Reviewed-on: https://chromium-review.googlesource.com/831128
> Commit-Queue: Kenneth Russell <kbr@chromium.org>
> Reviewed-by: John Budorick <jbudorick@chromium.org>

TBR=kbr@chromium.org,jbudorick@chromium.org

Change-Id: I9d8e460b674a069e1f19cd78c570d731a995fce5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  786572 
Reviewed-on: https://chromium-review.googlesource.com/923372
Reviewed-by: Benjamin Pastene <bpastene@chromium.org>
Commit-Queue: Benjamin Pastene <bpastene@chromium.org>

[modify] https://crrev.com/086f3e40f389f6ca1183d5d361ebf3d8d4f5c697/tests/masters_recipes_test.py
[modify] https://crrev.com/086f3e40f389f6ca1183d5d361ebf3d8d4f5c697/scripts/slave/recipe_modules/chromium_tests/trybots.py

Comment 8 by kbr@chromium.org, Feb 21 2018

Blockedon: 814087
Project Member

Comment 9 by bugdroid1@chromium.org, Feb 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/12f039e2c3b0301a51177addbe88ae0bbef98cee

commit 12f039e2c3b0301a51177addbe88ae0bbef98cee
Author: Kenneth Russell <kbr@chromium.org>
Date: Wed Feb 21 18:41:26 2018

Add no-op optional Android trybot description.

Right now, the Android GPU bots don't run the extended test suites
that the desktop bots do, like the WebGL 2.0 conformance suite. Now
that android_n5x_swarming_rel is running all of the GPU tests, we need
to make android_optional_gpu_tests_rel essentially a no-op. As a first
step, add an optional Android bot configuration running just the no-op
sleep test, which is a test target that's known to work.

After android_optional_gpu_tests_rel is switched to target this
configuration, we'll attempt to eliminate even this test. (This
conservative approach is being taken because based on recent
experience, it's unclear whether a trybot that has zero test steps
works correctly.)

R=dpranke@chromium.org
TBR=ynovikov@chromium.org, jbudorick@chromium.org
NOTRY=true

Bug:  786572 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ia3c17aff62d84a1e30b15ce830f376c2b79ee09e
Reviewed-on: https://chromium-review.googlesource.com/928055
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538160}
[modify] https://crrev.com/12f039e2c3b0301a51177addbe88ae0bbef98cee/content/test/gpu/generate_buildbot_json.py
[modify] https://crrev.com/12f039e2c3b0301a51177addbe88ae0bbef98cee/testing/buildbot/chromium.gpu.fyi.json
[modify] https://crrev.com/12f039e2c3b0301a51177addbe88ae0bbef98cee/tools/mb/mb_config.pyl

Project Member

Comment 10 by bugdroid1@chromium.org, Feb 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/72afa2bfd7c9b53132915338133d797bcca85892

commit 72afa2bfd7c9b53132915338133d797bcca85892
Author: Kenneth Russell <kbr@chromium.org>
Date: Wed Feb 21 19:38:39 2018

Re-land: run GPU tests by default on android_n5x_swarming_rel.

Like the desktop tryservers win7_chromium_rel_ng, mac_chromium_rel_ng,
and linux_chromium_rel_ng, also run GPU tests on this tryserver.

Fix inconsistencies among the bots' configurations preventing the
previous version of this CL from working.

Switched android_optional_gpu_tests_rel to mirror a new Optional
Android trybot configuration, the intent of which is to be completely
empty right now. The GPU.FYI Android bots don't currently run any more
tests than the GPU waterfall's N5X bot.

Bug:  786572 
Change-Id: Ic2be6eb945719e5c970a07cd225cd52407f9ea4b
Reviewed-on: https://chromium-review.googlesource.com/927925
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>

[modify] https://crrev.com/72afa2bfd7c9b53132915338133d797bcca85892/tests/masters_recipes_test.py
[modify] https://crrev.com/72afa2bfd7c9b53132915338133d797bcca85892/scripts/slave/recipe_modules/chromium_tests/chromium_gpu_fyi.py
[modify] https://crrev.com/72afa2bfd7c9b53132915338133d797bcca85892/scripts/slave/recipe_modules/chromium_tests/chromium_gpu.py
[modify] https://crrev.com/72afa2bfd7c9b53132915338133d797bcca85892/scripts/slave/recipe_modules/chromium_tests/trybots.py

Project Member

Comment 11 by bugdroid1@chromium.org, Feb 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f05a7394c8a6a9dbf235bda9a1ea5dd6c1085d2b

commit f05a7394c8a6a9dbf235bda9a1ea5dd6c1085d2b
Author: Kenneth Russell <kbr@chromium.org>
Date: Wed Feb 21 20:53:16 2018

Remove all tests from android_optional_gpu_tests_rel.

android_n5x_swarming_rel currently runs all of the tests that this
optional tryserver used to.

TBR=ynovikov@chromium.org
NOTRY=true

Bug:  786572 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ie0c6e858801a92883cbb2356a93428d05ce0097b
Reviewed-on: https://chromium-review.googlesource.com/929543
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538203}
[modify] https://crrev.com/f05a7394c8a6a9dbf235bda9a1ea5dd6c1085d2b/content/test/gpu/generate_buildbot_json.py
[modify] https://crrev.com/f05a7394c8a6a9dbf235bda9a1ea5dd6c1085d2b/testing/buildbot/chromium.gpu.fyi.json

Project Member

Comment 12 by bugdroid1@chromium.org, Feb 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/b68d78bc6961d54f51a2c1fb66b96bf4eae1c44b

commit b68d78bc6961d54f51a2c1fb66b96bf4eae1c44b
Author: Kenneth Russell <kbr@chromium.org>
Date: Wed Feb 21 20:58:00 2018

Revert "Re-land: run GPU tests by default on android_n5x_swarming_rel."

This reverts commit 72afa2bfd7c9b53132915338133d797bcca85892.

Reason for revert: broke android_n5x_swarming_rel again: https://ci.chromium.org/buildbot/tryserver.chromium.android/android_n5x_swarming_rel/365955

Original change's description:
> Re-land: run GPU tests by default on android_n5x_swarming_rel.
> 
> Like the desktop tryservers win7_chromium_rel_ng, mac_chromium_rel_ng,
> and linux_chromium_rel_ng, also run GPU tests on this tryserver.
> 
> Fix inconsistencies among the bots' configurations preventing the
> previous version of this CL from working.
> 
> Switched android_optional_gpu_tests_rel to mirror a new Optional
> Android trybot configuration, the intent of which is to be completely
> empty right now. The GPU.FYI Android bots don't currently run any more
> tests than the GPU waterfall's N5X bot.
> 
> Bug:  786572 
> Change-Id: Ic2be6eb945719e5c970a07cd225cd52407f9ea4b
> Reviewed-on: https://chromium-review.googlesource.com/927925
> Commit-Queue: Kenneth Russell <kbr@chromium.org>
> Reviewed-by: John Budorick <jbudorick@chromium.org>

TBR=kbr@chromium.org,jbudorick@chromium.org

Change-Id: I8a6a2d09036ad0227499584bcba9fe693c2aad9f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  786572 
Reviewed-on: https://chromium-review.googlesource.com/929463
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>

[modify] https://crrev.com/b68d78bc6961d54f51a2c1fb66b96bf4eae1c44b/tests/masters_recipes_test.py
[modify] https://crrev.com/b68d78bc6961d54f51a2c1fb66b96bf4eae1c44b/scripts/slave/recipe_modules/chromium_tests/chromium_gpu_fyi.py
[modify] https://crrev.com/b68d78bc6961d54f51a2c1fb66b96bf4eae1c44b/scripts/slave/recipe_modules/chromium_tests/chromium_gpu.py
[modify] https://crrev.com/b68d78bc6961d54f51a2c1fb66b96bf4eae1c44b/scripts/slave/recipe_modules/chromium_tests/trybots.py

Project Member

Comment 13 by bugdroid1@chromium.org, Feb 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/81290b16aa450808afee4a22ad61b7cea36daa75

commit 81290b16aa450808afee4a22ad61b7cea36daa75
Author: Kenneth Russell <kbr@chromium.org>
Date: Thu Feb 22 13:59:35 2018

Use src_side_runtest_py on chromium.android waterfall.

This is needed as a prerequisite for making android_n5x_swarming_rel
mirror one of the bots on the chromium.gpu waterfall, because that
waterfall already sets this flag and the flag must match between
waterfalls.

Bug:  786572 
Change-Id: Iae1f0e546997fb6d1cbb1b55e5756984d2bf5679
Reviewed-on: https://chromium-review.googlesource.com/930704
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>

[modify] https://crrev.com/81290b16aa450808afee4a22ad61b7cea36daa75/scripts/slave/recipe_modules/chromium/examples/full.expected/basic_out_dir_ninja_build_failure.json
[modify] https://crrev.com/81290b16aa450808afee4a22ad61b7cea36daa75/scripts/slave/recipes/chromium.expected/dynamic_gtest_android.json
[modify] https://crrev.com/81290b16aa450808afee4a22ad61b7cea36daa75/scripts/slave/recipe_modules/chromium_tests/tests/api/compile_specific_targets.expected/android.json
[modify] https://crrev.com/81290b16aa450808afee4a22ad61b7cea36daa75/scripts/slave/recipe_modules/chromium/examples/full.expected/basic_out_dir.json
[modify] https://crrev.com/81290b16aa450808afee4a22ad61b7cea36daa75/scripts/slave/recipe_modules/chromium/examples/full.expected/basic_out_dir_goma_module_build_failure.json
[modify] https://crrev.com/81290b16aa450808afee4a22ad61b7cea36daa75/scripts/slave/recipes/chromium.expected/dynamic_instrumentation_test.json
[modify] https://crrev.com/81290b16aa450808afee4a22ad61b7cea36daa75/scripts/slave/recipe_modules/chromium/examples/full.expected/basic_out_dir_without_compile_py.json
[modify] https://crrev.com/81290b16aa450808afee4a22ad61b7cea36daa75/scripts/slave/recipe_modules/chromium/examples/full.expected/basic_out_dir_with_custom_mb_config.json
[modify] https://crrev.com/81290b16aa450808afee4a22ad61b7cea36daa75/scripts/slave/recipe_modules/chromium/examples/full.expected/basic_no_out_dir_with_goma_module.json
[modify] https://crrev.com/81290b16aa450808afee4a22ad61b7cea36daa75/scripts/slave/recipe_modules/chromium_tests/chromium_android.py
[modify] https://crrev.com/81290b16aa450808afee4a22ad61b7cea36daa75/scripts/slave/recipe_modules/chromium/examples/full.expected/basic_out_dir_with_goma_module.json
[modify] https://crrev.com/81290b16aa450808afee4a22ad61b7cea36daa75/scripts/slave/recipes/chromium.expected/dynamic_junit_test.json
[modify] https://crrev.com/81290b16aa450808afee4a22ad61b7cea36daa75/scripts/slave/recipe_modules/chromium/examples/full.expected/basic_out_dir_goma_module_ping_failure.json
[modify] https://crrev.com/81290b16aa450808afee4a22ad61b7cea36daa75/scripts/slave/recipe_modules/chromium/examples/full.expected/basic_out_dir_ninja_no_op_failure.json
[modify] https://crrev.com/81290b16aa450808afee4a22ad61b7cea36daa75/scripts/slave/recipe_modules/chromium/examples/full.expected/basic_out_dir_goma_module_start_failure.json
[modify] https://crrev.com/81290b16aa450808afee4a22ad61b7cea36daa75/scripts/slave/recipes/chromium.expected/dynamic_instrumentation_nodefault_build.json
[modify] https://crrev.com/81290b16aa450808afee4a22ad61b7cea36daa75/scripts/slave/recipes/chromium.expected/dynamic_instrumentation_nodefault_test.json
[modify] https://crrev.com/81290b16aa450808afee4a22ad61b7cea36daa75/scripts/slave/recipes/chromium.expected/dynamic_instrumentation_test_custom_name.json
[modify] https://crrev.com/81290b16aa450808afee4a22ad61b7cea36daa75/scripts/slave/recipes/chromium.expected/dynamic_swarmed_gn_instrumentation_test.json

Project Member

Comment 14 by bugdroid1@chromium.org, Feb 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/e80bb9375f20c506ff73127cbcf9c6674f3eebc9

commit e80bb9375f20c506ff73127cbcf9c6674f3eebc9
Author: Kenneth Russell <kbr@chromium.org>
Date: Thu Feb 22 20:20:27 2018

Re-land #2: run GPU tests by default on android_n5x_swarming_rel.

Like the desktop tryservers win7_chromium_rel_ng, mac_chromium_rel_ng,
and linux_chromium_rel_ng, also run GPU tests on this tryserver.

Fixed inconsistencies among the bots' configurations preventing the
previous version of this CL from working.

Upgraded the masters_recipes_test to check for agreement of the
src_side_runtest_py flag, which the recipe itself was already doing.

Switched android_optional_gpu_tests_rel to mirror a new Optional Android
trybot configuration, which is completely empty right now. The GPU.FYI
Android bots don't currently run any more tests than the GPU waterfall's
N5X bot.

Bug:  786572 
Change-Id: I242c9f1783f4ca4ad61f29a5a66f77c16b7fafee
Reviewed-on: https://chromium-review.googlesource.com/930484
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>

[modify] https://crrev.com/e80bb9375f20c506ff73127cbcf9c6674f3eebc9/tests/masters_recipes_test.py
[modify] https://crrev.com/e80bb9375f20c506ff73127cbcf9c6674f3eebc9/scripts/slave/recipe_modules/chromium_tests/chromium_gpu_fyi.py
[modify] https://crrev.com/e80bb9375f20c506ff73127cbcf9c6674f3eebc9/scripts/slave/recipe_modules/chromium_tests/chromium_gpu.py
[modify] https://crrev.com/e80bb9375f20c506ff73127cbcf9c6674f3eebc9/scripts/slave/recipe_modules/chromium_tests/trybots.py

Comment 15 by kbr@chromium.org, Feb 22 2018

Status: Started (was: Assigned)
The latest landing of this CL seems it will stick. Tryjobs are successfully running GPU tests on android_n5x_swarming_rel, for example:

https://ci.chromium.org/buildbot/tryserver.chromium.android/android_n5x_swarming_rel/367168

and the tests are catching CLs which would otherwise cause breakage:

https://ci.chromium.org/buildbot/tryserver.chromium.android/android_n5x_swarming_rel/367161

ynovikov@ was doing some additional cleanups of android_optional_gpu_tests_rel (thanks!), so I'll mark this Started for now.

Comment 16 by kbr@chromium.org, Feb 23 2018

Status: Fixed (was: Started)
Talking with ynovikov@, going to call this Fixed. Thanks everyone for your help!

Project Member

Comment 17 by bugdroid1@chromium.org, Feb 23 2018

The following revision refers to this bug:
  https://skia.googlesource.com/buildbot/+/45f26d10f980fd2ce2acfeb1df0c1a155780f9cc

commit 45f26d10f980fd2ce2acfeb1df0c1a155780f9cc
Author: Yuly Novikov <ynovikov@google.com>
Date: Fri Feb 23 14:28:04 2018

Remove android_optional_gpu_tests_rel from catapult CQ_INCLUDE_TRYBOTS

The tests were migrated to android_n5x_swarming_rel.

BUG= chromium:786572 

Change-Id: I4954063bb8fcdc124818ed4c7db498e2d33d0e32
Reviewed-on: https://skia-review.googlesource.com/109601
Reviewed-by: Kenneth Russell <kbr@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Eric Boren <borenet@google.com>

[modify] https://crrev.com/45f26d10f980fd2ce2acfeb1df0c1a155780f9cc/autoroll/sys/catapult-autorolld.service

Project Member

Comment 18 by bugdroid1@chromium.org, Mar 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/b18784c5fd1b7d7ec4cfc5fcdab9dbfae19302d3

commit b18784c5fd1b7d7ec4cfc5fcdab9dbfae19302d3
Author: Yuly Novikov <ynovikov@chromium.org>
Date: Wed Mar 21 21:11:08 2018

Remove a note on android_optional_gpu_tests_rel from manual rolls doc.

The tests were migrated to android_n5x_swarming_rel.

BUG= chromium:786572 
BUG= chromium:731979 

Change-Id: I95de2999d0913b02bf6cb9a106f49f265bf8599a
Reviewed-on: https://chromium-review.googlesource.com/974111
Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

[modify] https://crrev.com/b18784c5fd1b7d7ec4cfc5fcdab9dbfae19302d3/docs/rolling-deps.md

Project Member

Comment 19 by bugdroid1@chromium.org, Mar 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6aea1cac122502499713bfc182d0454d0f325fa9

commit 6aea1cac122502499713bfc182d0454d0f325fa9
Author: catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Fri Mar 23 14:48:06 2018

Roll src/third_party/catapult/ 734f737c6..c4e9b1332 (14 commits)

https://chromium.googlesource.com/catapult.git/+log/734f737c6b57..c4e9b1332818

$ git log 734f737c6..c4e9b1332 --date=short --no-merges --format='%ad %ae %s'
2018-03-23 nednguyen Revert "Add --enable-automation flag in GetFromBrowserOptions()"
2018-03-22 dtu [pinpoint] Set auto_explore == True for "patch jobs".
2018-03-21 ynovikov Remove a note on android_optional_gpu_tests_rel from manual rolls doc.
2018-03-15 dproy Reland "More precise self time calculation"
2018-03-21 nednguyen Ignore fetchts file
2018-03-20 laszio [Telemetry] Support outputing json in benchmark_runner
2018-03-19 kjharland [Dashboard] Whitelist prod Fuchsia Garnet builder.
2018-03-20 benjhayden Fix sorting results.html
2018-03-19 horo Add --enable-automation flag in GetFromBrowserOptions()
2018-03-19 eakuefner [Dashboard] Avoid creating empty rows/histograms/tests if histograms are empty
2018-03-16 dtu [pinpoint] Infer "repository" parameter from configuration.
2018-03-19 chiniforooshan First set of thread times metrics in TBMv2
2018-03-16 erikchen Replace --enable-heap-profiling with --memlog equivalent.
2018-03-19 wangxianzhu Fix visual rect support for cc::DisplayItemList

Created with:
  roll-dep src/third_party/catapult
BUG=chromium:822258, chromium:786572 , chromium:731979 ,chromium:821531,chromium:821521, chromium:819969 ,chromium:822258, chromium:627461 , chromium:822843 


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=sullivan@chromium.org

Change-Id: I8c0025df6198bf9b1662bb8d78e45741d66f6aff
Reviewed-on: https://chromium-review.googlesource.com/977884
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#545441}
[modify] https://crrev.com/6aea1cac122502499713bfc182d0454d0f325fa9/DEPS

Comment 20 by kbr@chromium.org, Jun 1 2018

 Issue 763523  has been merged into this issue.

Comment 21 by kbr@chromium.org, Jun 1 2018

Blocking: 848814

Sign in to add a comment