New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 786571 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[Findit] Time should be i client timezone instead of utc

Project Member Reported by wylieb@chromium.org, Nov 17 2017

Issue description

Do this w some client side js.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/2daaf183b9c9924364625ba7b7920bdf97776ead

commit 2daaf183b9c9924364625ba7b7920bdf97776ead
Author: Brandon Wylie <wylieb@chromium.org>
Date: Thu Nov 30 21:34:19 2017

[Findit] Flake Analyzer - Convert timestamp to local time.

This will allow the user to make sense of the date without having to
convert from UTC.

Bug:786571
Change-Id: I6b6c0a9db27ee15a9d1b2ef7601775db4dc6ccb7
Reviewed-on: https://chromium-review.googlesource.com/795112
Reviewed-by: Jeffrey Li <lijeffrey@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Commit-Queue: Brandon Wylie <wylieb@chromium.org>

[modify] https://crrev.com/2daaf183b9c9924364625ba7b7920bdf97776ead/appengine/findit/templates/flake/dashboard.html
[modify] https://crrev.com/2daaf183b9c9924364625ba7b7920bdf97776ead/appengine/findit/handlers/flake/list_flakes.py
[modify] https://crrev.com/2daaf183b9c9924364625ba7b7920bdf97776ead/appengine/findit/handlers/flake/test/list_flakes_test.py

Project Member

Comment 2 by bugdroid1@chromium.org, Dec 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/f8845fcf46380fabd49b63a849f6524d3734ca25

commit f8845fcf46380fabd49b63a849f6524d3734ca25
Author: Brandon Wylie <wylieb@chromium.org>
Date: Mon Dec 04 19:10:14 2017

Revert "[Findit] Flake Analyzer - Convert timestamp to local time."

This reverts commit 2daaf183b9c9924364625ba7b7920bdf97776ead.

Reason for revert: Doesn't work as intended.

Original change's description:
> [Findit] Flake Analyzer - Convert timestamp to local time.
>
> This will allow the user to make sense of the date without having to
> convert from UTC.
>
> Bug:786571
> Change-Id: I6b6c0a9db27ee15a9d1b2ef7601775db4dc6ccb7
> Reviewed-on: https://chromium-review.googlesource.com/795112
> Reviewed-by: Jeffrey Li <lijeffrey@chromium.org>
> Reviewed-by: Shuotao Gao <stgao@chromium.org>
> Commit-Queue: Brandon Wylie <wylieb@chromium.org>

TBR=stgao@chromium.org,robertocn@chromium.org,lijeffrey@chromium.org,chanli@chromium.org,wylieb@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  791220 
Change-Id: Ic55865ac35a88ad9fc1ef6a552c248d78b80c006
Reviewed-on: https://chromium-review.googlesource.com/806639
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Reviewed-by: Brandon Wylie <wylieb@chromium.org>

[modify] https://crrev.com/f8845fcf46380fabd49b63a849f6524d3734ca25/appengine/findit/templates/flake/dashboard.html
[modify] https://crrev.com/f8845fcf46380fabd49b63a849f6524d3734ca25/appengine/findit/handlers/flake/list_flakes.py
[modify] https://crrev.com/f8845fcf46380fabd49b63a849f6524d3734ca25/appengine/findit/handlers/flake/test/list_flakes_test.py

Project Member

Comment 3 by bugdroid1@chromium.org, Dec 6 2017

Project Member

Comment 4 by bugdroid1@chromium.org, Dec 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/1e5cde891c2d536deab15fbc02c4ee91e2ac13ad

commit 1e5cde891c2d536deab15fbc02c4ee91e2ac13ad
Author: Brandon Wylie <wylieb@chromium.org>
Date: Wed Dec 06 23:30:31 2017

Revert "[Findit] Flake Analyzer - Display times in local time"

This reverts commit 0e998e80f36f5b3e19873b7d44aba78b9b81d3a8.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> [Findit] Flake Analyzer - Display times in local time
> 
> Display local time instead of utc time. Fiddle with example:
> https://jsfiddle.net/htfe8qh4/
> 
> Bug:  786571 
> Change-Id: I2c36e8f82510559784a0f47f2015c8f5e0f14758
> Reviewed-on: https://chromium-review.googlesource.com/809834
> Commit-Queue: Brandon Wylie <wylieb@chromium.org>
> Reviewed-by: Jeffrey Li <lijeffrey@chromium.org>

TBR=stgao@chromium.org,robertocn@chromium.org,lijeffrey@chromium.org,wylieb@chromium.org

Change-Id: I7351d90acfbb5e4f99566920ab1c08ddf10cd429
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  786571 
Reviewed-on: https://chromium-review.googlesource.com/812495
Reviewed-by: Brandon Wylie <wylieb@chromium.org>
Commit-Queue: Brandon Wylie <wylieb@chromium.org>

[modify] https://crrev.com/1e5cde891c2d536deab15fbc02c4ee91e2ac13ad/appengine/findit/templates/flake/dashboard.html
[modify] https://crrev.com/1e5cde891c2d536deab15fbc02c4ee91e2ac13ad/appengine/findit/handlers/flake/list_flakes.py
[modify] https://crrev.com/1e5cde891c2d536deab15fbc02c4ee91e2ac13ad/appengine/findit/handlers/flake/test/list_flakes_test.py

Status: Assigned (was: Untriaged)
Bug has an owner, and is therefore assigned. If you don't want to own the bug, unassign and set status to 'available'
Status: WontFix (was: Assigned)

Sign in to add a comment