New issue
Advanced search Search tips

Issue 786559 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 3
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android , iOS
Pri: 3
Type: Feature


Sign in to add a comment

Cronet should provide Native API for use on Android and iOS

Project Member Reported by mef@chromium.org, Nov 17 2017

Issue description

Currently Cronet provides platform-specific API that is easy to use from Java code on Android and ObjC code on iOS.

It should also expose a stable C(++) API that could be used directly from native code to ease migration of cross-platform apps.

This issue is created to track this work. The internal tracking bug is b/24162097. 
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b427f986b72ee43859cf2b840276427f0b69dd96

commit b427f986b72ee43859cf2b840276427f0b69dd96
Author: Misha Efimov <mef@chromium.org>
Date: Thu Nov 30 21:32:53 2017

[Cronet] Define Cronet API in Mojo IDL and generate C bindings.

Notable files:
c/c/native/cronet.idl - Cronet API defined as Mojo IDL.
c/c/native/generated/cronet.idl_c.h - Cronet C API generated from cronet.idl
c/c/native/generated/cronet.idl_impl_interface.* - Abstract interfaces to implement C API generated from cronet.idl
c/c/native/generated/cronet.idl_impl_interface_unittest.* - Simple unit tests to cover interfaces in C API generated from cronet.idl
c/c/native/generated/cronet.idl_impl_struct.* - Structs to implement C API generated from cronet.idl
c/c/native/generated/cronet.idl_impl_struct_unittest.* - Simple unit tests to cover structs in C API generated from cronet.idl

c/c/tools/generate_idl_bindings.py - wrapper script to manually generate C API files above.
c/c/tools/generators/cronet_bindings_generator.py - Cronet bindings generator script forked from mojo/public/tools/bindings/mojom_bindings_generator.py
c/c/tools/generators/cronet_c_generator.py - C API generator script forked from mojo/public/tools/bindings/generators/mojom_cpp_generator.py
c/c/tools/generators/c_templates/*.tmpl - C API templates based on mojo/public/tools/bindings/generators/cpp_templates/*.tmpl

Bug:  786559 
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ibf276fffce22021a1153dfdd473983e1e552603d
Reviewed-on: https://chromium-review.googlesource.com/590274
Commit-Queue: Misha Efimov <mef@chromium.org>
Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520696}
[modify] https://crrev.com/b427f986b72ee43859cf2b840276427f0b69dd96/components/cronet/PRESUBMIT.py
[modify] https://crrev.com/b427f986b72ee43859cf2b840276427f0b69dd96/components/cronet/android/BUILD.gn
[modify] https://crrev.com/b427f986b72ee43859cf2b840276427f0b69dd96/components/cronet/ios/test/BUILD.gn
[add] https://crrev.com/b427f986b72ee43859cf2b840276427f0b69dd96/components/cronet/native/BUILD.gn
[add] https://crrev.com/b427f986b72ee43859cf2b840276427f0b69dd96/components/cronet/native/cronet.idl
[add] https://crrev.com/b427f986b72ee43859cf2b840276427f0b69dd96/components/cronet/native/generated/cronet.idl_c.h
[add] https://crrev.com/b427f986b72ee43859cf2b840276427f0b69dd96/components/cronet/native/generated/cronet.idl_impl_interface.cc
[add] https://crrev.com/b427f986b72ee43859cf2b840276427f0b69dd96/components/cronet/native/generated/cronet.idl_impl_interface.h
[add] https://crrev.com/b427f986b72ee43859cf2b840276427f0b69dd96/components/cronet/native/generated/cronet.idl_impl_interface_unittest.cc
[add] https://crrev.com/b427f986b72ee43859cf2b840276427f0b69dd96/components/cronet/native/generated/cronet.idl_impl_struct.cc
[add] https://crrev.com/b427f986b72ee43859cf2b840276427f0b69dd96/components/cronet/native/generated/cronet.idl_impl_struct.h
[add] https://crrev.com/b427f986b72ee43859cf2b840276427f0b69dd96/components/cronet/native/generated/cronet.idl_impl_struct_unittest.cc
[add] https://crrev.com/b427f986b72ee43859cf2b840276427f0b69dd96/components/cronet/tools/generate_idl_bindings.py
[add] https://crrev.com/b427f986b72ee43859cf2b840276427f0b69dd96/components/cronet/tools/generators/c_templates/module_c.h.tmpl
[add] https://crrev.com/b427f986b72ee43859cf2b840276427f0b69dd96/components/cronet/tools/generators/c_templates/module_impl_interface.cc.tmpl
[add] https://crrev.com/b427f986b72ee43859cf2b840276427f0b69dd96/components/cronet/tools/generators/c_templates/module_impl_interface.h.tmpl
[add] https://crrev.com/b427f986b72ee43859cf2b840276427f0b69dd96/components/cronet/tools/generators/c_templates/module_impl_interface_unittest.cc.tmpl
[add] https://crrev.com/b427f986b72ee43859cf2b840276427f0b69dd96/components/cronet/tools/generators/c_templates/module_impl_struct.cc.tmpl
[add] https://crrev.com/b427f986b72ee43859cf2b840276427f0b69dd96/components/cronet/tools/generators/c_templates/module_impl_struct.h.tmpl
[add] https://crrev.com/b427f986b72ee43859cf2b840276427f0b69dd96/components/cronet/tools/generators/c_templates/module_impl_struct_unittest.cc.tmpl
[add] https://crrev.com/b427f986b72ee43859cf2b840276427f0b69dd96/components/cronet/tools/generators/c_templates/module_macros.tmpl
[add] https://crrev.com/b427f986b72ee43859cf2b840276427f0b69dd96/components/cronet/tools/generators/cronet_bindings_generator.py
[add] https://crrev.com/b427f986b72ee43859cf2b840276427f0b69dd96/components/cronet/tools/generators/cronet_c_generator.py

Project Member

Comment 2 by bugdroid1@chromium.org, Dec 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/41331f568686dbfa75354222ef95c3264e99df4c

commit 41331f568686dbfa75354222ef95c3264e99df4c
Author: Misha Efimov <mef@chromium.org>
Date: Thu Dec 21 20:27:49 2017

[Cronet] Implement Executors, Runnables and Buffer for native UrlRequest callbacks.

- Add CRONET_EXPORT macro to export public API from Cronet.framework on iOS.
- Make cronet_native_test target to tests public API exported from Cronet.framework.
- Make cronet_native_unittests target to test implementation details by depending on cronet_native_impl.

Bug:  786559 
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I22fca33a029b507811eb5f8a3afe8ec1cfc0c439
Reviewed-on: https://chromium-review.googlesource.com/774899
Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Commit-Queue: Misha Efimov <mef@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525788}
[modify] https://crrev.com/41331f568686dbfa75354222ef95c3264e99df4c/components/cronet/android/BUILD.gn
[add] https://crrev.com/41331f568686dbfa75354222ef95c3264e99df4c/components/cronet/android/android_only_jni_onload_and_cronet_exports.lst
[modify] https://crrev.com/41331f568686dbfa75354222ef95c3264e99df4c/components/cronet/ios/BUILD.gn
[modify] https://crrev.com/41331f568686dbfa75354222ef95c3264e99df4c/components/cronet/ios/test/BUILD.gn
[modify] https://crrev.com/41331f568686dbfa75354222ef95c3264e99df4c/components/cronet/native/BUILD.gn
[add] https://crrev.com/41331f568686dbfa75354222ef95c3264e99df4c/components/cronet/native/buffer.cc
[add] https://crrev.com/41331f568686dbfa75354222ef95c3264e99df4c/components/cronet/native/buffer_test.cc
[modify] https://crrev.com/41331f568686dbfa75354222ef95c3264e99df4c/components/cronet/native/cronet.idl
[add] https://crrev.com/41331f568686dbfa75354222ef95c3264e99df4c/components/cronet/native/executors_test.cc
[modify] https://crrev.com/41331f568686dbfa75354222ef95c3264e99df4c/components/cronet/native/generated/cronet.idl_c.h
[modify] https://crrev.com/41331f568686dbfa75354222ef95c3264e99df4c/components/cronet/native/generated/cronet.idl_impl_interface.cc
[modify] https://crrev.com/41331f568686dbfa75354222ef95c3264e99df4c/components/cronet/native/generated/cronet.idl_impl_interface.h
[modify] https://crrev.com/41331f568686dbfa75354222ef95c3264e99df4c/components/cronet/native/generated/cronet.idl_impl_interface_unittest.cc
[modify] https://crrev.com/41331f568686dbfa75354222ef95c3264e99df4c/components/cronet/native/generated/cronet.idl_impl_struct.cc
[modify] https://crrev.com/41331f568686dbfa75354222ef95c3264e99df4c/components/cronet/native/generated/cronet.idl_impl_struct.h
[modify] https://crrev.com/41331f568686dbfa75354222ef95c3264e99df4c/components/cronet/native/generated/cronet.idl_impl_struct_unittest.cc
[add] https://crrev.com/41331f568686dbfa75354222ef95c3264e99df4c/components/cronet/native/include/DEPS
[add] https://crrev.com/41331f568686dbfa75354222ef95c3264e99df4c/components/cronet/native/include/cronet_c.h
[add] https://crrev.com/41331f568686dbfa75354222ef95c3264e99df4c/components/cronet/native/include/cronet_export.h
[add] https://crrev.com/41331f568686dbfa75354222ef95c3264e99df4c/components/cronet/native/include/headers.gni
[add] https://crrev.com/41331f568686dbfa75354222ef95c3264e99df4c/components/cronet/native/runnables.cc
[add] https://crrev.com/41331f568686dbfa75354222ef95c3264e99df4c/components/cronet/native/runnables.h
[add] https://crrev.com/41331f568686dbfa75354222ef95c3264e99df4c/components/cronet/native/runnables_unittest.cc
[add] https://crrev.com/41331f568686dbfa75354222ef95c3264e99df4c/components/cronet/native/test_util.cc
[add] https://crrev.com/41331f568686dbfa75354222ef95c3264e99df4c/components/cronet/native/test_util.h
[modify] https://crrev.com/41331f568686dbfa75354222ef95c3264e99df4c/components/cronet/tools/generators/c_templates/module_c.h.tmpl
[modify] https://crrev.com/41331f568686dbfa75354222ef95c3264e99df4c/components/cronet/tools/generators/c_templates/module_impl_interface.cc.tmpl

Project Member

Comment 3 by bugdroid1@chromium.org, Jan 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1770a1b57983f8b50c947bb85e0e2facfd46dd5f

commit 1770a1b57983f8b50c947bb85e0e2facfd46dd5f
Author: Misha Efimov <mef@chromium.org>
Date: Thu Jan 11 15:27:27 2018

[Cronet] Extract common CronetURLRequestContext from Android CronetURLRequestContextAdapter.

Note:
- Patchset 1 copies android/cronet_url_request_context_adapter.* into cronet_url_request_context.*
- android/cronet_url_request_context_adapter.* use cronet_url_request_context.*
- cronet_global_state.h defines cross-platform API used to initialize and maintain Cronet state shared by multiple engines.

Bug:  786559 
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester
Change-Id: I1cbe2162584745580e54bd0838a4a2303d7e6970
Reviewed-on: https://chromium-review.googlesource.com/840702
Commit-Queue: Misha Efimov <mef@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528628}
[modify] https://crrev.com/1770a1b57983f8b50c947bb85e0e2facfd46dd5f/base/threading/thread_restrictions.h
[add] https://crrev.com/1770a1b57983f8b50c947bb85e0e2facfd46dd5f/components/cronet/BUILD.gn
[modify] https://crrev.com/1770a1b57983f8b50c947bb85e0e2facfd46dd5f/components/cronet/android/BUILD.gn
[modify] https://crrev.com/1770a1b57983f8b50c947bb85e0e2facfd46dd5f/components/cronet/android/cronet_library_loader.cc
[modify] https://crrev.com/1770a1b57983f8b50c947bb85e0e2facfd46dd5f/components/cronet/android/cronet_library_loader.h
[modify] https://crrev.com/1770a1b57983f8b50c947bb85e0e2facfd46dd5f/components/cronet/android/cronet_url_request_context_adapter.cc
[modify] https://crrev.com/1770a1b57983f8b50c947bb85e0e2facfd46dd5f/components/cronet/android/cronet_url_request_context_adapter.h
[modify] https://crrev.com/1770a1b57983f8b50c947bb85e0e2facfd46dd5f/components/cronet/android/test/cronet_test_util.cc
[add] https://crrev.com/1770a1b57983f8b50c947bb85e0e2facfd46dd5f/components/cronet/cronet_global_state.h
[add] https://crrev.com/1770a1b57983f8b50c947bb85e0e2facfd46dd5f/components/cronet/cronet_url_request_context.cc
[add] https://crrev.com/1770a1b57983f8b50c947bb85e0e2facfd46dd5f/components/cronet/cronet_url_request_context.h

Project Member

Comment 4 by bugdroid1@chromium.org, Jan 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c1731b07914bc0c1f4e2c6f8e9124cc821710d52

commit c1731b07914bc0c1f4e2c6f8e9124cc821710d52
Author: Misha Efimov <mef@chromium.org>
Date: Tue Jan 16 21:46:51 2018

[Cronet] Extract common CronetURLRequest from Android CronetURLRequestAdapter.

Note:
- Patchset 1 copies android/cronet_url_request_adapter.* into cronet_url_request.*
- android/cronet_url_request_adapter.* use cronet_url_request.*

Bug:  786559 
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I6712cadc28bb83e8f558cd2145df78924064fef0
Reviewed-on: https://chromium-review.googlesource.com/849134
Commit-Queue: Misha Efimov <mef@chromium.org>
Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529506}
[modify] https://crrev.com/c1731b07914bc0c1f4e2c6f8e9124cc821710d52/components/cronet/BUILD.gn
[modify] https://crrev.com/c1731b07914bc0c1f4e2c6f8e9124cc821710d52/components/cronet/android/BUILD.gn
[modify] https://crrev.com/c1731b07914bc0c1f4e2c6f8e9124cc821710d52/components/cronet/android/cronet_url_request_adapter.cc
[modify] https://crrev.com/c1731b07914bc0c1f4e2c6f8e9124cc821710d52/components/cronet/android/cronet_url_request_adapter.h
[modify] https://crrev.com/c1731b07914bc0c1f4e2c6f8e9124cc821710d52/components/cronet/android/cronet_url_request_context_adapter.h
[modify] https://crrev.com/c1731b07914bc0c1f4e2c6f8e9124cc821710d52/components/cronet/android/test/cronet_test_util.cc
[add] https://crrev.com/c1731b07914bc0c1f4e2c6f8e9124cc821710d52/components/cronet/cronet_url_request.cc
[add] https://crrev.com/c1731b07914bc0c1f4e2c6f8e9124cc821710d52/components/cronet/cronet_url_request.h
[modify] https://crrev.com/c1731b07914bc0c1f4e2c6f8e9124cc821710d52/components/cronet/cronet_url_request_context.h
[modify] https://crrev.com/c1731b07914bc0c1f4e2c6f8e9124cc821710d52/components/cronet/tools/cr_cronet.py

Project Member

Comment 6 by bugdroid1@chromium.org, Jan 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d4ab383016d7e13030456ae8753003d878c1dccc

commit d4ab383016d7e13030456ae8753003d878c1dccc
Author: Misha Efimov <mef@google.com>
Date: Tue Jan 30 23:56:42 2018

[Cronet] Implement native Cronet_Engine and Cronet_EngineParams.

- Extract global state initialization code into common API.
- Get cronet::EnsureInitialized to work properly if initialized from Cronet_Engine native API.
- Add accept_language to URLRequestContextConfig[Builder], but don't expose it to Java.

Bug:  786559 
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I60b9cdd31837e1b15d4c2479427d5d0a77999536
Reviewed-on: https://chromium-review.googlesource.com/868076
Reviewed-by: Andrei Kapishnikov <kapishnikov@chromium.org>
Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Commit-Queue: Misha Efimov <mef@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533097}
[modify] https://crrev.com/d4ab383016d7e13030456ae8753003d878c1dccc/components/cronet/android/BUILD.gn
[modify] https://crrev.com/d4ab383016d7e13030456ae8753003d878c1dccc/components/cronet/android/cronet_library_loader.cc
[modify] https://crrev.com/d4ab383016d7e13030456ae8753003d878c1dccc/components/cronet/android/cronet_url_request_context_adapter.cc
[modify] https://crrev.com/d4ab383016d7e13030456ae8753003d878c1dccc/components/cronet/android/java/src/org/chromium/net/impl/CronetLibraryLoader.java
[modify] https://crrev.com/d4ab383016d7e13030456ae8753003d878c1dccc/components/cronet/cronet_global_state.h
[modify] https://crrev.com/d4ab383016d7e13030456ae8753003d878c1dccc/components/cronet/cronet_url_request_context.cc
[modify] https://crrev.com/d4ab383016d7e13030456ae8753003d878c1dccc/components/cronet/ios/BUILD.gn
[modify] https://crrev.com/d4ab383016d7e13030456ae8753003d878c1dccc/components/cronet/ios/Cronet.mm
[modify] https://crrev.com/d4ab383016d7e13030456ae8753003d878c1dccc/components/cronet/ios/cronet_environment.h
[modify] https://crrev.com/d4ab383016d7e13030456ae8753003d878c1dccc/components/cronet/ios/cronet_environment.mm
[add] https://crrev.com/d4ab383016d7e13030456ae8753003d878c1dccc/components/cronet/ios/cronet_global_state_ios.mm
[modify] https://crrev.com/d4ab383016d7e13030456ae8753003d878c1dccc/components/cronet/native/BUILD.gn
[modify] https://crrev.com/d4ab383016d7e13030456ae8753003d878c1dccc/components/cronet/native/cronet.idl
[add] https://crrev.com/d4ab383016d7e13030456ae8753003d878c1dccc/components/cronet/native/engine.cc
[add] https://crrev.com/d4ab383016d7e13030456ae8753003d878c1dccc/components/cronet/native/engine.h
[add] https://crrev.com/d4ab383016d7e13030456ae8753003d878c1dccc/components/cronet/native/engine_test.cc
[modify] https://crrev.com/d4ab383016d7e13030456ae8753003d878c1dccc/components/cronet/native/generated/cronet.idl_c.h
[modify] https://crrev.com/d4ab383016d7e13030456ae8753003d878c1dccc/components/cronet/native/generated/cronet.idl_impl_interface.cc
[modify] https://crrev.com/d4ab383016d7e13030456ae8753003d878c1dccc/components/cronet/native/generated/cronet.idl_impl_interface.h
[modify] https://crrev.com/d4ab383016d7e13030456ae8753003d878c1dccc/components/cronet/native/generated/cronet.idl_impl_interface_unittest.cc
[modify] https://crrev.com/d4ab383016d7e13030456ae8753003d878c1dccc/components/cronet/native/generated/cronet.idl_impl_struct.cc
[modify] https://crrev.com/d4ab383016d7e13030456ae8753003d878c1dccc/components/cronet/native/generated/cronet.idl_impl_struct.h
[modify] https://crrev.com/d4ab383016d7e13030456ae8753003d878c1dccc/components/cronet/native/generated/cronet.idl_impl_struct_unittest.cc
[modify] https://crrev.com/d4ab383016d7e13030456ae8753003d878c1dccc/components/cronet/stale_host_resolver_unittest.cc
[modify] https://crrev.com/d4ab383016d7e13030456ae8753003d878c1dccc/components/cronet/url_request_context_config.cc
[modify] https://crrev.com/d4ab383016d7e13030456ae8753003d878c1dccc/components/cronet/url_request_context_config.h
[modify] https://crrev.com/d4ab383016d7e13030456ae8753003d878c1dccc/components/cronet/url_request_context_config_unittest.cc

Comment 7 by w...@chromium.org, Feb 1 2018

Blocking: 808075
Project Member

Comment 8 by bugdroid1@chromium.org, Feb 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/475d980791b916b18507acae2bcdaf21e8f271cd

commit 475d980791b916b18507acae2bcdaf21e8f271cd
Author: Misha Efimov <mef@chromium.org>
Date: Fri Feb 02 17:47:12 2018

[Cronet] Move cronet::TestServer from cronet/ios/test to cronet/test.

- Make it available for native tests.
- Fix lint warnings.

Bug:  786559 
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ib8d704d63e7eaebdc92134fc595f3f3c7a1cb79e
Reviewed-on: https://chromium-review.googlesource.com/899522
Reviewed-by: Andrei Kapishnikov <kapishnikov@chromium.org>
Commit-Queue: Misha Efimov <mef@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534087}
[modify] https://crrev.com/475d980791b916b18507acae2bcdaf21e8f271cd/components/cronet/ios/test/BUILD.gn
[modify] https://crrev.com/475d980791b916b18507acae2bcdaf21e8f271cd/components/cronet/ios/test/cronet_http_test.mm
[modify] https://crrev.com/475d980791b916b18507acae2bcdaf21e8f271cd/components/cronet/ios/test/cronet_metrics_test.mm
[modify] https://crrev.com/475d980791b916b18507acae2bcdaf21e8f271cd/components/cronet/ios/test/cronet_performance_test.mm
[modify] https://crrev.com/475d980791b916b18507acae2bcdaf21e8f271cd/components/cronet/ios/test/cronet_prefs_test.mm
[modify] https://crrev.com/475d980791b916b18507acae2bcdaf21e8f271cd/components/cronet/native/BUILD.gn
[add] https://crrev.com/475d980791b916b18507acae2bcdaf21e8f271cd/components/cronet/test/BUILD.gn
[rename] https://crrev.com/475d980791b916b18507acae2bcdaf21e8f271cd/components/cronet/test/test_server.cc
[rename] https://crrev.com/475d980791b916b18507acae2bcdaf21e8f271cd/components/cronet/test/test_server.h

Project Member

Comment 9 by bugdroid1@chromium.org, Feb 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/feadf7258eaf092c1a2222dcca4ec7015acdfb25

commit feadf7258eaf092c1a2222dcca4ec7015acdfb25
Author: Misha Efimov <mef@chromium.org>
Date: Thu Feb 08 17:39:00 2018

[Cronet] Sync Cronet C generators to latest mojo code.

Bug:  786559 
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I814d5fac015abef7a7af768c6022c7ee9860ba36
Reviewed-on: https://chromium-review.googlesource.com/908971
Reviewed-by: Andrei Kapishnikov <kapishnikov@chromium.org>
Commit-Queue: Misha Efimov <mef@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535428}
[modify] https://crrev.com/feadf7258eaf092c1a2222dcca4ec7015acdfb25/components/cronet/tools/generators/cronet_bindings_generator.py
[modify] https://crrev.com/feadf7258eaf092c1a2222dcca4ec7015acdfb25/components/cronet/tools/generators/cronet_c_generator.py

Project Member

Comment 10 by bugdroid1@chromium.org, Feb 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d302556c07db3eb87f98f64c5d5c46400a4d5d9f

commit d302556c07db3eb87f98f64c5d5c46400a4d5d9f
Author: Misha Efimov <mef@chromium.org>
Date: Thu Feb 08 22:11:45 2018

[Cronet] Update native Cronet.idl and generators for UrlRequest.

- Add missing CRONET_EXPORT to public array getters.
- Change struct member variables and method arguments to use underscore_names.
- Return Cronet_RESULT from UrlRequest methods that could fail.

Bug:  786559 
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I8885742392000468f02fafdff598e79f3f622302
Reviewed-on: https://chromium-review.googlesource.com/905271
Reviewed-by: Andrei Kapishnikov <kapishnikov@chromium.org>
Commit-Queue: Misha Efimov <mef@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535542}
[modify] https://crrev.com/d302556c07db3eb87f98f64c5d5c46400a4d5d9f/components/cronet/native/cronet.idl
[modify] https://crrev.com/d302556c07db3eb87f98f64c5d5c46400a4d5d9f/components/cronet/native/engine.cc
[modify] https://crrev.com/d302556c07db3eb87f98f64c5d5c46400a4d5d9f/components/cronet/native/engine.h
[modify] https://crrev.com/d302556c07db3eb87f98f64c5d5c46400a4d5d9f/components/cronet/native/engine_test.cc
[modify] https://crrev.com/d302556c07db3eb87f98f64c5d5c46400a4d5d9f/components/cronet/native/generated/cronet.idl_c.h
[modify] https://crrev.com/d302556c07db3eb87f98f64c5d5c46400a4d5d9f/components/cronet/native/generated/cronet.idl_impl_interface.cc
[modify] https://crrev.com/d302556c07db3eb87f98f64c5d5c46400a4d5d9f/components/cronet/native/generated/cronet.idl_impl_interface.h
[modify] https://crrev.com/d302556c07db3eb87f98f64c5d5c46400a4d5d9f/components/cronet/native/generated/cronet.idl_impl_interface_unittest.cc
[modify] https://crrev.com/d302556c07db3eb87f98f64c5d5c46400a4d5d9f/components/cronet/native/generated/cronet.idl_impl_struct.cc
[modify] https://crrev.com/d302556c07db3eb87f98f64c5d5c46400a4d5d9f/components/cronet/native/generated/cronet.idl_impl_struct.h
[modify] https://crrev.com/d302556c07db3eb87f98f64c5d5c46400a4d5d9f/components/cronet/native/generated/cronet.idl_impl_struct_unittest.cc
[modify] https://crrev.com/d302556c07db3eb87f98f64c5d5c46400a4d5d9f/components/cronet/native/runnables_unittest.cc
[modify] https://crrev.com/d302556c07db3eb87f98f64c5d5c46400a4d5d9f/components/cronet/tools/generators/c_templates/module_c.h.tmpl

Project Member

Comment 11 by bugdroid1@chromium.org, Feb 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3905efa41cc76832dbf627bf4ac00781f3a266a2

commit 3905efa41cc76832dbf627bf4ac00781f3a266a2
Author: kapishnikov <kapishnikov@chromium.org>
Date: Fri Feb 09 16:03:14 2018

Small change in the unittest template

1. Define the class constructors and destructors as "default".
2. Use auto when declaring and assigning a variable using static_cast to remove redundancy.

BUG= 786559 

Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ib5c6b20114bde3204f8adc2487e4e37637e64428
Reviewed-on: https://chromium-review.googlesource.com/909969
Reviewed-by: Misha Efimov <mef@chromium.org>
Commit-Queue: Andrei Kapishnikov <kapishnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535724}
[modify] https://crrev.com/3905efa41cc76832dbf627bf4ac00781f3a266a2/components/cronet/native/generated/cronet.idl_impl_interface_unittest.cc
[modify] https://crrev.com/3905efa41cc76832dbf627bf4ac00781f3a266a2/components/cronet/tools/generators/c_templates/module_impl_interface_unittest.cc.tmpl

Project Member

Comment 12 by bugdroid1@chromium.org, Feb 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1d0a55f1e40f35413ad4191a26e996a2e6473f20

commit 1d0a55f1e40f35413ad4191a26e996a2e6473f20
Author: Misha Efimov <mef@chromium.org>
Date: Tue Feb 13 12:14:03 2018

[Cronet] Native API code generator tweaks for better naming.

- Replace XYZ_Context type with Cronet_ClientContext.
- Generate XYZ_SetClientContext / XYZ_GetClientContext implementation.
- Rename XYZ_CreateStub functions to XYZ_CreateWith.
- Rename CharString to Cronet_String.
- Rename RawDataPtr to Cronet_RawDataPtr.

Bug:  786559 
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ia7b650007a993bade59eae7c70b33eed5214bac2
Reviewed-on: https://chromium-review.googlesource.com/912331
Reviewed-by: Andrei Kapishnikov <kapishnikov@chromium.org>
Commit-Queue: Misha Efimov <mef@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536341}
[modify] https://crrev.com/1d0a55f1e40f35413ad4191a26e996a2e6473f20/components/cronet/native/buffer.cc
[modify] https://crrev.com/1d0a55f1e40f35413ad4191a26e996a2e6473f20/components/cronet/native/buffer_test.cc
[modify] https://crrev.com/1d0a55f1e40f35413ad4191a26e996a2e6473f20/components/cronet/native/engine.cc
[modify] https://crrev.com/1d0a55f1e40f35413ad4191a26e996a2e6473f20/components/cronet/native/engine.h
[modify] https://crrev.com/1d0a55f1e40f35413ad4191a26e996a2e6473f20/components/cronet/native/executors_test.cc
[modify] https://crrev.com/1d0a55f1e40f35413ad4191a26e996a2e6473f20/components/cronet/native/generated/cronet.idl_c.h
[modify] https://crrev.com/1d0a55f1e40f35413ad4191a26e996a2e6473f20/components/cronet/native/generated/cronet.idl_impl_interface.cc
[modify] https://crrev.com/1d0a55f1e40f35413ad4191a26e996a2e6473f20/components/cronet/native/generated/cronet.idl_impl_interface.h
[modify] https://crrev.com/1d0a55f1e40f35413ad4191a26e996a2e6473f20/components/cronet/native/generated/cronet.idl_impl_interface_unittest.cc
[modify] https://crrev.com/1d0a55f1e40f35413ad4191a26e996a2e6473f20/components/cronet/native/generated/cronet.idl_impl_struct.cc
[modify] https://crrev.com/1d0a55f1e40f35413ad4191a26e996a2e6473f20/components/cronet/native/generated/cronet.idl_impl_struct.h
[modify] https://crrev.com/1d0a55f1e40f35413ad4191a26e996a2e6473f20/components/cronet/native/runnables.cc
[modify] https://crrev.com/1d0a55f1e40f35413ad4191a26e996a2e6473f20/components/cronet/native/runnables.h
[modify] https://crrev.com/1d0a55f1e40f35413ad4191a26e996a2e6473f20/components/cronet/native/runnables_unittest.cc
[modify] https://crrev.com/1d0a55f1e40f35413ad4191a26e996a2e6473f20/components/cronet/native/test_util.cc
[modify] https://crrev.com/1d0a55f1e40f35413ad4191a26e996a2e6473f20/components/cronet/tools/generators/c_templates/module_c.h.tmpl
[modify] https://crrev.com/1d0a55f1e40f35413ad4191a26e996a2e6473f20/components/cronet/tools/generators/c_templates/module_impl_interface.cc.tmpl
[modify] https://crrev.com/1d0a55f1e40f35413ad4191a26e996a2e6473f20/components/cronet/tools/generators/c_templates/module_impl_interface.h.tmpl
[modify] https://crrev.com/1d0a55f1e40f35413ad4191a26e996a2e6473f20/components/cronet/tools/generators/c_templates/module_impl_interface_unittest.cc.tmpl
[modify] https://crrev.com/1d0a55f1e40f35413ad4191a26e996a2e6473f20/components/cronet/tools/generators/cronet_c_generator.py

Project Member

Comment 13 by bugdroid1@chromium.org, Feb 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2454c0836c746fa50e05d264573e5b42bee6aee5

commit 2454c0836c746fa50e05d264573e5b42bee6aee5
Author: Misha Efimov <mef@chromium.org>
Date: Tue Feb 13 19:50:12 2018

[Cronet] Change native structs to copy array elements instead of taking ownership.

Bug:  786559 
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ib0cef7304f326ba2cdd2fc1ef5ff07ff9435568c
Reviewed-on: https://chromium-review.googlesource.com/915001
Reviewed-by: Andrei Kapishnikov <kapishnikov@chromium.org>
Commit-Queue: Misha Efimov <mef@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536428}
[modify] https://crrev.com/2454c0836c746fa50e05d264573e5b42bee6aee5/components/cronet/native/cronet.idl
[modify] https://crrev.com/2454c0836c746fa50e05d264573e5b42bee6aee5/components/cronet/native/engine.cc
[modify] https://crrev.com/2454c0836c746fa50e05d264573e5b42bee6aee5/components/cronet/native/engine_test.cc
[modify] https://crrev.com/2454c0836c746fa50e05d264573e5b42bee6aee5/components/cronet/native/generated/cronet.idl_c.h
[modify] https://crrev.com/2454c0836c746fa50e05d264573e5b42bee6aee5/components/cronet/native/generated/cronet.idl_impl_struct.cc
[modify] https://crrev.com/2454c0836c746fa50e05d264573e5b42bee6aee5/components/cronet/native/generated/cronet.idl_impl_struct.h
[modify] https://crrev.com/2454c0836c746fa50e05d264573e5b42bee6aee5/components/cronet/native/generated/cronet.idl_impl_struct_unittest.cc
[modify] https://crrev.com/2454c0836c746fa50e05d264573e5b42bee6aee5/components/cronet/tools/generators/c_templates/module_c.h.tmpl
[modify] https://crrev.com/2454c0836c746fa50e05d264573e5b42bee6aee5/components/cronet/tools/generators/c_templates/module_impl_struct.cc.tmpl
[modify] https://crrev.com/2454c0836c746fa50e05d264573e5b42bee6aee5/components/cronet/tools/generators/c_templates/module_impl_struct.h.tmpl
[modify] https://crrev.com/2454c0836c746fa50e05d264573e5b42bee6aee5/components/cronet/tools/generators/c_templates/module_impl_struct_unittest.cc.tmpl
[modify] https://crrev.com/2454c0836c746fa50e05d264573e5b42bee6aee5/components/cronet/tools/generators/cronet_c_generator.py

Comment 14 by mef@chromium.org, Feb 14 2018

Blockedon: 812334
Project Member

Comment 15 by bugdroid1@chromium.org, Feb 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/97c908a1a872554128c0818a9c7673766c9fb9f5

commit 97c908a1a872554128c0818a9c7673766c9fb9f5
Author: Misha Efimov <mef@google.com>
Date: Wed Feb 14 20:36:24 2018

[Cronet] Implement native Cronet_UrlRequest.

Supported in this CL:

- Use Cronet_UrlRequestParam to initialize request.
- Start and run request invoking Cronet_UrlRequestCallback on app-specific Cronet_Executor.
- Provide Cronet_UrlResponseInfo if response is received.
- Provide Cronet_Error if network error has occurred.

NOT SUPPORTED in this CL:

- Cronet_UrlRequest_GetStatus is not implemented.
- Data upload (POST / PUT requests).
- URL Request Metrics is not implemented.

Bug:  786559 
Change-Id: I58899d3eb87dbe761da815c1c0f022b967264a14
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Reviewed-on: https://chromium-review.googlesource.com/905583
Reviewed-by: Andrei Kapishnikov <kapishnikov@chromium.org>
Commit-Queue: Misha Efimov <mef@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536804}
[modify] https://crrev.com/97c908a1a872554128c0818a9c7673766c9fb9f5/components/cronet/android/BUILD.gn
[modify] https://crrev.com/97c908a1a872554128c0818a9c7673766c9fb9f5/components/cronet/ios/test/BUILD.gn
[modify] https://crrev.com/97c908a1a872554128c0818a9c7673766c9fb9f5/components/cronet/native/BUILD.gn
[modify] https://crrev.com/97c908a1a872554128c0818a9c7673766c9fb9f5/components/cronet/native/cronet.idl
[modify] https://crrev.com/97c908a1a872554128c0818a9c7673766c9fb9f5/components/cronet/native/engine.h
[modify] https://crrev.com/97c908a1a872554128c0818a9c7673766c9fb9f5/components/cronet/native/generated/cronet.idl_c.h
[modify] https://crrev.com/97c908a1a872554128c0818a9c7673766c9fb9f5/components/cronet/native/generated/cronet.idl_impl_struct.cc
[modify] https://crrev.com/97c908a1a872554128c0818a9c7673766c9fb9f5/components/cronet/native/generated/cronet.idl_impl_struct.h
[add] https://crrev.com/97c908a1a872554128c0818a9c7673766c9fb9f5/components/cronet/native/io_buffer_with_cronet_buffer.cc
[add] https://crrev.com/97c908a1a872554128c0818a9c7673766c9fb9f5/components/cronet/native/io_buffer_with_cronet_buffer.h
[modify] https://crrev.com/97c908a1a872554128c0818a9c7673766c9fb9f5/components/cronet/native/runnables.cc
[modify] https://crrev.com/97c908a1a872554128c0818a9c7673766c9fb9f5/components/cronet/native/runnables.h
[modify] https://crrev.com/97c908a1a872554128c0818a9c7673766c9fb9f5/components/cronet/native/runnables_unittest.cc
[add] https://crrev.com/97c908a1a872554128c0818a9c7673766c9fb9f5/components/cronet/native/test/BUILD.gn
[rename] https://crrev.com/97c908a1a872554128c0818a9c7673766c9fb9f5/components/cronet/native/test/buffer_test.cc
[rename] https://crrev.com/97c908a1a872554128c0818a9c7673766c9fb9f5/components/cronet/native/test/engine_test.cc
[rename] https://crrev.com/97c908a1a872554128c0818a9c7673766c9fb9f5/components/cronet/native/test/executors_test.cc
[add] https://crrev.com/97c908a1a872554128c0818a9c7673766c9fb9f5/components/cronet/native/test/test_url_request_callback.cc
[add] https://crrev.com/97c908a1a872554128c0818a9c7673766c9fb9f5/components/cronet/native/test/test_url_request_callback.h
[add] https://crrev.com/97c908a1a872554128c0818a9c7673766c9fb9f5/components/cronet/native/test/test_util.cc
[rename] https://crrev.com/97c908a1a872554128c0818a9c7673766c9fb9f5/components/cronet/native/test/test_util.h
[add] https://crrev.com/97c908a1a872554128c0818a9c7673766c9fb9f5/components/cronet/native/test/url_request_test.cc
[delete] https://crrev.com/1d83f3877d013eb4ab6482d6be0489a9c0ee0aae/components/cronet/native/test_util.cc
[add] https://crrev.com/97c908a1a872554128c0818a9c7673766c9fb9f5/components/cronet/native/url_request.cc
[add] https://crrev.com/97c908a1a872554128c0818a9c7673766c9fb9f5/components/cronet/native/url_request.h
[modify] https://crrev.com/97c908a1a872554128c0818a9c7673766c9fb9f5/components/cronet/test/test_server.cc
[modify] https://crrev.com/97c908a1a872554128c0818a9c7673766c9fb9f5/components/cronet/test/test_server.h
[modify] https://crrev.com/97c908a1a872554128c0818a9c7673766c9fb9f5/components/cronet/tools/generators/c_templates/module_impl_struct.cc.tmpl
[modify] https://crrev.com/97c908a1a872554128c0818a9c7673766c9fb9f5/components/cronet/tools/generators/c_templates/module_impl_struct.h.tmpl

Project Member

Comment 16 by bugdroid1@chromium.org, Feb 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/61d6bc57e2968c5468593e37c7de4ee5d666375e

commit 61d6bc57e2968c5468593e37c7de4ee5d666375e
Author: Misha Efimov <mef@chromium.org>
Date: Wed Feb 28 18:27:46 2018

[Cronet] Move test assets from android/test to common test.

Bug:  786559 
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I5819eab242ec2864d9bdc261868871179e80c8a3
Reviewed-on: https://chromium-review.googlesource.com/906951
Reviewed-by: Helen Li <xunjieli@chromium.org>
Commit-Queue: Misha Efimov <mef@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539889}
[modify] https://crrev.com/61d6bc57e2968c5468593e37c7de4ee5d666375e/components/cronet/android/BUILD.gn
[modify] https://crrev.com/61d6bc57e2968c5468593e37c7de4ee5d666375e/components/cronet/android/test/src/org/chromium/net/TestFilesInstaller.java
[modify] https://crrev.com/61d6bc57e2968c5468593e37c7de4ee5d666375e/components/cronet/test/BUILD.gn
[rename] https://crrev.com/61d6bc57e2968c5468593e37c7de4ee5d666375e/components/cronet/test/data/cacheable.txt
[rename] https://crrev.com/61d6bc57e2968c5468593e37c7de4ee5d666375e/components/cronet/test/data/cacheable.txt.mock-http-headers
[rename] https://crrev.com/61d6bc57e2968c5468593e37c7de4ee5d666375e/components/cronet/test/data/content_length_mismatch.html
[rename] https://crrev.com/61d6bc57e2968c5468593e37c7de4ee5d666375e/components/cronet/test/data/content_length_mismatch.html.mock-http-headers
[rename] https://crrev.com/61d6bc57e2968c5468593e37c7de4ee5d666375e/components/cronet/test/data/gzipped.html
[rename] https://crrev.com/61d6bc57e2968c5468593e37c7de4ee5d666375e/components/cronet/test/data/gzipped.html.mock-http-headers
[rename] https://crrev.com/61d6bc57e2968c5468593e37c7de4ee5d666375e/components/cronet/test/data/multiredirect.html
[rename] https://crrev.com/61d6bc57e2968c5468593e37c7de4ee5d666375e/components/cronet/test/data/multiredirect.html.mock-http-headers
[rename] https://crrev.com/61d6bc57e2968c5468593e37c7de4ee5d666375e/components/cronet/test/data/notfound.html
[rename] https://crrev.com/61d6bc57e2968c5468593e37c7de4ee5d666375e/components/cronet/test/data/notfound.html.mock-http-headers
[rename] https://crrev.com/61d6bc57e2968c5468593e37c7de4ee5d666375e/components/cronet/test/data/quic_data/simple.txt
[rename] https://crrev.com/61d6bc57e2968c5468593e37c7de4ee5d666375e/components/cronet/test/data/redirect.html
[rename] https://crrev.com/61d6bc57e2968c5468593e37c7de4ee5d666375e/components/cronet/test/data/redirect.html.mock-http-headers
[rename] https://crrev.com/61d6bc57e2968c5468593e37c7de4ee5d666375e/components/cronet/test/data/redirect_invalid_scheme.html
[rename] https://crrev.com/61d6bc57e2968c5468593e37c7de4ee5d666375e/components/cronet/test/data/redirect_invalid_scheme.html.mock-http-headers
[rename] https://crrev.com/61d6bc57e2968c5468593e37c7de4ee5d666375e/components/cronet/test/data/secureproxychecksuccess.txt
[rename] https://crrev.com/61d6bc57e2968c5468593e37c7de4ee5d666375e/components/cronet/test/data/secureproxychecksuccess.txt.mock-http-headers
[rename] https://crrev.com/61d6bc57e2968c5468593e37c7de4ee5d666375e/components/cronet/test/data/set_cookie.html
[rename] https://crrev.com/61d6bc57e2968c5468593e37c7de4ee5d666375e/components/cronet/test/data/set_cookie.html.mock-http-headers
[rename] https://crrev.com/61d6bc57e2968c5468593e37c7de4ee5d666375e/components/cronet/test/data/success.txt
[rename] https://crrev.com/61d6bc57e2968c5468593e37c7de4ee5d666375e/components/cronet/test/data/success.txt.mock-http-headers

Project Member

Comment 17 by bugdroid1@chromium.org, Mar 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/42e60f7292e75a5ab0b4bb0ed7b4795fa2cdec0c

commit 42e60f7292e75a5ab0b4bb0ed7b4795fa2cdec0c
Author: Misha Efimov <mef@chromium.org>
Date: Wed Mar 07 17:52:14 2018

[Cronet] Add MultiRedirect test for native API and fix redirect bytes count.

- Make Cronet test server serve files from data directory.
- Change Android NativeTestServer to use Cronet test server.

Bug:  786559 
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I7f19519e9ee588e028976f4aa3411f735e69a4c1
Reviewed-on: https://chromium-review.googlesource.com/941589
Commit-Queue: Misha Efimov <mef@chromium.org>
Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541493}
[modify] https://crrev.com/42e60f7292e75a5ab0b4bb0ed7b4795fa2cdec0c/components/cronet/android/BUILD.gn
[modify] https://crrev.com/42e60f7292e75a5ab0b4bb0ed7b4795fa2cdec0c/components/cronet/android/test/native_test_server.cc
[modify] https://crrev.com/42e60f7292e75a5ab0b4bb0ed7b4795fa2cdec0c/components/cronet/ios/test/cronet_http_test.mm
[modify] https://crrev.com/42e60f7292e75a5ab0b4bb0ed7b4795fa2cdec0c/components/cronet/native/test/test_url_request_callback.h
[modify] https://crrev.com/42e60f7292e75a5ab0b4bb0ed7b4795fa2cdec0c/components/cronet/native/test/url_request_test.cc
[modify] https://crrev.com/42e60f7292e75a5ab0b4bb0ed7b4795fa2cdec0c/components/cronet/native/url_request.cc
[modify] https://crrev.com/42e60f7292e75a5ab0b4bb0ed7b4795fa2cdec0c/components/cronet/native/url_request.h
[modify] https://crrev.com/42e60f7292e75a5ab0b4bb0ed7b4795fa2cdec0c/components/cronet/test/test_server.cc
[modify] https://crrev.com/42e60f7292e75a5ab0b4bb0ed7b4795fa2cdec0c/components/cronet/test/test_server.h

Project Member

Comment 18 by bugdroid1@chromium.org, Mar 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d3cc93097630cb80b8adf39f1b70ca95dee3a876

commit d3cc93097630cb80b8adf39f1b70ca95dee3a876
Author: Misha Efimov <mef@google.com>
Date: Thu Mar 08 13:32:42 2018

[Cronet] Reference native url request to avoid stripping in static framework.

Bug:  786559 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ife4a40e651a08827a0dfe5c500b80a685ff29359
Reviewed-on: https://chromium-review.googlesource.com/946408
Reviewed-by: Andrei Kapishnikov <kapishnikov@chromium.org>
Commit-Queue: Misha Efimov <mef@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541782}
[modify] https://crrev.com/d3cc93097630cb80b8adf39f1b70ca95dee3a876/components/cronet/ios/Cronet.mm

Project Member

Comment 19 by bugdroid1@chromium.org, Apr 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4aa8cabc3cfb36b53466fcd1435a47bb8504eeb6

commit 4aa8cabc3cfb36b53466fcd1435a47bb8504eeb6
Author: Misha Efimov <mef@google.com>
Date: Fri Apr 06 15:58:26 2018

[Cronet] Fix unitialized memory access found by MSAN.

Bug:  786559 
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I463de96ebe15cff88295ab503f9e88840fd23348
Reviewed-on: https://chromium-review.googlesource.com/998542
Commit-Queue: Misha Efimov <mef@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548790}
[modify] https://crrev.com/4aa8cabc3cfb36b53466fcd1435a47bb8504eeb6/components/cronet/native/cronet.idl
[modify] https://crrev.com/4aa8cabc3cfb36b53466fcd1435a47bb8504eeb6/components/cronet/native/generated/cronet.idl_impl_struct.h
[modify] https://crrev.com/4aa8cabc3cfb36b53466fcd1435a47bb8504eeb6/components/cronet/native/test/buffer_test.cc
[modify] https://crrev.com/4aa8cabc3cfb36b53466fcd1435a47bb8504eeb6/components/cronet/tools/generators/c_templates/module_impl_struct.h.tmpl

Project Member

Comment 20 by bugdroid1@chromium.org, Apr 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/37176bc20f476b852a6139d1fa3d1fda76791709

commit 37176bc20f476b852a6139d1fa3d1fda76791709
Author: Wez <wez@chromium.org>
Date: Fri Apr 06 20:07:44 2018

Reland "Enable Cronet tests on desktop platforms."

This is a reland of 8fa7ecedfa0a5de4a27d93979d330b91e531b00c, which revealed several issues:
- Histogram recording did not cope correctly with an empty metrics proto.
- Several call-sites triggered MSan failures (e.g. due to read of uninitialized data).

Original change's description:
> Enable Cronet tests on desktop platforms.
>
> - Only initialize global state (e.g. AtExitManager) in non-Debug builds, so that our component-
>   build Debug bots can run cronet_tests.
> - Fix memory leaks in a number of unit-tests.
> - Disable some StaleHostResolver tests under ASAN, since they have leaks
>   that need resolving.
>
> Bug:  812268 ,  816705 ,  829097 
> Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
> Change-Id: I5084dd578682b2a8c128487c62de12e437e646f3
> Reviewed-on: https://chromium-review.googlesource.com/981787
> Commit-Queue: Wez <wez@chromium.org>
> Reviewed-by: John Budorick <jbudorick@chromium.org>
> Reviewed-by: Misha Efimov <mef@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#548672}

Bug:  812268 ,  816705 ,  829097 ,  786559 
Change-Id: Ia4027c994d475c48673c8e961f5d96255e703a15
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.linux:linux_chromium_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_asan_rel_ng
Reviewed-on: https://chromium-review.googlesource.com/999932
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Misha Efimov <mef@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548914}
[modify] https://crrev.com/37176bc20f476b852a6139d1fa3d1fda76791709/components/cronet/cronet_global_state_stubs.cc
[modify] https://crrev.com/37176bc20f476b852a6139d1fa3d1fda76791709/components/cronet/native/runnables_unittest.cc
[modify] https://crrev.com/37176bc20f476b852a6139d1fa3d1fda76791709/components/cronet/native/test/buffer_test.cc
[modify] https://crrev.com/37176bc20f476b852a6139d1fa3d1fda76791709/components/cronet/native/test/executors_test.cc
[modify] https://crrev.com/37176bc20f476b852a6139d1fa3d1fda76791709/components/cronet/native/test/url_request_test.cc
[modify] https://crrev.com/37176bc20f476b852a6139d1fa3d1fda76791709/components/cronet/native/url_request.cc
[modify] https://crrev.com/37176bc20f476b852a6139d1fa3d1fda76791709/components/cronet/stale_host_resolver.cc
[modify] https://crrev.com/37176bc20f476b852a6139d1fa3d1fda76791709/components/cronet/stale_host_resolver_unittest.cc
[modify] https://crrev.com/37176bc20f476b852a6139d1fa3d1fda76791709/testing/buildbot/chromium.clang.json
[modify] https://crrev.com/37176bc20f476b852a6139d1fa3d1fda76791709/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/37176bc20f476b852a6139d1fa3d1fda76791709/testing/buildbot/chromium.linux.json
[modify] https://crrev.com/37176bc20f476b852a6139d1fa3d1fda76791709/testing/buildbot/chromium.mac.json
[modify] https://crrev.com/37176bc20f476b852a6139d1fa3d1fda76791709/testing/buildbot/chromium.memory.json
[modify] https://crrev.com/37176bc20f476b852a6139d1fa3d1fda76791709/testing/buildbot/chromium.win.json
[modify] https://crrev.com/37176bc20f476b852a6139d1fa3d1fda76791709/testing/buildbot/test_suites.pyl

Project Member

Comment 21 by bugdroid1@chromium.org, Apr 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1a6128fbfa12d9bb57b95f16eef5bbd76593f9ea

commit 1a6128fbfa12d9bb57b95f16eef5bbd76593f9ea
Author: Misha Efimov <mef@google.com>
Date: Wed Apr 11 19:46:37 2018

[Cronet] Reference Cronet_Buffer_Create to avoid stripping from iOS static build.

Internal issue b/77525665

Bug:  786559 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I1e24b1d8f7ed1cc1fd9a2ac211c02f5b2ed54ab6
Reviewed-on: https://chromium-review.googlesource.com/1007644
Reviewed-by: Andrei Kapishnikov <kapishnikov@chromium.org>
Commit-Queue: Misha Efimov <mef@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549944}
[modify] https://crrev.com/1a6128fbfa12d9bb57b95f16eef5bbd76593f9ea/components/cronet/ios/Cronet.mm

Project Member

Comment 22 by bugdroid1@chromium.org, May 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d16a27aaf5fe376b341c62d11955305abfb2fede

commit d16a27aaf5fe376b341c62d11955305abfb2fede
Author: Misha Efimov <mef@chromium.org>
Date: Tue May 29 15:03:44 2018

[Cronet] Move CronetUploadDataProvider up from Android to common code for use in Native API.

Bug:  786559 
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I45c0e40f09bb2f4558a3622b9e492df675e142c0
Reviewed-on: https://chromium-review.googlesource.com/1073201
Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Commit-Queue: Misha Efimov <mef@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562425}
[modify] https://crrev.com/d16a27aaf5fe376b341c62d11955305abfb2fede/components/cronet/BUILD.gn
[modify] https://crrev.com/d16a27aaf5fe376b341c62d11955305abfb2fede/components/cronet/android/BUILD.gn
[modify] https://crrev.com/d16a27aaf5fe376b341c62d11955305abfb2fede/components/cronet/android/cronet_upload_data_stream_adapter.h
[rename] https://crrev.com/d16a27aaf5fe376b341c62d11955305abfb2fede/components/cronet/cronet_upload_data_stream.cc
[rename] https://crrev.com/d16a27aaf5fe376b341c62d11955305abfb2fede/components/cronet/cronet_upload_data_stream.h

Blocking: 852432
Blockedon: 869402
Blockedon: 869406
Blockedon: 829077
Blockedon: 874542
Project Member

Comment 28 by bugdroid1@chromium.org, Aug 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8be314723577cf6076e29056f4f699312a1e4529

commit 8be314723577cf6076e29056f4f699312a1e4529
Author: Misha Efimov <mef@chromium.org>
Date: Mon Aug 20 16:07:49 2018

[Cronet] Implement native UploadDataStream API.

Bug:  786559 
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ied0c3de493c817e0836fcf42e09736509acbd2d1
Reviewed-on: https://chromium-review.googlesource.com/1086127
Commit-Queue: Misha Efimov <mef@chromium.org>
Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584464}
[modify] https://crrev.com/8be314723577cf6076e29056f4f699312a1e4529/components/cronet/native/BUILD.gn
[modify] https://crrev.com/8be314723577cf6076e29056f4f699312a1e4529/components/cronet/native/buffer.cc
[modify] https://crrev.com/8be314723577cf6076e29056f4f699312a1e4529/components/cronet/native/cronet.idl
[modify] https://crrev.com/8be314723577cf6076e29056f4f699312a1e4529/components/cronet/native/generated/cronet.idl_c.h
[modify] https://crrev.com/8be314723577cf6076e29056f4f699312a1e4529/components/cronet/native/generated/cronet.idl_impl_interface.cc
[modify] https://crrev.com/8be314723577cf6076e29056f4f699312a1e4529/components/cronet/native/generated/cronet.idl_impl_interface.h
[modify] https://crrev.com/8be314723577cf6076e29056f4f699312a1e4529/components/cronet/native/generated/cronet.idl_impl_interface_unittest.cc
[modify] https://crrev.com/8be314723577cf6076e29056f4f699312a1e4529/components/cronet/native/io_buffer_with_cronet_buffer.cc
[modify] https://crrev.com/8be314723577cf6076e29056f4f699312a1e4529/components/cronet/native/io_buffer_with_cronet_buffer.h
[modify] https://crrev.com/8be314723577cf6076e29056f4f699312a1e4529/components/cronet/native/test/BUILD.gn
[add] https://crrev.com/8be314723577cf6076e29056f4f699312a1e4529/components/cronet/native/test/test_upload_data_provider.cc
[add] https://crrev.com/8be314723577cf6076e29056f4f699312a1e4529/components/cronet/native/test/test_upload_data_provider.h
[modify] https://crrev.com/8be314723577cf6076e29056f4f699312a1e4529/components/cronet/native/test/test_url_request_callback.cc
[modify] https://crrev.com/8be314723577cf6076e29056f4f699312a1e4529/components/cronet/native/test/test_url_request_callback.h
[modify] https://crrev.com/8be314723577cf6076e29056f4f699312a1e4529/components/cronet/native/test/url_request_test.cc
[add] https://crrev.com/8be314723577cf6076e29056f4f699312a1e4529/components/cronet/native/upload_data_sink.cc
[add] https://crrev.com/8be314723577cf6076e29056f4f699312a1e4529/components/cronet/native/upload_data_sink.h
[modify] https://crrev.com/8be314723577cf6076e29056f4f699312a1e4529/components/cronet/native/url_request.cc
[modify] https://crrev.com/8be314723577cf6076e29056f4f699312a1e4529/components/cronet/native/url_request.h

Blockedon: 879209 879214 879208
Blocking: 879211
I've added bugs for granular tasks remaining for Native API.
Blockedon: 878866
Project Member

Comment 31 by bugdroid1@chromium.org, Oct 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0edcce331b3bffeb021552de2e6953ed003a5763

commit 0edcce331b3bffeb021552de2e6953ed003a5763
Author: Misha Efimov <mef@chromium.org>
Date: Wed Oct 03 19:09:29 2018

[Cronet] Add cronet_package target for desktop platforms.

The cronet_package target packages cronet library, headers and license into $root_out_dir/cronet.
Disable histogram manager on Mac and Win platforms to reduce binary size.

Bug:  786559 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;master.tryserver.chromium.android:android_cronet_tester
Change-Id: I3f5ac065e405734260926ea774b9fa08efa4d060
Reviewed-on: https://chromium-review.googlesource.com/c/1255802
Commit-Queue: Misha Efimov <mef@chromium.org>
Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596311}
[modify] https://crrev.com/0edcce331b3bffeb021552de2e6953ed003a5763/components/cronet/BUILD.gn
[modify] https://crrev.com/0edcce331b3bffeb021552de2e6953ed003a5763/components/cronet/cronet_url_request_context.cc

Project Member

Comment 32 by bugdroid1@chromium.org, Oct 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5e6f91c6b041ebfb703dee600260c3a2aa30069f

commit 5e6f91c6b041ebfb703dee600260c3a2aa30069f
Author: Misha Efimov <mef@chromium.org>
Date: Fri Oct 12 17:56:27 2018

[Cronet] Add package_mac.py script to build dbg and opt packages for Mac.

This could be used to make consistent builds of Cronet before official builders are available.

Bug:  786559 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;master.tryserver.chromium.android:android_cronet_tester
Change-Id: I5154f9e4461cdae1cbe07dc7e4309978d98d8508
Reviewed-on: https://chromium-review.googlesource.com/c/1273824
Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Commit-Queue: Misha Efimov <mef@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599284}
[modify] https://crrev.com/5e6f91c6b041ebfb703dee600260c3a2aa30069f/components/cronet/BUILD.gn
[modify] https://crrev.com/5e6f91c6b041ebfb703dee600260c3a2aa30069f/components/cronet/tools/cr_cronet.py
[add] https://crrev.com/5e6f91c6b041ebfb703dee600260c3a2aa30069f/components/cronet/tools/package_mac.py

Project Member

Comment 33 by bugdroid1@chromium.org, Oct 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b54f7c7f72e84d51102a6a4712ff55af9fae0cf6

commit b54f7c7f72e84d51102a6a4712ff55af9fae0cf6
Author: Misha Efimov <mef@chromium.org>
Date: Wed Oct 17 17:03:28 2018

[Cronet] Create a sample app for native api.

Bug:  786559 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;master.tryserver.chromium.android:android_cronet_tester
Change-Id: I56fa2a6f9f6277fe33ea78e7dc01beffd32cbed6
Reviewed-on: https://chromium-review.googlesource.com/c/1274426
Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Commit-Queue: Misha Efimov <mef@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600438}
[modify] https://crrev.com/b54f7c7f72e84d51102a6a4712ff55af9fae0cf6/components/cronet/BUILD.gn
[add] https://crrev.com/b54f7c7f72e84d51102a6a4712ff55af9fae0cf6/components/cronet/native/sample/DEPS
[add] https://crrev.com/b54f7c7f72e84d51102a6a4712ff55af9fae0cf6/components/cronet/native/sample/main.cc
[add] https://crrev.com/b54f7c7f72e84d51102a6a4712ff55af9fae0cf6/components/cronet/native/sample/sample_executor.cc
[add] https://crrev.com/b54f7c7f72e84d51102a6a4712ff55af9fae0cf6/components/cronet/native/sample/sample_executor.h
[add] https://crrev.com/b54f7c7f72e84d51102a6a4712ff55af9fae0cf6/components/cronet/native/sample/sample_url_request_callback.cc
[add] https://crrev.com/b54f7c7f72e84d51102a6a4712ff55af9fae0cf6/components/cronet/native/sample/sample_url_request_callback.h
[add] https://crrev.com/b54f7c7f72e84d51102a6a4712ff55af9fae0cf6/components/cronet/native/sample/test/sample_test.cc

Project Member

Comment 34 by bugdroid1@chromium.org, Oct 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1e0ee862f14dec28b37b42e129557ecefe512075

commit 1e0ee862f14dec28b37b42e129557ecefe512075
Author: Thomas Guilbert <tguilbert@chromium.org>
Date: Wed Oct 17 17:29:10 2018

Revert "[Cronet] Create a sample app for native api."

This reverts commit b54f7c7f72e84d51102a6a4712ff55af9fae0cf6.

Reason for revert: breaking the tree

Original change's description:
> [Cronet] Create a sample app for native api.
> 
> Bug:  786559 
> Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;master.tryserver.chromium.android:android_cronet_tester
> Change-Id: I56fa2a6f9f6277fe33ea78e7dc01beffd32cbed6
> Reviewed-on: https://chromium-review.googlesource.com/c/1274426
> Reviewed-by: Paul Jensen <pauljensen@chromium.org>
> Commit-Queue: Misha Efimov <mef@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#600438}

TBR=pauljensen@chromium.org,mef@chromium.org

Change-Id: I3cc86a29982f4479a3260ec2522847416fe6547b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  786559 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;master.tryserver.chromium.android:android_cronet_tester
Reviewed-on: https://chromium-review.googlesource.com/c/1286935
Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600444}
[modify] https://crrev.com/1e0ee862f14dec28b37b42e129557ecefe512075/components/cronet/BUILD.gn
[delete] https://crrev.com/a8c80fc59c268088ec6c52d5b00f6f482d8b6d7a/components/cronet/native/sample/DEPS
[delete] https://crrev.com/a8c80fc59c268088ec6c52d5b00f6f482d8b6d7a/components/cronet/native/sample/main.cc
[delete] https://crrev.com/a8c80fc59c268088ec6c52d5b00f6f482d8b6d7a/components/cronet/native/sample/sample_executor.cc
[delete] https://crrev.com/a8c80fc59c268088ec6c52d5b00f6f482d8b6d7a/components/cronet/native/sample/sample_executor.h
[delete] https://crrev.com/a8c80fc59c268088ec6c52d5b00f6f482d8b6d7a/components/cronet/native/sample/sample_url_request_callback.cc
[delete] https://crrev.com/a8c80fc59c268088ec6c52d5b00f6f482d8b6d7a/components/cronet/native/sample/sample_url_request_callback.h
[delete] https://crrev.com/a8c80fc59c268088ec6c52d5b00f6f482d8b6d7a/components/cronet/native/sample/test/sample_test.cc

Project Member

Comment 35 by bugdroid1@chromium.org, Oct 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ddb201c7cdecc6ffa90d6b0a558e238e82f52769

commit ddb201c7cdecc6ffa90d6b0a558e238e82f52769
Author: Misha Efimov <mef@chromium.org>
Date: Wed Oct 17 20:08:37 2018

[Cronet] Fix cr_cronet.py script.

The cr_cronet.py script got broken by https://chromium-review.googlesource.com/c/chromium/src/+/1273824.
This change fixes it.

Bug:  786559 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;master.tryserver.chromium.android:android_cronet_tester
Change-Id: Ic71a1eee5041a27bfe51d706e7d16a4d83c6ee7e
Reviewed-on: https://chromium-review.googlesource.com/c/1286739
Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Commit-Queue: Misha Efimov <mef@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600533}
[modify] https://crrev.com/ddb201c7cdecc6ffa90d6b0a558e238e82f52769/components/cronet/tools/cr_cronet.py

Project Member

Comment 36 by bugdroid1@chromium.org, Oct 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a7332e279ecb3bb34021484ef14f998b92276bdf

commit a7332e279ecb3bb34021484ef14f998b92276bdf
Author: Misha Efimov <mef@chromium.org>
Date: Thu Oct 18 13:21:26 2018

Reland "[Cronet] Create a sample app for native api."

This reverts commit 1e0ee862f14dec28b37b42e129557ecefe512075.

Reason for revert: Don't use popen() as it is not available on Windows.

Original change's description:
> Revert "[Cronet] Create a sample app for native api."
>
> This reverts commit b54f7c7f72e84d51102a6a4712ff55af9fae0cf6.
>
> Reason for revert: breaking the tree
>
> Original change's description:
> > [Cronet] Create a sample app for native api.
> >
> > Bug:  786559 
> > Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;master.tryserver.chromium.android:android_cronet_tester
> > Change-Id: I56fa2a6f9f6277fe33ea78e7dc01beffd32cbed6
> > Reviewed-on: https://chromium-review.googlesource.com/c/1274426
> > Reviewed-by: Paul Jensen <pauljensen@chromium.org>
> > Commit-Queue: Misha Efimov <mef@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#600438}
>
> TBR=pauljensen@chromium.org,mef@chromium.org
>
> Change-Id: I3cc86a29982f4479a3260ec2522847416fe6547b
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug:  786559 
> Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;master.tryserver.chromium.android:android_cronet_tester
> Reviewed-on: https://chromium-review.googlesource.com/c/1286935
> Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#600444}

TBR=tguilbert@chromium.org

Change-Id: I4935a11d8f20e97122fccd9451a201d135d5db8a
Bug:  786559 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;master.tryserver.chromium.android:android_cronet_tester
Reviewed-on: https://chromium-review.googlesource.com/c/1286745
Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Commit-Queue: Misha Efimov <mef@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600743}
[modify] https://crrev.com/a7332e279ecb3bb34021484ef14f998b92276bdf/components/cronet/BUILD.gn
[add] https://crrev.com/a7332e279ecb3bb34021484ef14f998b92276bdf/components/cronet/native/sample/DEPS
[add] https://crrev.com/a7332e279ecb3bb34021484ef14f998b92276bdf/components/cronet/native/sample/main.cc
[add] https://crrev.com/a7332e279ecb3bb34021484ef14f998b92276bdf/components/cronet/native/sample/sample_executor.cc
[add] https://crrev.com/a7332e279ecb3bb34021484ef14f998b92276bdf/components/cronet/native/sample/sample_executor.h
[add] https://crrev.com/a7332e279ecb3bb34021484ef14f998b92276bdf/components/cronet/native/sample/sample_url_request_callback.cc
[add] https://crrev.com/a7332e279ecb3bb34021484ef14f998b92276bdf/components/cronet/native/sample/sample_url_request_callback.h
[add] https://crrev.com/a7332e279ecb3bb34021484ef14f998b92276bdf/components/cronet/native/sample/test/sample_test.cc

Project Member

Comment 37 by bugdroid1@chromium.org, Oct 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2930a5ac88799ddbe9dbc816ebcce49b3afb12f8

commit 2930a5ac88799ddbe9dbc816ebcce49b3afb12f8
Author: Misha Efimov <mef@chromium.org>
Date: Thu Oct 25 15:54:11 2018

[Cronet] Invoke UrlRequestCallback_OnRedirectReceived with new location instead of original url.

Bug:  786559 
Change-Id: Icf651c2f47c6bed80bd9e5b07feca04b32ef7119
Reviewed-on: https://chromium-review.googlesource.com/c/1298188
Reviewed-by: Misha Efimov <mef@chromium.org>
Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Commit-Queue: Misha Efimov <mef@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602723}
[modify] https://crrev.com/2930a5ac88799ddbe9dbc816ebcce49b3afb12f8/components/cronet/native/test/url_request_test.cc
[modify] https://crrev.com/2930a5ac88799ddbe9dbc816ebcce49b3afb12f8/components/cronet/native/url_request.cc
[modify] https://crrev.com/2930a5ac88799ddbe9dbc816ebcce49b3afb12f8/components/cronet/native/url_request.h

Project Member

Comment 38 by bugdroid1@chromium.org, Dec 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b0cd9fa52aa185ef99e15b72de529740e3d3f3e4

commit b0cd9fa52aa185ef99e15b72de529740e3d3f3e4
Author: Caleb Raitto <caraitto@chromium.org>
Date: Thu Dec 13 19:15:04 2018

[Cronet] Add documentation on runing native tests.

As part of this, refactor the checkout and build from the Android docs into
a common doc referenced by both Android and native.

Bug:  786559 
Change-Id: Ibc6ebb299d878cd27c2d88af2d6366bf5b0aa5ce
Reviewed-on: https://chromium-review.googlesource.com/c/1363439
Commit-Queue: Caleb Raitto <caraitto@chromium.org>
Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Reviewed-by: Misha Efimov <mef@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616384}
[modify] https://crrev.com/b0cd9fa52aa185ef99e15b72de529740e3d3f3e4/components/cronet/README.md
[delete] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/components/cronet/android/build_instructions.md
[add] https://crrev.com/b0cd9fa52aa185ef99e15b72de529740e3d3f3e4/components/cronet/android/test_instructions.md
[add] https://crrev.com/b0cd9fa52aa185ef99e15b72de529740e3d3f3e4/components/cronet/build_instructions.md
[add] https://crrev.com/b0cd9fa52aa185ef99e15b72de529740e3d3f3e4/components/cronet/native/test_instructions.md

Status: Fixed (was: Started)
Summary: Cronet should provide Native API for use on Android and iOS (was: Cronet should provide C++ API for native use on Android and iOS)
We've implemented C API, may implement additional bindings later.
Project Member

Comment 40 by bugdroid1@chromium.org, Jan 18 (5 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5ccedfdfefc2a9feb851963c0bee0410ece14abe

commit 5ccedfdfefc2a9feb851963c0bee0410ece14abe
Author: Misha Efimov <mef@google.com>
Date: Fri Jan 18 16:03:36 2019

[Cronet] Add const qualifier to generated struct accessor functions.

This will allow API callers to avoid the need to needlessly cast away
const when calling these methods.

Bug:  786559 
Change-Id: Iea6ada8cabc14823ba0a766bbb5e624a91a59886
Reviewed-on: https://chromium-review.googlesource.com/c/1409904
Commit-Queue: Misha Efimov <mef@chromium.org>
Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624143}
[modify] https://crrev.com/5ccedfdfefc2a9feb851963c0bee0410ece14abe/components/cronet/native/generated/cronet.idl_c.h
[modify] https://crrev.com/5ccedfdfefc2a9feb851963c0bee0410ece14abe/components/cronet/native/generated/cronet.idl_impl_struct.cc
[modify] https://crrev.com/5ccedfdfefc2a9feb851963c0bee0410ece14abe/components/cronet/tools/generators/c_templates/module_c.h.tmpl
[modify] https://crrev.com/5ccedfdfefc2a9feb851963c0bee0410ece14abe/components/cronet/tools/generators/c_templates/module_impl_struct.cc.tmpl

Sign in to add a comment